* upstream/master: (103 commits)
  Fix broken Frontend JS guide
  Replace 'project/star.feature' spinach test with an rspec analog
  Adds position fixed to right sidebar
  Decrease Metrics/CyclomaticComplexity threshold to 15
  Prevents rendering empty badge when pipeline request fails
  Make file encoding dropdown consistent
  Fixes the diff changes buttons from toggling when scrolling
  exclude spec/ and features/ from `Style/PredicateName` cop
  Resolve "Monitoring graph date formatting is wrong"
  add changelog
  replace `is_ancestor` with `ancestor?`
  replace `is_member_of` with `member_of?`
  replace `has_n_stars` with `has_n_stars?`
  replace `has_matching_label` with `has_matching_label?`
  replace `is_team_member?` with `team_member?`
  replace `is_spam?` with `spam?`
  replace `is_default_branch?` with `default_branch?`
  replace `is_successful?` with `successful?`
  replace `is_multi_check?` with `multi_check?`
  replace `is_gitlab_user?` with `gitlab_user?`
  ...