Apply A-few-more-improvements patch

Perfomance and readability optimizations

spec/factories/ci/pipelines.rb

@@ -40,6 +40,10 @@ FactoryBot.define do
       end
     end
 
+    trait :created do
+      status { :created }
+    end
+
     factory :ci_pipeline do
       transient { ci_ref_presence { true } }
 
@@ -53,10 +57,6 @@ FactoryBot.define do
         failure_reason { :config_error }
       end
 
-      trait :created do
-        status { :created }
-      end
-
       trait :preparing do
         status { :preparing }
       end