Replace fa-search-* icons with GitLab SVG icons

Switched positions of minus to be on the left and
plus to be on the right for better UX.

app/views/profiles/show.html.haml

@@ -135,10 +135,12 @@
           %img.modal-profile-crop-image{ alt: s_("Profiles|Avatar cropper") }
         .crop-controls
           .btn-group
-            %button.btn.btn-primary{ data: { method: 'zoom', option: '0.1' } }
-              %span.fa.fa-search-plus
             %button.btn.btn-primary{ data: { method: 'zoom', option: '-0.1' } }
-              %span.fa.fa-search-minus
+              %span
+                = sprite_icon('search-minus')
+            %button.btn.btn-primary{ data: { method: 'zoom', option: '0.1' } }
+              %span
+                = sprite_icon('search-plus')
       .modal-footer
         %button.btn.btn-primary.js-upload-user-avatar{ type: 'button' }
           = s_("Profiles|Set new profile picture")

changelogs/unreleased/225207-replace-fa-search-icons-with-gitlab-svg-icons.yml

+---
+title: Replace fa-search-* icons with GitLab SVG icons
+merge_request: 40580
+author:
+type: changed