Commit 04593581 authored by Robert Schilling's avatar Robert Schilling

API: Fix Sytem hooks delete behavior

parent fbeaa751
...@@ -98,11 +98,8 @@ Example response: ...@@ -98,11 +98,8 @@ Example response:
## Delete system hook ## Delete system hook
Deletes a system hook. This is an idempotent API function and returns `200 OK` Deletes a system hook. It returns `200 OK` if the hooks is deleted and
even if the hook is not available. `404 Not Found` if the hook is not found.
If the hook is deleted, a JSON object is returned. An error is raised if the
hook is not found.
--- ---
......
...@@ -56,12 +56,10 @@ module API ...@@ -56,12 +56,10 @@ module API
requires :id, type: Integer, desc: 'The ID of the system hook' requires :id, type: Integer, desc: 'The ID of the system hook'
end end
delete ":id" do delete ":id" do
begin hook = SystemHook.find_by(id: params[:id])
hook = SystemHook.find(params[:id]) not_found!('System hook') unless hook
present hook.destroy, with: Entities::Hook present hook.destroy, with: Entities::Hook
rescue
# SystemHook raises an Error if no hook with id found
end
end end
end end
end end
......
...@@ -73,9 +73,10 @@ describe API::API, api: true do ...@@ -73,9 +73,10 @@ describe API::API, api: true do
end.to change { SystemHook.count }.by(-1) end.to change { SystemHook.count }.by(-1)
end end
it "returns success if hook id not found" do it 'returns 404 if the system hook does not exist' do
delete api("/hooks/12345", admin) delete api('/hooks/12345', admin)
expect(response).to have_http_status(200)
expect(response).to have_http_status(404)
end end
end end
end end
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment