Commit 06d5b533 authored by Jacob Vosmaer's avatar Jacob Vosmaer

Avoid duplicate group membership emails

parent 9afcb64e
...@@ -4,6 +4,6 @@ class UsersGroupObserver < BaseObserver ...@@ -4,6 +4,6 @@ class UsersGroupObserver < BaseObserver
end end
def after_update(membership) def after_update(membership)
notification.update_group_member(membership) notification.update_group_member(membership) if membership.group_access_changed?
end end
end end
...@@ -23,5 +23,10 @@ describe UsersGroupObserver do ...@@ -23,5 +23,10 @@ describe UsersGroupObserver do
subject.should_receive(:notification) subject.should_receive(:notification)
@membership.update_attribute(:group_access, UsersGroup::MASTER) @membership.update_attribute(:group_access, UsersGroup::MASTER)
end end
it "does not send an email when the access level has not changed" do
subject.should_not_receive(:notification)
@membership.update_attribute(:group_access, UsersGroup::OWNER)
end
end end
end end
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment