Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
07adee30
Commit
07adee30
authored
May 11, 2018
by
Robert Speicher
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add Code Review documentation that maintainers also perform code review
parent
8284118f
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
0 deletions
+4
-0
doc/development/code_review.md
doc/development/code_review.md
+4
-0
No files found.
doc/development/code_review.md
View file @
07adee30
...
@@ -29,6 +29,10 @@ There are a few rules to get your merge request accepted:
...
@@ -29,6 +29,10 @@ There are a few rules to get your merge request accepted:
to ask one of the
[
Merge request coaches
][
team
]
.
to ask one of the
[
Merge request coaches
][
team
]
.
1.
The reviewer will assign the merge request to a maintainer once the
1.
The reviewer will assign the merge request to a maintainer once the
reviewer is satisfied with the state of the merge request.
reviewer is satisfied with the state of the merge request.
1.
Keep in mind that maintainers are also going to perform a final code review.
The ideal scenario is that the reviewer has already addressed any concerns
the maintainer would have found, and the maintainer only has to perform the
merge, but be prepared for further review comments.
For more guidance, see
[
CONTRIBUTING.md
](
https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md
)
.
For more guidance, see
[
CONTRIBUTING.md
](
https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md
)
.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment