Use a smarter way to transation to multi LDAP links push

app/models/group.rb

@@ -89,12 +89,4 @@ class Group < Namespace
   def ldap_access
     ldap_group_links.first.try(:group_access)
   end
-
-  def old_ldap_cn
-    read_attribute(:ldap_cn)
-  end
-
-  def old_ldap_access
-    read_attribute(:ldap_access)
-  end
 end

app/services/ldap_group_reset_service.rb

 class LdapGroupResetService
   def execute(group, current_user)
+    # Only for ldap connected users
+    # reset last_credential_check_at
+    # set Gitlab::Access::Guest
     group.members.includes(:user).each do |member|
       user = member.user
 

db/migrate/20140813133925_rename_ldap_group_to_ldap_group_link.rb

@@ -4,9 +4,14 @@ class RenameLdapGroupToLdapGroupLink < ActiveRecord::Migration
 
     # NOTE: we use the old_ methods because the new methods are overloaded
     # for backwards compatibility
+
     Group.where.not(ldap_cn: nil).each do |group|
-      group.ldap_group_links.where(cn: group.old_ldap_cn).first_or_create do |ldap_group_link|
-        ldap_group_link.group_access = group.old_ldap_access
+      # Make sure we use the database column, not the model methods
+      ldap_cn = group.read_attribute(:ldap_cn)
+      ldap_access = group.read_attribute(:ldap_access)
+
+      group.ldap_group_links.where(cn: ldap_cn).first_or_create do |ldap_group_link|
+        ldap_group_link.group_access = ldap_access
       end
     end
   end