Remove skip_settings_check from CreateIssueService

app/services/incident_management/create_issue_service.rb

@@ -17,8 +17,8 @@ module IncidentManagement
       super(project, user, params)
     end
 
-    def execute(skip_settings_check: false)
-      return error_with('setting disabled') unless skip_settings_check || incident_management_setting.create_issue?
+    def execute
+      return error_with('setting disabled') unless incident_management_setting.create_issue?
       return error_with('invalid alert') unless alert.valid?
 
       issue = create_issue

spec/services/incident_management/create_issue_service_spec.rb

@@ -281,22 +281,12 @@ describe IncidentManagement::CreateIssueService do
       setting.update!(create_issue: false)
     end
 
-    context 'when skip_settings_check is false (default)' do
-      it 'returns an error' do
-        expect(service)
-          .to receive(:log_error)
-          .with(error_message('setting disabled'))
-
-        expect(subject).to eq(status: :error, message: 'setting disabled')
-      end
-    end
-
-    context 'when skip_settings_check is true' do
-      subject { service.execute(skip_settings_check: true) }
+    it 'returns an error' do
+      expect(service)
+        .to receive(:log_error)
+        .with(error_message('setting disabled'))
 
-      it 'creates an issue' do
-        expect { subject }.to change(Issue, :count).by(1)
-      end
+      expect(subject).to eq(status: :error, message: 'setting disabled')
     end
   end