Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
0bdd2ed5
Commit
0bdd2ed5
authored
Sep 11, 2018
by
gfyoung
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Enable frozen string in vestigial files
Partially addresses #47424.
parent
b9ea4e35
Changes
5
Show whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
13 additions
and
0 deletions
+13
-0
app/models/concerns/project_services_loggable.rb
app/models/concerns/project_services_loggable.rb
+2
-0
app/models/hooks/active_hook_filter.rb
app/models/hooks/active_hook_filter.rb
+2
-0
app/validators/branch_filter_validator.rb
app/validators/branch_filter_validator.rb
+2
-0
app/validators/js_regex_validator.rb
app/validators/js_regex_validator.rb
+2
-0
changelogs/unreleased/frozen-string-enable-vestigial.yml
changelogs/unreleased/frozen-string-enable-vestigial.yml
+5
-0
No files found.
app/models/concerns/project_services_loggable.rb
View file @
0bdd2ed5
# frozen_string_literal: true
module
ProjectServicesLoggable
module
ProjectServicesLoggable
def
log_info
(
message
,
params
=
{})
def
log_info
(
message
,
params
=
{})
message
=
build_message
(
message
,
params
)
message
=
build_message
(
message
,
params
)
...
...
app/models/hooks/active_hook_filter.rb
View file @
0bdd2ed5
# frozen_string_literal: true
class
ActiveHookFilter
class
ActiveHookFilter
def
initialize
(
hook
)
def
initialize
(
hook
)
@hook
=
hook
@hook
=
hook
...
...
app/validators/branch_filter_validator.rb
View file @
0bdd2ed5
# frozen_string_literal: true
# BranchFilterValidator
# BranchFilterValidator
#
#
# Custom validator for branch names. Squishes whitespace and ignores empty
# Custom validator for branch names. Squishes whitespace and ignores empty
...
...
app/validators/js_regex_validator.rb
View file @
0bdd2ed5
# frozen_string_literal: true
class
JsRegexValidator
<
ActiveModel
::
EachValidator
class
JsRegexValidator
<
ActiveModel
::
EachValidator
def
validate_each
(
record
,
attribute
,
value
)
def
validate_each
(
record
,
attribute
,
value
)
return
true
if
value
.
blank?
return
true
if
value
.
blank?
...
...
changelogs/unreleased/frozen-string-enable-vestigial.yml
0 → 100644
View file @
0bdd2ed5
---
title
:
Enable frozen string in vestigial files
merge_request
:
author
:
gfyoung
type
:
performance
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment