Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
0f0e70bc
Commit
0f0e70bc
authored
Aug 07, 2018
by
Filipa Lacerda
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Reset error state in success mutation to handle error-success state
parent
d8fc4012
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
12 additions
and
1 deletion
+12
-1
app/assets/javascripts/reports/store/mutations.js
app/assets/javascripts/reports/store/mutations.js
+2
-0
changelogs/unreleased/49966-improve-junit-fe.yml
changelogs/unreleased/49966-improve-junit-fe.yml
+5
-0
spec/javascripts/reports/components/grouped_test_reports_app_spec.js
...ripts/reports/components/grouped_test_reports_app_spec.js
+1
-1
spec/javascripts/reports/store/mutations_spec.js
spec/javascripts/reports/store/mutations_spec.js
+4
-0
No files found.
app/assets/javascripts/reports/store/mutations.js
View file @
0f0e70bc
...
@@ -9,6 +9,8 @@ export default {
...
@@ -9,6 +9,8 @@ export default {
state
.
isLoading
=
true
;
state
.
isLoading
=
true
;
},
},
[
types
.
RECEIVE_REPORTS_SUCCESS
](
state
,
response
)
{
[
types
.
RECEIVE_REPORTS_SUCCESS
](
state
,
response
)
{
// Make sure to clean previous state in case it was an error
state
.
hasError
=
false
;
state
.
isLoading
=
false
;
state
.
isLoading
=
false
;
...
...
changelogs/unreleased/49966-improve-junit-fe.yml
0 → 100644
View file @
0f0e70bc
---
title
:
Renders test reports for resolved failures and resets error state
merge_request
:
author
:
type
:
fixed
spec/javascripts/reports/components/grouped_test_reports_app_spec.js
View file @
0f0e70bc
...
@@ -154,7 +154,7 @@ describe('Grouped Test Reports App', () => {
...
@@ -154,7 +154,7 @@ describe('Grouped Test Reports App', () => {
expect
(
vm
.
$el
.
querySelector
(
'
.js-mr-code-resolved-issues
'
).
textContent
).
toContain
(
expect
(
vm
.
$el
.
querySelector
(
'
.js-mr-code-resolved-issues
'
).
textContent
).
toContain
(
resolvedFailures
.
suites
[
0
].
resolved_failures
[
1
].
name
,
resolvedFailures
.
suites
[
0
].
resolved_failures
[
1
].
name
,
);
);
done
()
done
()
;
},
0
);
},
0
);
});
});
});
});
...
...
spec/javascripts/reports/store/mutations_spec.js
View file @
0f0e70bc
...
@@ -72,6 +72,10 @@ describe('Reports Store Mutations', () => {
...
@@ -72,6 +72,10 @@ describe('Reports Store Mutations', () => {
expect
(
stateCopy
.
isLoading
).
toEqual
(
false
);
expect
(
stateCopy
.
isLoading
).
toEqual
(
false
);
});
});
it
(
'
should reset hasError
'
,
()
=>
{
expect
(
stateCopy
.
hasError
).
toEqual
(
false
);
});
it
(
'
should set summary counts
'
,
()
=>
{
it
(
'
should set summary counts
'
,
()
=>
{
expect
(
stateCopy
.
summary
.
total
).
toEqual
(
mockedResponse
.
summary
.
total
);
expect
(
stateCopy
.
summary
.
total
).
toEqual
(
mockedResponse
.
summary
.
total
);
expect
(
stateCopy
.
summary
.
resolved
).
toEqual
(
mockedResponse
.
summary
.
resolved
);
expect
(
stateCopy
.
summary
.
resolved
).
toEqual
(
mockedResponse
.
summary
.
resolved
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment