Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
10e886c8
Commit
10e886c8
authored
Oct 06, 2020
by
Gilang Gumilar
Committed by
Ezekiel Kigbo
Oct 06, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Replace bootstrap alerts in app/views/projects/milestones/show.html.haml
parent
95927a8a
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
15 additions
and
6 deletions
+15
-6
app/views/projects/milestones/show.html.haml
app/views/projects/milestones/show.html.haml
+8
-4
changelogs/unreleased/233681-replace-bootstrap-alerts-in-app-views-projects-milestones-show-htm.yml
...trap-alerts-in-app-views-projects-milestones-show-htm.yml
+5
-0
spec/features/milestone_spec.rb
spec/features/milestone_spec.rb
+2
-2
No files found.
app/views/projects/milestones/show.html.haml
View file @
10e886c8
...
...
@@ -10,10 +10,14 @@
=
render_if_exists
'shared/milestones/burndown'
,
milestone:
@milestone
,
project:
@project
-
if
can?
(
current_user
,
:read_issue
,
@project
)
&&
@milestone
.
total_issues_count
==
0
.alert.alert-success.gl-mt-3
.gl-alert.gl-alert-info.gl-mt-3.gl-mb-5
{
data:
{
testid:
'no-issues-alert'
}
}
=
sprite_icon
(
'information-o'
,
size:
16
,
css_class:
'gl-icon gl-alert-icon gl-alert-icon-no-title'
)
.gl-alert-body
%span
=
_
(
'Assign some issues to this milestone.'
)
-
elsif
@milestone
.
complete?
&&
@milestone
.
active?
.alert.alert-success.gl-mt-3
.gl-alert.gl-alert-success.gl-mt-3.gl-mb-5
{
data:
{
testid:
'all-issues-closed-alert'
}
}
=
sprite_icon
(
'check-circle'
,
size:
16
,
css_class:
'gl-icon gl-alert-icon gl-alert-icon-no-title'
)
.gl-alert-body
%span
=
_
(
'All issues for this milestone are closed. You may close this milestone now.'
)
=
render
'shared/milestones/tabs'
,
milestone:
@milestone
...
...
changelogs/unreleased/233681-replace-bootstrap-alerts-in-app-views-projects-milestones-show-htm.yml
0 → 100644
View file @
10e886c8
---
title
:
Replace bootstrap alerts in app/views/projects/milestones/show.html.haml
merge_request
:
41396
author
:
Gilang Gumilar
type
:
changed
spec/features/milestone_spec.rb
View file @
10e886c8
...
...
@@ -25,7 +25,7 @@ RSpec.describe 'Milestone' do
find
(
'input[name="commit"]'
).
click
expect
(
find
(
'
.alert-success
'
)).
to
have_content
(
'Assign some issues to this milestone.'
)
expect
(
find
(
'
[data-testid="no-issues-alert"]
'
)).
to
have_content
(
'Assign some issues to this milestone.'
)
expect
(
page
).
to
have_content
(
'Nov 16, 2016–Dec 16, 2016'
)
end
end
...
...
@@ -37,7 +37,7 @@ RSpec.describe 'Milestone' do
create
(
:issue
,
title:
"Bugfix1"
,
project:
project
,
milestone:
milestone
,
state:
"closed"
)
visit
project_milestone_path
(
project
,
milestone
)
expect
(
find
(
'
.alert-success
'
)).
to
have_content
(
'All issues for this milestone are closed. You may close this milestone now.'
)
expect
(
find
(
'
[data-testid="all-issues-closed-alert"]
'
)).
to
have_content
(
'All issues for this milestone are closed. You may close this milestone now.'
)
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment