Merge branch '33561-remove-duplicate-contribute-link' into 'master'

Remove duplicate contribute to gitlab link

Closes #33561

See merge request gitlab-org/gitlab!18217

app/views/layouts/header/_current_user_dropdown.html.haml

@@ -32,6 +32,7 @@
   %li.d-md-none
     = link_to _("Submit feedback"), "https://about.gitlab.com/submit-feedback"
   - if current_user_menu?(:help) || current_user_menu?(:settings) || current_user_menu?(:profile)
+    %li.d-md-none
       = render 'shared/user_dropdown_contributing_link'
   = render_if_exists 'shared/user_dropdown_instance_review'
   - if Gitlab.com?

app/views/layouts/header/_help_dropdown.html.haml

@@ -9,6 +9,7 @@
   %li
     = link_to _("Submit feedback"), "https://about.gitlab.com/submit-feedback"
   - if current_user_menu?(:help) || current_user_menu?(:settings) || current_user_menu?(:profile)
+    %li
       = render 'shared/user_dropdown_contributing_link'
   = render_if_exists 'shared/user_dropdown_instance_review'
   - if Gitlab.com?

app/views/shared/_user_dropdown_contributing_link.html.haml

-%li
-  = link_to "https://about.gitlab.com/contributing", target: '_blank', class: 'text-nowrap' do
+= link_to "https://about.gitlab.com/contributing", target: '_blank', class: 'text-nowrap' do
   = _("Contribute to GitLab")