Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
19a90fe4
Commit
19a90fe4
authored
Nov 05, 2017
by
Shinya Maeda
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add TimeCop freeze for DST and Regular time
parent
1d5f2f9c
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
42 additions
and
6 deletions
+42
-6
spec/lib/gitlab/ci/cron_parser_spec.rb
spec/lib/gitlab/ci/cron_parser_spec.rb
+42
-6
No files found.
spec/lib/gitlab/ci/cron_parser_spec.rb
View file @
19a90fe4
...
@@ -77,12 +77,24 @@ describe Gitlab::Ci::CronParser do
...
@@ -77,12 +77,24 @@ describe Gitlab::Ci::CronParser do
it_behaves_like
"returns time in the future"
it_behaves_like
"returns time in the future"
context
'when PST (Pacific Standard Time)'
do
it
'converts time in server time zone'
do
it
'converts time in server time zone'
do
Timecop
.
freeze
(
Time
.
utc
(
2017
,
1
,
1
))
do
expect
(
subject
.
hour
).
to
eq
(
hour_in_utc
)
expect
(
subject
.
hour
).
to
eq
(
hour_in_utc
)
end
end
end
end
end
end
context
'when PDT (Pacific Daylight Time)'
do
it
'converts time in server time zone'
do
Timecop
.
freeze
(
Time
.
utc
(
2017
,
6
,
1
))
do
expect
(
subject
.
hour
).
to
eq
(
hour_in_utc
)
end
end
end
end
end
context
'when cron_timezone is ActiveSupport::TimeZone format'
do
context
'when cron_timezone is ActiveSupport::TimeZone format'
do
before
do
before
do
allow
(
Time
).
to
receive
(
:zone
)
allow
(
Time
).
to
receive
(
:zone
)
...
@@ -100,10 +112,22 @@ describe Gitlab::Ci::CronParser do
...
@@ -100,10 +112,22 @@ describe Gitlab::Ci::CronParser do
it_behaves_like
"returns time in the future"
it_behaves_like
"returns time in the future"
context
'when CET (Central European Time)'
do
it
'converts time in server time zone'
do
Timecop
.
freeze
(
Time
.
utc
(
2017
,
1
,
1
))
do
expect
(
subject
.
hour
).
to
eq
(
hour_in_utc
)
end
end
end
context
'when CEST (Central European Summer Time)'
do
it
'converts time in server time zone'
do
it
'converts time in server time zone'
do
Timecop
.
freeze
(
Time
.
utc
(
2017
,
6
,
1
))
do
expect
(
subject
.
hour
).
to
eq
(
hour_in_utc
)
expect
(
subject
.
hour
).
to
eq
(
hour_in_utc
)
end
end
end
end
end
end
context
'when cron_timezone is Eastern Time (US & Canada)'
do
context
'when cron_timezone is Eastern Time (US & Canada)'
do
let
(
:cron
)
{
'* 0 * * *'
}
let
(
:cron
)
{
'* 0 * * *'
}
...
@@ -111,12 +135,24 @@ describe Gitlab::Ci::CronParser do
...
@@ -111,12 +135,24 @@ describe Gitlab::Ci::CronParser do
it_behaves_like
"returns time in the future"
it_behaves_like
"returns time in the future"
context
'when EST (Eastern Standard Time)'
do
it
'converts time in server time zone'
do
Timecop
.
freeze
(
Time
.
utc
(
2017
,
1
,
1
))
do
expect
(
subject
.
hour
).
to
eq
(
hour_in_utc
)
end
end
end
context
'when EDT (Eastern Daylight Time)'
do
it
'converts time in server time zone'
do
it
'converts time in server time zone'
do
Timecop
.
freeze
(
Time
.
utc
(
2017
,
6
,
1
))
do
expect
(
subject
.
hour
).
to
eq
(
hour_in_utc
)
expect
(
subject
.
hour
).
to
eq
(
hour_in_utc
)
end
end
end
end
end
end
end
end
end
end
context
'when cron and cron_timezone are invalid'
do
context
'when cron and cron_timezone are invalid'
do
let
(
:cron
)
{
'invalid_cron'
}
let
(
:cron
)
{
'invalid_cron'
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment