Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
1aff5d45
Commit
1aff5d45
authored
Oct 16, 2020
by
Camellia X Yang
Committed by
Vitaly Slobodin
Oct 16, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Migrate deprecated tooltip in group list view
parent
4ee28e9d
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
5 additions
and
6 deletions
+5
-6
app/assets/javascripts/groups/components/item_stats_value.vue
...assets/javascripts/groups/components/item_stats_value.vue
+3
-4
spec/frontend/groups/components/group_item_spec.js
spec/frontend/groups/components/group_item_spec.js
+1
-1
spec/frontend/groups/components/item_stats_value_spec.js
spec/frontend/groups/components/item_stats_value_spec.js
+1
-1
No files found.
app/assets/javascripts/groups/components/item_stats_value.vue
View file @
1aff5d45
<
script
>
<
script
>
import
{
GlIcon
}
from
'
@gitlab/ui
'
;
import
{
GlIcon
,
GlTooltipDirective
}
from
'
@gitlab/ui
'
;
import
tooltip
from
'
~/vue_shared/directives/tooltip
'
;
export
default
{
export
default
{
components
:
{
components
:
{
GlIcon
,
GlIcon
,
},
},
directives
:
{
directives
:
{
tooltip
,
GlTooltip
:
GlTooltipDirective
,
},
},
props
:
{
props
:
{
title
:
{
title
:
{
...
@@ -51,7 +50,7 @@ export default {
...
@@ -51,7 +50,7 @@ export default {
<
template
>
<
template
>
<span
<span
v-tooltip
v-
gl-
tooltip
:data-placement=
"tooltipPlacement"
:data-placement=
"tooltipPlacement"
:class=
"cssClass"
:class=
"cssClass"
:title=
"title"
:title=
"title"
...
...
spec/frontend/groups/components/group_item_spec.js
View file @
1aff5d45
...
@@ -203,7 +203,7 @@ describe('GroupItemComponent', () => {
...
@@ -203,7 +203,7 @@ describe('GroupItemComponent', () => {
expect
(
vm
.
$el
.
querySelector
(
'
.title a.no-expand
'
)).
toBeDefined
();
expect
(
vm
.
$el
.
querySelector
(
'
.title a.no-expand
'
)).
toBeDefined
();
expect
(
visibilityIconEl
).
not
.
toBe
(
null
);
expect
(
visibilityIconEl
).
not
.
toBe
(
null
);
expect
(
visibilityIconEl
.
dataset
.
originalT
itle
).
toBe
(
vm
.
visibilityTooltip
);
expect
(
visibilityIconEl
.
t
itle
).
toBe
(
vm
.
visibilityTooltip
);
expect
(
visibilityIconEl
.
querySelectorAll
(
'
svg
'
).
length
).
toBeGreaterThan
(
0
);
expect
(
visibilityIconEl
.
querySelectorAll
(
'
svg
'
).
length
).
toBeGreaterThan
(
0
);
expect
(
vm
.
$el
.
querySelector
(
'
.access-type
'
)).
toBeDefined
();
expect
(
vm
.
$el
.
querySelector
(
'
.access-type
'
)).
toBeDefined
();
...
...
spec/frontend/groups/components/item_stats_value_spec.js
View file @
1aff5d45
...
@@ -49,7 +49,7 @@ describe('ItemStatsValue', () => {
...
@@ -49,7 +49,7 @@ describe('ItemStatsValue', () => {
});
});
it
(
'
renders element tooltip correctly
'
,
()
=>
{
it
(
'
renders element tooltip correctly
'
,
()
=>
{
expect
(
wrapper
.
attributes
(
'
data-original-
title
'
)).
toBe
(
'
Subgroups
'
);
expect
(
wrapper
.
attributes
(
'
title
'
)).
toBe
(
'
Subgroups
'
);
expect
(
wrapper
.
attributes
(
'
data-placement
'
)).
toBe
(
'
left
'
);
expect
(
wrapper
.
attributes
(
'
data-placement
'
)).
toBe
(
'
left
'
);
});
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment