Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
1cd35327
Commit
1cd35327
authored
Nov 13, 2020
by
Heinrich Lee Yu
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix type definitions for milestone resolvers
Add missing type definitions and fix the one for the base class
parent
0be88112
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
5 additions
and
3 deletions
+5
-3
.rubocop_manual_todo.yml
.rubocop_manual_todo.yml
+0
-2
app/graphql/resolvers/group_milestones_resolver.rb
app/graphql/resolvers/group_milestones_resolver.rb
+2
-0
app/graphql/resolvers/milestones_resolver.rb
app/graphql/resolvers/milestones_resolver.rb
+1
-1
app/graphql/resolvers/project_milestones_resolver.rb
app/graphql/resolvers/project_milestones_resolver.rb
+2
-0
No files found.
.rubocop_manual_todo.yml
View file @
1cd35327
...
...
@@ -51,13 +51,11 @@ Graphql/ResolverType:
-
'
app/graphql/resolvers/error_tracking/sentry_error_stack_trace_resolver.rb'
-
'
app/graphql/resolvers/group_issues_resolver.rb'
-
'
app/graphql/resolvers/group_merge_requests_resolver.rb'
-
'
app/graphql/resolvers/group_milestones_resolver.rb'
-
'
app/graphql/resolvers/members_resolver.rb'
-
'
app/graphql/resolvers/merge_request_pipelines_resolver.rb'
-
'
app/graphql/resolvers/merge_request_resolver.rb'
-
'
app/graphql/resolvers/merge_requests_resolver.rb'
-
'
app/graphql/resolvers/project_merge_requests_resolver.rb'
-
'
app/graphql/resolvers/project_milestones_resolver.rb'
-
'
app/graphql/resolvers/project_pipelines_resolver.rb'
-
'
app/graphql/resolvers/projects/snippets_resolver.rb'
-
'
app/graphql/resolvers/snippets_resolver.rb'
...
...
app/graphql/resolvers/group_milestones_resolver.rb
View file @
1cd35327
...
...
@@ -6,6 +6,8 @@ module Resolvers
required:
false
,
description:
'Also return milestones in all subgroups and subprojects'
type
Types
::
MilestoneType
.
connection_type
,
null:
true
private
def
parent_id_parameters
(
args
)
...
...
app/graphql/resolvers/milestones_resolver.rb
View file @
1cd35327
...
...
@@ -25,7 +25,7 @@ module Resolvers
required:
false
,
description:
'A date that the milestone contains'
type
Types
::
MilestoneType
,
null:
true
type
Types
::
MilestoneType
.
connection_type
,
null:
true
def
resolve
(
**
args
)
validate_timeframe_params!
(
args
)
...
...
app/graphql/resolvers/project_milestones_resolver.rb
View file @
1cd35327
...
...
@@ -6,6 +6,8 @@ module Resolvers
required:
false
,
description:
"Also return milestones in the project's parent group and its ancestors"
type
Types
::
MilestoneType
.
connection_type
,
null:
true
private
def
parent_id_parameters
(
args
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment