Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
1eca1928
Commit
1eca1928
authored
Sep 02, 2019
by
Maneschi Romain
Committed by
Nick Thomas
Sep 02, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
quick action label must be first in issue comment
parent
146e12a0
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
23 additions
and
1 deletion
+23
-1
app/services/quick_actions/interpret_service.rb
app/services/quick_actions/interpret_service.rb
+1
-1
changelogs/unreleased/60561-quick-action-label-first-for-issue.yml
...s/unreleased/60561-quick-action-label-first-for-issue.yml
+5
-0
spec/features/issues/user_comments_on_issue_spec.rb
spec/features/issues/user_comments_on_issue_spec.rb
+17
-0
No files found.
app/services/quick_actions/interpret_service.rb
View file @
1eca1928
...
...
@@ -5,8 +5,8 @@ module QuickActions
include
Gitlab
::
Utils
::
StrongMemoize
include
Gitlab
::
QuickActions
::
Dsl
include
Gitlab
::
QuickActions
::
IssueActions
include
Gitlab
::
QuickActions
::
IssueAndMergeRequestActions
include
Gitlab
::
QuickActions
::
IssuableActions
include
Gitlab
::
QuickActions
::
IssueAndMergeRequestActions
include
Gitlab
::
QuickActions
::
MergeRequestActions
include
Gitlab
::
QuickActions
::
CommitActions
include
Gitlab
::
QuickActions
::
CommonActions
...
...
changelogs/unreleased/60561-quick-action-label-first-for-issue.yml
0 → 100644
View file @
1eca1928
---
title
:
Quick action label must be first in issue comment
merge_request
:
32367
author
:
Romain Maneschi
type
:
fixed
spec/features/issues/user_comments_on_issue_spec.rb
View file @
1eca1928
...
...
@@ -55,6 +55,23 @@ describe "User comments on issue", :js do
expect
(
page
.
find
(
'svg.mermaid'
)).
to
have_content
escaped_content
end
it
'opens autocomplete menu for quick actions and have `/label` first choice'
do
project
.
add_maintainer
(
user
)
create
(
:label
,
project:
project
,
title:
'label'
)
page
.
within
'.timeline-content-form'
do
find
(
'#note-body'
).
native
.
send_keys
(
'/l'
)
end
wait_for_requests
expect
(
page
).
to
have_selector
(
'.atwho-container'
)
page
.
within
'.atwho-container #at-view-commands'
do
expect
(
find
(
'li'
,
match: :first
)).
to
have_content
(
'/label'
)
end
end
end
context
"when editing comments"
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment