Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
1f810144
Commit
1f810144
authored
Aug 20, 2020
by
Dallas Reedy
Committed by
Simon Knox
Aug 20, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove banner & footer links from onboarding step
parent
8b384988
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
24 additions
and
4 deletions
+24
-4
app/controllers/registrations/experience_levels_controller.rb
...controllers/registrations/experience_levels_controller.rb
+1
-3
app/views/layouts/devise_experimental_onboarding_issues.html.haml
...s/layouts/devise_experimental_onboarding_issues.html.haml
+11
-0
spec/controllers/registrations/experience_levels_controller_spec.rb
...ollers/registrations/experience_levels_controller_spec.rb
+1
-0
spec/features/registrations/experience_level_spec.rb
spec/features/registrations/experience_level_spec.rb
+11
-1
No files found.
app/controllers/registrations/experience_levels_controller.rb
View file @
1f810144
...
@@ -2,9 +2,7 @@
...
@@ -2,9 +2,7 @@
module
Registrations
module
Registrations
class
ExperienceLevelsController
<
ApplicationController
class
ExperienceLevelsController
<
ApplicationController
# This will need to be changed to simply 'devise' as part of
layout
'devise_experimental_onboarding_issues'
# https://gitlab.com/gitlab-org/growth/engineering/issues/64
layout
'devise_experimental_separate_sign_up_flow'
before_action
:check_experiment_enabled
before_action
:check_experiment_enabled
before_action
:ensure_namespace_path_param
before_action
:ensure_namespace_path_param
...
...
app/views/layouts/devise_experimental_onboarding_issues.html.haml
0 → 100644
View file @
1f810144
!!! 5
%html
.devise-layout-html.navless
{
class:
system_message_class
}
=
render
"layouts/head"
%body
.ui-indigo.signup-page
{
class:
"#{client_class_list}"
,
data:
{
page:
body_data_page
,
qa_selector:
'signup_page'
}
}
=
render
"layouts/header/logo_with_title"
=
render
"layouts/init_client_detection_flags"
.page-wrap
.container.signup-box-container.navless-container
=
render
"layouts/broadcast"
.content
=
yield
spec/controllers/registrations/experience_levels_controller_spec.rb
View file @
1f810144
...
@@ -23,6 +23,7 @@ RSpec.describe Registrations::ExperienceLevelsController do
...
@@ -23,6 +23,7 @@ RSpec.describe Registrations::ExperienceLevelsController do
end
end
it
{
is_expected
.
to
have_gitlab_http_status
(
:ok
)
}
it
{
is_expected
.
to
have_gitlab_http_status
(
:ok
)
}
it
{
is_expected
.
to
render_template
(
'layouts/devise_experimental_onboarding_issues'
)
}
it
{
is_expected
.
to
render_template
(
:show
)
}
it
{
is_expected
.
to
render_template
(
:show
)
}
context
'when not part of the onboarding issues experiment'
do
context
'when not part of the onboarding issues experiment'
do
...
...
spec/features/registrations/experience_level_spec.rb
View file @
1f810144
...
@@ -3,7 +3,7 @@
...
@@ -3,7 +3,7 @@
require
'spec_helper'
require
'spec_helper'
RSpec
.
describe
'Experience level screen'
do
RSpec
.
describe
'Experience level screen'
do
let_it_be
(
:user
)
{
create
(
:user
)
}
let_it_be
(
:user
)
{
create
(
:user
,
:unconfirmed
)
}
let_it_be
(
:group
)
{
create
(
:group
)
}
let_it_be
(
:group
)
{
create
(
:group
)
}
before
do
before
do
...
@@ -32,4 +32,14 @@ RSpec.describe 'Experience level screen' do
...
@@ -32,4 +32,14 @@ RSpec.describe 'Experience level screen' do
is_expected
.
to
have_content
(
'I’m familiar with the basics of project management and DevOps'
)
is_expected
.
to
have_content
(
'I’m familiar with the basics of project management and DevOps'
)
is_expected
.
to
have_content
(
'Show me more advanced stuff'
)
is_expected
.
to
have_content
(
'Show me more advanced stuff'
)
end
end
it
'does not display any flash messages'
do
is_expected
.
not_to
have_selector
(
'.flash-container'
)
is_expected
.
not_to
have_content
(
"Please check your email (
#{
user
.
email
}
) to verify that you own this address and unlock the power of CI/CD"
)
end
it
'does not include the footer links'
do
is_expected
.
not_to
have_link
(
'Help'
)
is_expected
.
not_to
have_link
(
'About GitLab'
)
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment