Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
1fd871ba
Commit
1fd871ba
authored
Jul 19, 2021
by
Siddharth Asthana
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove old routing to ServicePingController
parent
416e0bd1
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
0 additions
and
16 deletions
+0
-16
config/routes/project.rb
config/routes/project.rb
+0
-6
spec/routing/project_routing_spec.rb
spec/routing/project_routing_spec.rb
+0
-10
No files found.
config/routes/project.rb
View file @
1fd871ba
...
...
@@ -547,12 +547,6 @@ constraints(::Constraints::ProjectUrlConstrainer.new) do
end
end
# TODO: Deprecated. This should be removed in 14.2.
scope
:usage_ping
,
controller: :service_ping
do
post
:web_ide_clientside_preview
# rubocop:todo Cop/PutProjectRoutesUnderScope
post
:web_ide_pipelines_count
# rubocop:todo Cop/PutProjectRoutesUnderScope
end
scope
:service_ping
,
controller: :service_ping
do
post
:web_ide_clientside_preview
# rubocop:todo Cop/PutProjectRoutesUnderScope
post
:web_ide_pipelines_count
# rubocop:todo Cop/PutProjectRoutesUnderScope
...
...
spec/routing/project_routing_spec.rb
View file @
1fd871ba
...
...
@@ -771,16 +771,6 @@ RSpec.describe 'project routing' do
end
describe
Projects
::
ServicePingController
,
'routing'
do
describe
'deprecated routing'
do
it
'routes to service_ping#web_ide_clientside_preview'
do
expect
(
post
(
'/gitlab/gitlabhq/usage_ping/web_ide_clientside_preview'
)).
to
route_to
(
'projects/service_ping#web_ide_clientside_preview'
,
namespace_id:
'gitlab'
,
project_id:
'gitlabhq'
)
end
it
'routes to service_ping#web_ide_pipelines_count'
do
expect
(
post
(
'/gitlab/gitlabhq/usage_ping/web_ide_pipelines_count'
)).
to
route_to
(
'projects/service_ping#web_ide_pipelines_count'
,
namespace_id:
'gitlab'
,
project_id:
'gitlabhq'
)
end
end
it
'routes to service_ping#web_ide_clientside_preview'
do
expect
(
post
(
'/gitlab/gitlabhq/service_ping/web_ide_clientside_preview'
)).
to
route_to
(
'projects/service_ping#web_ide_clientside_preview'
,
namespace_id:
'gitlab'
,
project_id:
'gitlabhq'
)
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment