Merge branch '241194-enable-vue_group_members_list-ff-by-default' into 'master'

Enable `vue_group_members_list` FF by default

See merge request gitlab-org/gitlab!47427

app/views/groups/group_members/index.html.haml

@@ -3,7 +3,7 @@
 - show_invited_members = can_manage_members && @invited_members.exists?
 - show_access_requests = can_manage_members && @requesters.exists?
 - invited_active = params[:search_invited].present? || params[:invited_members_page].present?
-- vue_members_list_enabled = Feature.enabled?(:vue_group_members_list, @group)
+- vue_members_list_enabled = Feature.enabled?(:vue_group_members_list, @group, default_enabled: true)
 - current_user_is_group_owner = @group && @group.has_owner?(current_user)
 
 - form_item_label_css_class = 'label-bold gl-mr-2 gl-mb-0 gl-py-2 align-self-md-center'

changelogs/unreleased/241194-enable-vue_group_members_list-ff-by-default.yml

+---
+title: Enable `vue_group_members_list` feature flag by default
+merge_request: 47427
+author:
+type: changed

config/feature_flags/development/vue_group_members_list.yml

@@ -5,4 +5,4 @@ rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/241194
 milestone: '13.4'
 type: development
 group: group::access
-default_enabled: false
+default_enabled: true

qa/qa/specs/features/ee/browser_ui/1_manage/group/group_audit_logs_1_spec.rb

@@ -87,8 +87,6 @@ module QA
 
       context 'Add user, change access level, remove user', :requires_admin, testcase: 'https://gitlab.com/gitlab-org/quality/testcases/-/issues/734' do
         before do
-          Runtime::Feature.enable('vue_group_members_list', group: group)
-
           sign_in
           group.visit!
           Page::Group::Menu.perform(&:click_group_members_item)
@@ -99,10 +97,6 @@ module QA
           end
         end
 
-        after do
-          Runtime::Feature.disable('vue_group_members_list', group: group)
-        end
-
         it_behaves_like 'audit event', ['Added user access as Guest', 'Changed access level', 'Removed user access']
       end
 

qa/qa/specs/features/ee/browser_ui/1_manage/group/share_group_with_group_spec.rb

@@ -32,11 +32,6 @@ module QA
 
       before do
         source_group_with_members.add_member(maintainer_user, Resource::Members::AccessLevel::MAINTAINER)
-        Runtime::Feature.enable('vue_group_members_list', group: target_group_with_project)
-      end
-
-      after do
-        Runtime::Feature.disable('vue_group_members_list', group: target_group_with_project)
       end
 
       it 'can be shared with another group with correct access level', :requires_admin, testcase: 'https://gitlab.com/gitlab-org/quality/testcases/-/issues/945' do