Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
21003484
Commit
21003484
authored
Jul 28, 2020
by
Scott Stern
Committed by
Kushal Pandya
Jul 28, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix spec for issuables in update_issues_spec
parent
576d29a4
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
12 additions
and
5 deletions
+12
-5
app/assets/javascripts/issuables_list/components/issuables_list_app.vue
...ascripts/issuables_list/components/issuables_list_app.vue
+7
-1
app/assets/javascripts/vue_shared/components/issue/issue_assignees.vue
...vascripts/vue_shared/components/issue/issue_assignees.vue
+1
-1
spec/features/issues/update_issues_spec.rb
spec/features/issues/update_issues_spec.rb
+4
-3
No files found.
app/assets/javascripts/issuables_list/components/issuables_list_app.vue
View file @
21003484
...
@@ -356,7 +356,13 @@ export default {
...
@@ -356,7 +356,13 @@ export default {
</ul>
</ul>
<div
v-else-if=
"issuables.length"
>
<div
v-else-if=
"issuables.length"
>
<div
v-if=
"isBulkEditing"
class=
"issue px-3 py-3 border-bottom border-light"
>
<div
v-if=
"isBulkEditing"
class=
"issue px-3 py-3 border-bottom border-light"
>
<input
type=
"checkbox"
:checked=
"allIssuablesSelected"
class=
"mr-2"
@
click=
"onSelectAll"
/>
<input
id=
"check-all-issues"
type=
"checkbox"
:checked=
"allIssuablesSelected"
class=
"mr-2"
@
click=
"onSelectAll"
/>
<strong>
{{
__
(
'
Select all
'
)
}}
</strong>
<strong>
{{
__
(
'
Select all
'
)
}}
</strong>
</div>
</div>
<ul
<ul
...
...
app/assets/javascripts/vue_shared/components/issue/issue_assignees.vue
View file @
21003484
...
@@ -86,7 +86,7 @@ export default {
...
@@ -86,7 +86,7 @@ export default {
:img-css-classes=
"imgCssClasses"
:img-css-classes=
"imgCssClasses"
:img-src=
"avatarUrl(assignee)"
:img-src=
"avatarUrl(assignee)"
:img-size=
"iconSize"
:img-size=
"iconSize"
class=
"js-no-trigger"
class=
"js-no-trigger
author-link
"
tooltip-placement=
"bottom"
tooltip-placement=
"bottom"
>
>
<span
class=
"js-assignee-tooltip"
>
<span
class=
"js-assignee-tooltip"
>
...
...
spec/features/issues/update_issues_spec.rb
View file @
21003484
...
@@ -8,7 +8,6 @@ RSpec.describe 'Multiple issue updating from issues#index', :js do
...
@@ -8,7 +8,6 @@ RSpec.describe 'Multiple issue updating from issues#index', :js do
let!
(
:user
)
{
create
(
:user
)}
let!
(
:user
)
{
create
(
:user
)}
before
do
before
do
stub_feature_flags
(
vue_issuables_list:
false
)
project
.
add_maintainer
(
user
)
project
.
add_maintainer
(
user
)
sign_in
(
user
)
sign_in
(
user
)
end
end
...
@@ -52,7 +51,7 @@ RSpec.describe 'Multiple issue updating from issues#index', :js do
...
@@ -52,7 +51,7 @@ RSpec.describe 'Multiple issue updating from issues#index', :js do
click_update_issues_button
click_update_issues_button
page
.
within
(
'.issue .controls'
)
do
page
.
within
(
'.issue .controls'
)
do
expect
(
find
(
'.author-link'
)[
"title"
]).
to
have_content
(
user
.
name
)
expect
(
find
(
'.author-link'
)[
'href'
]).
to
have_content
(
user
.
website_url
)
end
end
end
end
...
@@ -83,13 +82,15 @@ RSpec.describe 'Multiple issue updating from issues#index', :js do
...
@@ -83,13 +82,15 @@ RSpec.describe 'Multiple issue updating from issues#index', :js do
find
(
'.dropdown-menu-milestone a'
,
text:
milestone
.
title
).
click
find
(
'.dropdown-menu-milestone a'
,
text:
milestone
.
title
).
click
click_update_issues_button
click_update_issues_button
expect
(
find
(
'.issue'
)).
to
have_content
milestone
.
title
expect
(
page
.
find
(
'.issue'
)).
to
have_content
milestone
.
title
end
end
it
'sets to no milestone'
do
it
'sets to no milestone'
do
create_with_milestone
create_with_milestone
visit
project_issues_path
(
project
)
visit
project_issues_path
(
project
)
wait_for_requests
expect
(
first
(
'.issue'
)).
to
have_content
milestone
.
title
expect
(
first
(
'.issue'
)).
to
have_content
milestone
.
title
click_button
'Edit issues'
click_button
'Edit issues'
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment