Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
216565f3
Commit
216565f3
authored
Jan 05, 2021
by
Paul Gascou-Vaillancourt
Committed by
Stan Hu
Jan 11, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Enable site validation feature flag by default
parent
c1349ea2
Changes
10
Show whitespace changes
Inline
Side-by-side
Showing
10 changed files
with
14 additions
and
9 deletions
+14
-9
config/feature_flags/development/security_on_demand_scans_site_validation.yml
.../development/security_on_demand_scans_site_validation.yml
+1
-1
ee/app/controllers/projects/on_demand_scans_controller.rb
ee/app/controllers/projects/on_demand_scans_controller.rb
+1
-1
ee/app/controllers/projects/security/dast_profiles_controller.rb
...controllers/projects/security/dast_profiles_controller.rb
+1
-1
ee/app/graphql/mutations/dast_site_tokens/create.rb
ee/app/graphql/mutations/dast_site_tokens/create.rb
+1
-1
ee/app/graphql/mutations/dast_site_validations/create.rb
ee/app/graphql/mutations/dast_site_validations/create.rb
+1
-1
ee/app/graphql/resolvers/dast_site_validation_resolver.rb
ee/app/graphql/resolvers/dast_site_validation_resolver.rb
+1
-1
ee/app/services/dast_site_tokens/create_service.rb
ee/app/services/dast_site_tokens/create_service.rb
+1
-1
ee/app/services/dast_site_validations/create_service.rb
ee/app/services/dast_site_validations/create_service.rb
+1
-1
ee/app/services/dast_site_validations/validate_service.rb
ee/app/services/dast_site_validations/validate_service.rb
+1
-1
ee/changelogs/unreleased/241815-enable-site-validation-ff.yml
...hangelogs/unreleased/241815-enable-site-validation-ff.yml
+5
-0
No files found.
config/feature_flags/development/security_on_demand_scans_site_validation.yml
View file @
216565f3
...
...
@@ -5,4 +5,4 @@ rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/241815
milestone
:
'
13.4'
type
:
development
group
:
group::dynamic analysis
default_enabled
:
fals
e
default_enabled
:
tru
e
ee/app/controllers/projects/on_demand_scans_controller.rb
View file @
216565f3
...
...
@@ -3,7 +3,7 @@
module
Projects
class
OnDemandScansController
<
Projects
::
ApplicationController
before_action
do
push_frontend_feature_flag
(
:security_on_demand_scans_site_validation
,
@project
)
push_frontend_feature_flag
(
:security_on_demand_scans_site_validation
,
@project
,
default_enabled: :yaml
)
push_frontend_feature_flag
(
:security_dast_site_profiles_additional_fields
,
@project
,
default_enabled: :yaml
)
push_frontend_feature_flag
(
:dast_saved_scans
,
@project
,
default_enabled: :yaml
)
end
...
...
ee/app/controllers/projects/security/dast_profiles_controller.rb
View file @
216565f3
...
...
@@ -5,7 +5,7 @@ module Projects
class
DastProfilesController
<
Projects
::
ApplicationController
before_action
do
authorize_read_on_demand_scans!
push_frontend_feature_flag
(
:security_on_demand_scans_site_validation
,
@project
)
push_frontend_feature_flag
(
:security_on_demand_scans_site_validation
,
@project
,
default_enabled: :yaml
)
end
feature_category
:dynamic_application_security_testing
...
...
ee/app/graphql/mutations/dast_site_tokens/create.rb
View file @
216565f3
...
...
@@ -46,7 +46,7 @@ module Mutations
private
def
allowed?
(
project
)
Feature
.
enabled?
(
:security_on_demand_scans_site_validation
,
project
)
Feature
.
enabled?
(
:security_on_demand_scans_site_validation
,
project
,
default_enabled: :yaml
)
end
def
error_response
(
errors
)
...
...
ee/app/graphql/mutations/dast_site_validations/create.rb
View file @
216565f3
...
...
@@ -56,7 +56,7 @@ module Mutations
private
def
allowed?
(
project
)
Feature
.
enabled?
(
:security_on_demand_scans_site_validation
,
project
)
Feature
.
enabled?
(
:security_on_demand_scans_site_validation
,
project
,
default_enabled: :yaml
)
end
def
error_response
(
errors
)
...
...
ee/app/graphql/resolvers/dast_site_validation_resolver.rb
View file @
216565f3
...
...
@@ -18,7 +18,7 @@ module Resolvers
private
def
allowed?
::
Feature
.
enabled?
(
:security_on_demand_scans_site_validation
,
project
)
::
Feature
.
enabled?
(
:security_on_demand_scans_site_validation
,
project
,
default_enabled: :yaml
)
end
end
end
ee/app/services/dast_site_tokens/create_service.rb
View file @
216565f3
...
...
@@ -30,7 +30,7 @@ module DastSiteTokens
def
allowed?
container
.
feature_available?
(
:security_on_demand_scans
)
&&
Feature
.
enabled?
(
:security_on_demand_scans_site_validation
,
container
)
Feature
.
enabled?
(
:security_on_demand_scans_site_validation
,
container
,
default_enabled: :yaml
)
end
def
normalize_target_url
(
target_url
)
...
...
ee/app/services/dast_site_validations/create_service.rb
View file @
216565f3
...
...
@@ -23,7 +23,7 @@ module DastSiteValidations
def
allowed?
container
.
feature_available?
(
:security_on_demand_scans
)
&&
Feature
.
enabled?
(
:security_on_demand_scans_site_validation
,
container
)
&&
Feature
.
enabled?
(
:security_on_demand_scans_site_validation
,
container
,
default_enabled: :yaml
)
&&
dast_site_token
.
project
==
container
end
...
...
ee/app/services/dast_site_validations/validate_service.rb
View file @
216565f3
...
...
@@ -25,7 +25,7 @@ module DastSiteValidations
def
allowed?
container
.
feature_available?
(
:security_on_demand_scans
)
&&
Feature
.
enabled?
(
:security_on_demand_scans_site_validation
,
container
)
Feature
.
enabled?
(
:security_on_demand_scans_site_validation
,
container
,
default_enabled: :yaml
)
end
def
dast_site_validation
...
...
ee/changelogs/unreleased/241815-enable-site-validation-ff.yml
0 → 100644
View file @
216565f3
---
title
:
Add ability to validate DAST site profiles
merge_request
:
50847
author
:
type
:
added
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment