Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
2184c753
Commit
2184c753
authored
Jun 03, 2018
by
Shinya Maeda
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Revise comments in ArchiveLegacyTraces
parent
623accf9
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
3 deletions
+3
-3
lib/gitlab/background_migration/archive_legacy_traces.rb
lib/gitlab/background_migration/archive_legacy_traces.rb
+3
-3
No files found.
lib/gitlab/background_migration/archive_legacy_traces.rb
View file @
2184c753
...
@@ -6,10 +6,10 @@ module Gitlab
...
@@ -6,10 +6,10 @@ module Gitlab
module
BackgroundMigration
module
BackgroundMigration
class
ArchiveLegacyTraces
class
ArchiveLegacyTraces
def
perform
(
start_id
,
stop_id
)
def
perform
(
start_id
,
stop_id
)
# This background migration
s directly refer
::Ci::Build model which is defined in application code.
# This background migration
directly refers to
::Ci::Build model which is defined in application code.
# In general, migration code should be isolated as much as possible in order to be idempotent.
# In general, migration code should be isolated as much as possible in order to be idempotent.
# However, `archive!`
logic is too complicated to be replicated. So we chose a way to refer ::Ci::Build directly
# However, `archive!`
method is too complicated to be replicated by coping its subsequent code.
#
and we don't change the `archive!` logic
until 11.1
#
So we chose a way to use ::Ci::Build directly and we don't change the `archive!` method
until 11.1
::
Ci
::
Build
.
finished
.
without_archived_trace
::
Ci
::
Build
.
finished
.
without_archived_trace
.
where
(
id:
start_id
..
stop_id
).
find_each
do
|
build
|
.
where
(
id:
start_id
..
stop_id
).
find_each
do
|
build
|
begin
begin
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment