Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
21c88edc
Commit
21c88edc
authored
Sep 25, 2020
by
Michael Kozono
Committed by
Achilleas Pipinellis
Sep 25, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Geo docs: Add "Releasing the feature" section to Self-Service Framework
parent
8a084bf2
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
30 additions
and
4 deletions
+30
-4
doc/development/geo/framework.md
doc/development/geo/framework.md
+30
-4
No files found.
doc/development/geo/framework.md
View file @
21c88edc
...
...
@@ -91,8 +91,6 @@ module Geo
::
Packages
::
PackageFile
end
# Change this to `true` to release replication of this model. Then remove
# this override in the next release.
# The feature flag follows the format `geo_#{replicable_name}_replication`,
# so here it would be `geo_package_file_replication`
def
self
.
replication_enabled_by_default?
...
...
@@ -220,8 +218,6 @@ For example, to add support for files referenced by a `Widget` model with a
model_record
.
file
end
# Change this to `true` to release replication of this model. Then remove
# this override in the next release.
# The feature flag follows the format `geo_#{replicable_name}_replication`,
# so here it would be `geo_widget_replication`
def
self
.
replication_enabled_by_default?
...
...
@@ -693,3 +689,33 @@ To do: This should be done as part of
Widget sync and verification data (aggregate and individual) should now be
available in the Admin UI!
#### Releasing the feature
1.
In
`ee/app/replicators/geo/widget_replicator.rb`
, delete the
`self.replication_enabled_by_default?`
method:
```
ruby
module
Geo
class
WidgetReplicator
<
Gitlab
::
Geo
::
Replicator
...
# REMOVE THIS METHOD
def
self
.
replication_enabled_by_default?
false
end
# REMOVE THIS METHOD
...
end
end
```
1.
In
`ee/app/graphql/types/geo/geo_node_type.rb`
, remove the
`feature_flag`
option for the released type:
```
ruby
field
:widget_registries
,
::
Types
::
Geo
::
WidgetRegistryType
.
connection_type
,
null:
true
,
resolver:
::
Resolvers
::
Geo
::
WidgetRegistriesResolver
,
description:
'Find widget registries on this Geo node'
,
feature_flag: :geo_widget_replication
# REMOVE THIS LINE
```
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment