Move rspec command into rspec_helpers

.gitlab/ci/rails.gitlab-ci.yml

@@ -355,7 +355,7 @@ rspec foss-impact:
     - run_timed_command "scripts/gitaly-test-spawn"
     - source scripts/rspec_helpers.sh
     - tooling/bin/find_foss_tests tmp/matching_foss_tests.txt
-    - 'if [[ -n "$(cat tmp/matching_foss_tests.txt)" ]]; then rspec_simple_job "--tag ~quarantine --tag ~geo --tag ~level:migration $(cat tmp/matching_foss_tests.txt)"; fi'
+    - rspec_matched_tests tmp/matching_foss_tests.txt "--tag ~quarantine --tag ~geo --tag ~level:migration"
   artifacts:
     expire_in: 7d
     paths:

scripts/rspec_helpers.sh

@@ -110,3 +110,15 @@ function rspec_paralellized_job() {
 
   date
 }
+
+function rspec_matched_tests() {
+  local matching_tests_file=${1}
+  local rspec_opts=${2}
+  local test_files="$(cat "${matching_tests_file}")"
+
+  if [[ -n $test_files ]]; then
+    rspec_simple_job "${rspec_opts} ${test_files}"
+  else
+    echo "No test files to run"
+  fi
+}