Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
2416d3fd
Commit
2416d3fd
authored
Feb 08, 2021
by
Jonathan Schafer
Committed by
Alex Kalderimis
Feb 09, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix blank alert field with vuln issue
parent
9c266113
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
10 additions
and
1 deletion
+10
-1
ee/app/controllers/ee/projects/issues_controller.rb
ee/app/controllers/ee/projects/issues_controller.rb
+1
-1
ee/changelogs/unreleased/fix_blank_alert_from_vuln_issue.yml
ee/changelogs/unreleased/fix_blank_alert_from_vuln_issue.yml
+5
-0
ee/spec/controllers/projects/issues_controller_spec.rb
ee/spec/controllers/projects/issues_controller_spec.rb
+4
-0
No files found.
ee/app/controllers/ee/projects/issues_controller.rb
View file @
2416d3fd
...
@@ -62,7 +62,7 @@ module EE
...
@@ -62,7 +62,7 @@ module EE
errors
<<
render_vulnerability_link_alert
(
error
)
errors
<<
render_vulnerability_link_alert
(
error
)
end
end
flash
[
:alert
]
=
errors
.
join
(
'<br\>'
).
html_safe
flash
[
:alert
]
=
errors
.
join
(
'<br\>'
).
html_safe
unless
errors
.
blank?
end
end
def
vulnerability
def
vulnerability
...
...
ee/changelogs/unreleased/fix_blank_alert_from_vuln_issue.yml
0 → 100644
View file @
2416d3fd
---
title
:
Fix blank alert field when creating an issue from a vulnerability
merge_request
:
53656
author
:
type
:
fixed
ee/spec/controllers/projects/issues_controller_spec.rb
View file @
2416d3fd
...
@@ -127,6 +127,10 @@ RSpec.describe Projects::IssuesController do
...
@@ -127,6 +127,10 @@ RSpec.describe Projects::IssuesController do
expect
(
issue
.
confidential
).
to
be
false
expect
(
issue
.
confidential
).
to
be
false
end
end
it
'does not show an error message'
do
expect
(
flash
[
:alert
]).
to
be_nil
end
context
'when vulnerability already has a linked issue'
do
context
'when vulnerability already has a linked issue'
do
render_views
render_views
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment