Epic Boards - Update board scope

Review feedback

app/assets/javascripts/boards/components/config_toggle.vue

@@ -16,7 +16,7 @@ export default {
     boardsStore: {
       type: Object,
       required: false,
-      default: undefined,
+      default: null,
     },
     canAdminList: {
       type: Boolean,
@@ -27,11 +27,6 @@ export default {
       required: true,
     },
   },
-  data() {
-    return {
-      state: this.boardsStore ? this.boardsStore.state : {},
-    };
-  },
   computed: {
     buttonText() {
       return this.canAdminList ? s__('Boards|Edit board') : s__('Boards|View scope');
@@ -43,7 +38,9 @@ export default {
   methods: {
     showPage() {
       eventHub.$emit('showBoardModal', formType.edit);
-      return this.boardsStore ? this.boardsStore.showPage(formType.edit) : null;
+      if (this.boardsStore) {
+        this.boardsStore.showPage(formType.edit);
+      }
     },
   },
 };

app/assets/javascripts/boards/config_toggle.js

@@ -9,7 +9,8 @@ export default (boardsStore = undefined) => {
     return;
   }
 
-  gl.boardConfigToggle = new Vue({
+  // eslint-disable-next-line no-new
+  new Vue({
     el,
     render(h) {
       return h(ConfigToggle, {

ee/spec/features/epic_boards/epic_boards_spec.rb

@@ -118,12 +118,14 @@ RSpec.describe 'epic boards', :js do
 
       update_board_label(label_title)
 
+      aggregate_failures do
         expect(page).to have_selector('.board-card', count: 1)
         expect(page).to have_content('Epic1')
         expect(page).not_to have_content('Epic2')
         expect(page).not_to have_content('Epic3')
       end
     end
+  end
 
   context 'when user cannot admin epic boards' do
     before do
@@ -141,6 +143,7 @@ RSpec.describe 'epic boards', :js do
       view_scope.click
 
       page.within('.modal') do
+        aggregate_failures do
           expect(find('.modal-header')).to have_content('Board scope')
           expect(page).not_to have_content('Board name')
           expect(page).not_to have_link('Edit')
@@ -150,6 +153,7 @@ RSpec.describe 'epic boards', :js do
         end
       end
     end
+  end
 
   def visit_epic_boards_page
     visit group_epic_boards_path(group)

ee/spec/frontend/boards/stores/getters_spec.js

@@ -124,20 +124,19 @@ describe('EE Boards Store Getters', () => {
   });
 
   describe('isEpicBoard', () => {
-    it('returns true when issuableType on state is epic', () => {
+    it.each`
+      issuableType | expected
+      ${'epic'}    | ${true}
+      ${'issue'}   | ${false}
+    `(
+      'returns $expected when issuableType on state is $issuableType',
+      ({ issuableType, expected }) => {
         const state = {
-        issuableType: 'epic',
+          issuableType,
         };
 
-      expect(getters.isEpicBoard(state)).toBe(true);
-    });
-
-    it('returns false when issuableType on state is not epic', () => {
-      const state = {
-        issuableType: 'issue',
-      };
-
-      expect(getters.isEpicBoard(state)).toBe(false);
-    });
+        expect(getters.isEpicBoard(state)).toBe(expected);
+      },
+    );
   });
 });

spec/frontend/boards/stores/getters_spec.js

@@ -179,21 +179,20 @@ describe('Boards - Getters', () => {
   });
 
   describe('isIssueBoard', () => {
-    it('returns true when issuableType on state is issue', () => {
-      const state = {
-        issuableType: 'issue',
-      };
-
-      expect(getters.isIssueBoard(state)).toBe(true);
-    });
-
-    it('returns false when issuableType on state is not issue', () => {
+    it.each`
+      issuableType | expected
+      ${'issue'}   | ${true}
+      ${'epic'}    | ${false}
+    `(
+      'returns $expected when issuableType on state is $issuableType',
+      ({ issuableType, expected }) => {
         const state = {
-        issuableType: 'epic',
+          issuableType,
         };
 
-      expect(getters.isIssueBoard(state)).toBe(false);
-    });
+        expect(getters.isIssueBoard(state)).toBe(expected);
+      },
+    );
   });
 
   describe('isEpicBoard', () => {