Commit 28ab9662 authored by Chantal Rollison's avatar Chantal Rollison Committed by Rémy Coutable

Port of ccr/6274/add_weight_to_payload to CE

parent edf7d1d4
...@@ -28,7 +28,7 @@ module Gitlab ...@@ -28,7 +28,7 @@ module Gitlab
end end
def safe_keys def safe_keys
issuable_builder::SAFE_HOOK_ATTRIBUTES + issuable_builder::SAFE_HOOK_RELATIONS issuable_builder.safe_hook_attributes + issuable_builder::SAFE_HOOK_RELATIONS
end end
private private
......
module Gitlab module Gitlab
module HookData module HookData
class IssueBuilder < BaseBuilder class IssueBuilder < BaseBuilder
SAFE_HOOK_ATTRIBUTES = %i[ SAFE_HOOK_RELATIONS = %i[
assignees
labels
total_time_spent
].freeze
def self.safe_hook_attributes
%i[
assignee_id assignee_id
author_id author_id
closed_at closed_at
...@@ -23,12 +30,7 @@ module Gitlab ...@@ -23,12 +30,7 @@ module Gitlab
updated_at updated_at
updated_by_id updated_by_id
].freeze ].freeze
end
SAFE_HOOK_RELATIONS = %i[
assignees
labels
total_time_spent
].freeze
alias_method :issue, :object alias_method :issue, :object
...@@ -43,7 +45,7 @@ module Gitlab ...@@ -43,7 +45,7 @@ module Gitlab
assignee_id: issue.assignee_ids.first # This key is deprecated assignee_id: issue.assignee_ids.first # This key is deprecated
} }
issue.attributes.with_indifferent_access.slice(*SAFE_HOOK_ATTRIBUTES) issue.attributes.with_indifferent_access.slice(*self.class.safe_hook_attributes)
.merge!(attrs) .merge!(attrs)
end end
end end
......
module Gitlab module Gitlab
module HookData module HookData
class MergeRequestBuilder < BaseBuilder class MergeRequestBuilder < BaseBuilder
SAFE_HOOK_ATTRIBUTES = %i[ def self.safe_hook_attributes
%i[
assignee_id assignee_id
author_id author_id
created_at created_at
...@@ -28,6 +29,7 @@ module Gitlab ...@@ -28,6 +29,7 @@ module Gitlab
updated_at updated_at
updated_by_id updated_by_id
].freeze ].freeze
end
SAFE_HOOK_RELATIONS = %i[ SAFE_HOOK_RELATIONS = %i[
assignee assignee
...@@ -50,7 +52,7 @@ module Gitlab ...@@ -50,7 +52,7 @@ module Gitlab
human_time_estimate: merge_request.human_time_estimate human_time_estimate: merge_request.human_time_estimate
} }
merge_request.attributes.with_indifferent_access.slice(*SAFE_HOOK_ATTRIBUTES) merge_request.attributes.with_indifferent_access.slice(*self.class.safe_hook_attributes)
.merge!(attrs) .merge!(attrs)
end end
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment