Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
294d5f8e
Commit
294d5f8e
authored
Jul 08, 2020
by
Jaime Martinez
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Do not validate ref for release
parent
f42a3f1b
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
0 additions
and
19 deletions
+0
-19
lib/gitlab/ci/config/entry/release.rb
lib/gitlab/ci/config/entry/release.rb
+0
-7
spec/lib/gitlab/ci/config/entry/release_spec.rb
spec/lib/gitlab/ci/config/entry/release_spec.rb
+0
-12
No files found.
lib/gitlab/ci/config/entry/release.rb
View file @
294d5f8e
...
...
@@ -42,13 +42,6 @@ module Gitlab
errors
.
add
(
:released_at
,
"must be a valid datetime"
)
end
end
validate
do
next
unless
config
[
:ref
]
unless
Commit
.
reference_valid?
(
config
[
:ref
])
errors
.
add
(
:ref
,
"must be a valid ref"
)
end
end
end
def
value
...
...
spec/lib/gitlab/ci/config/entry/release_spec.rb
View file @
294d5f8e
...
...
@@ -192,12 +192,6 @@ RSpec.describe Gitlab::Ci::Config::Entry::Release do
it_behaves_like
'reports error'
,
'release released at must be a valid datetime'
end
context
'when `ref` is not valid'
do
let
(
:config
)
{
{
ref:
'ABC123'
}
}
it_behaves_like
'reports error'
,
'release ref must be a valid ref'
end
context
'when `milestones` is not an array of strings'
do
let
(
:config
)
{
{
milestones:
[
1
,
2
,
3
]
}
}
...
...
@@ -210,12 +204,6 @@ RSpec.describe Gitlab::Ci::Config::Entry::Release do
it_behaves_like
'reports error'
,
'release released at must be a valid datetime'
end
context
'when `ref` is not valid'
do
let
(
:config
)
{
{
ref:
'ABC123'
}
}
it_behaves_like
'reports error'
,
'release ref must be a valid ref'
end
context
'when `milestones` is not an array of strings'
do
let
(
:config
)
{
{
milestones:
[
1
,
2
,
3
]
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment