Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
2a12a250
Commit
2a12a250
authored
Nov 23, 2021
by
Luis Mejia
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove redis_hll_tracking validation from usage_data
parent
848f1fbd
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
23 deletions
+9
-23
lib/gitlab/usage_data.rb
lib/gitlab/usage_data.rb
+0
-2
spec/lib/gitlab/usage_data_spec.rb
spec/lib/gitlab/usage_data_spec.rb
+9
-21
No files found.
lib/gitlab/usage_data.rb
View file @
2a12a250
...
@@ -663,8 +663,6 @@ module Gitlab
...
@@ -663,8 +663,6 @@ module Gitlab
end
end
def
redis_hll_counters
def
redis_hll_counters
return
{}
unless
Feature
.
enabled?
(
:redis_hll_tracking
,
type: :ops
,
default_enabled: :yaml
)
{
redis_hll_counters:
::
Gitlab
::
UsageDataCounters
::
HLLRedisCounter
.
unique_events_data
}
{
redis_hll_counters:
::
Gitlab
::
UsageDataCounters
::
HLLRedisCounter
.
unique_events_data
}
end
end
...
...
spec/lib/gitlab/usage_data_spec.rb
View file @
2a12a250
...
@@ -1402,10 +1402,7 @@ RSpec.describe Gitlab::UsageData, :aggregate_failures do
...
@@ -1402,10 +1402,7 @@ RSpec.describe Gitlab::UsageData, :aggregate_failures do
let
(
:categories
)
{
::
Gitlab
::
UsageDataCounters
::
HLLRedisCounter
.
categories
}
let
(
:categories
)
{
::
Gitlab
::
UsageDataCounters
::
HLLRedisCounter
.
categories
}
context
'with redis_hll_tracking feature enabled'
do
it
'has all known_events'
do
it
'has all known_events'
do
stub_feature_flags
(
redis_hll_tracking:
true
)
expect
(
subject
).
to
have_key
(
:redis_hll_counters
)
expect
(
subject
).
to
have_key
(
:redis_hll_counters
)
expect
(
subject
[
:redis_hll_counters
].
keys
).
to
match_array
(
categories
)
expect
(
subject
[
:redis_hll_counters
].
keys
).
to
match_array
(
categories
)
...
@@ -1424,15 +1421,6 @@ RSpec.describe Gitlab::UsageData, :aggregate_failures do
...
@@ -1424,15 +1421,6 @@ RSpec.describe Gitlab::UsageData, :aggregate_failures do
end
end
end
end
context
'with redis_hll_tracking disabled'
do
it
'does not have redis_hll_tracking key'
do
stub_feature_flags
(
redis_hll_tracking:
false
)
expect
(
subject
).
not_to
have_key
(
:redis_hll_counters
)
end
end
end
describe
'.aggregated_metrics_data'
do
describe
'.aggregated_metrics_data'
do
it
'uses ::Gitlab::Usage::Metrics::Aggregates::Aggregate methods'
,
:aggregate_failures
do
it
'uses ::Gitlab::Usage::Metrics::Aggregates::Aggregate methods'
,
:aggregate_failures
do
expected_payload
=
{
expected_payload
=
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment