Commit 2f3df4cb authored by Doug Goldstein's avatar Doug Goldstein

HipChat service: correct service name & use v2 API

HipChat refers to their own product camel cased so we should do the
same. HipChat no longer recommends people use the deprecated v1 API so
switch to using the v2 API by default. hipchat-rb does not yet default
to v2 in any version so it must be specified.
parent 20cd7a50
...@@ -134,7 +134,7 @@ gem "redis-rails" ...@@ -134,7 +134,7 @@ gem "redis-rails"
gem 'tinder', '~> 1.9.2' gem 'tinder', '~> 1.9.2'
# HipChat integration # HipChat integration
gem "hipchat", "~> 0.14.0" gem "hipchat", "~> 1.4.0"
# Flowdock integration # Flowdock integration
gem "gitlab-flowdock-git-hook", "~> 0.4.2" gem "gitlab-flowdock-git-hook", "~> 0.4.2"
......
...@@ -235,8 +235,7 @@ GEM ...@@ -235,8 +235,7 @@ GEM
railties (>= 4.0.1) railties (>= 4.0.1)
hashie (2.1.2) hashie (2.1.2)
hike (1.2.3) hike (1.2.3)
hipchat (0.14.0) hipchat (1.4.0)
httparty
httparty httparty
html-pipeline (1.11.0) html-pipeline (1.11.0)
activesupport (>= 2) activesupport (>= 2)
...@@ -636,7 +635,7 @@ DEPENDENCIES ...@@ -636,7 +635,7 @@ DEPENDENCIES
guard-rspec guard-rspec
guard-spinach guard-spinach
haml-rails haml-rails
hipchat (~> 0.14.0) hipchat (~> 1.4.0)
html-pipeline-gitlab (~> 0.1.0) html-pipeline-gitlab (~> 0.1.0)
httparty httparty
jasmine (= 2.0.2) jasmine (= 2.0.2)
......
...@@ -19,7 +19,7 @@ class HipchatService < Service ...@@ -19,7 +19,7 @@ class HipchatService < Service
validates :token, presence: true, if: :activated? validates :token, presence: true, if: :activated?
def title def title
'Hipchat' 'HipChat'
end end
def description def description
...@@ -44,7 +44,8 @@ class HipchatService < Service ...@@ -44,7 +44,8 @@ class HipchatService < Service
private private
def gate def gate
@gate ||= HipChat::Client.new(token) options = { api_version: 'v2' }
@gate ||= HipChat::Client.new(token, options)
end end
def create_message(push) def create_message(push)
......
...@@ -10,7 +10,7 @@ class Spinach::Features::ProjectServices < Spinach::FeatureSteps ...@@ -10,7 +10,7 @@ class Spinach::Features::ProjectServices < Spinach::FeatureSteps
step 'I should see list of available services' do step 'I should see list of available services' do
page.should have_content 'Project services' page.should have_content 'Project services'
page.should have_content 'Campfire' page.should have_content 'Campfire'
page.should have_content 'Hipchat' page.should have_content 'HipChat'
page.should have_content 'GitLab CI' page.should have_content 'GitLab CI'
page.should have_content 'Assembla' page.should have_content 'Assembla'
page.should have_content 'Pushover' page.should have_content 'Pushover'
...@@ -33,7 +33,7 @@ class Spinach::Features::ProjectServices < Spinach::FeatureSteps ...@@ -33,7 +33,7 @@ class Spinach::Features::ProjectServices < Spinach::FeatureSteps
end end
step 'I click hipchat service link' do step 'I click hipchat service link' do
click_link 'Hipchat' click_link 'HipChat'
end end
step 'I fill hipchat settings' do step 'I fill hipchat settings' do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment