Commit 2f51491b authored by Peter Leitzen's avatar Peter Leitzen

Merge branch 'pl-rubocop-unused-todo' into 'master'

Remove unused TODOs from .rubocop_todo.yml

See merge request gitlab-org/gitlab!82305
parents 110bdd3b 6a23bab5
...@@ -15,11 +15,6 @@ Gitlab/PolicyRuleBoolean: ...@@ -15,11 +15,6 @@ Gitlab/PolicyRuleBoolean:
Exclude: Exclude:
- 'ee/app/policies/ee/identity_provider_policy.rb' - 'ee/app/policies/ee/identity_provider_policy.rb'
# Offense count: 5
Graphql/IDType:
Exclude:
- 'app/graphql/mutations/boards/issues/issue_move_list.rb'
# Offense count: 2270 # Offense count: 2270
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, IndentationWidth. # Configuration parameters: EnforcedStyle, IndentationWidth.
...@@ -112,11 +107,6 @@ Lint/BinaryOperatorWithIdenticalOperands: ...@@ -112,11 +107,6 @@ Lint/BinaryOperatorWithIdenticalOperands:
Lint/ConstantDefinitionInBlock: Lint/ConstantDefinitionInBlock:
Enabled: false Enabled: false
# Offense count: 1
Lint/DuplicateRequire:
Exclude:
- 'ee/spec/lib/gitlab/auth/group_saml/user_spec.rb'
# Offense count: 2 # Offense count: 2
# Configuration parameters: AllowComments. # Configuration parameters: AllowComments.
Lint/EmptyFile: Lint/EmptyFile:
...@@ -124,13 +114,6 @@ Lint/EmptyFile: ...@@ -124,13 +114,6 @@ Lint/EmptyFile:
- 'db/seeds.rb' - 'db/seeds.rb'
- 'ee/db/geo/seeds.rb' - 'ee/db/geo/seeds.rb'
# Offense count: 8
# Cop supports --auto-correct.
Lint/IdentityComparison:
Exclude:
- 'spec/tooling/danger/weightage/maintainers_spec.rb'
- 'spec/tooling/danger/weightage/reviewers_spec.rb'
# Offense count: 208 # Offense count: 208
# Configuration parameters: MaximumRangeSize. # Configuration parameters: MaximumRangeSize.
Lint/MissingCopEnableDirective: Lint/MissingCopEnableDirective:
...@@ -170,11 +153,6 @@ Lint/StructNewOverride: ...@@ -170,11 +153,6 @@ Lint/StructNewOverride:
- 'app/serializers/environment_serializer.rb' - 'app/serializers/environment_serializer.rb'
- 'lib/gitlab/ci/pipeline/duration.rb' - 'lib/gitlab/ci/pipeline/duration.rb'
# Offense count: 1
Lint/UnreachableLoop:
Exclude:
- 'qa/qa/runtime/feature.rb'
# Offense count: 22 # Offense count: 22
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: AllowComments. # Configuration parameters: AllowComments.
...@@ -213,13 +191,6 @@ Naming/HeredocDelimiterCase: ...@@ -213,13 +191,6 @@ Naming/HeredocDelimiterCase:
Naming/HeredocDelimiterNaming: Naming/HeredocDelimiterNaming:
Enabled: false Enabled: false
# Offense count: 5
# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
# AllowedNames: at, by, db, id, in, io, ip, of, on, os, pp, to
Naming/MethodParameterName:
Exclude:
- 'lib/gitlab/diff/inline_diff.rb'
# Offense count: 218 # Offense count: 218
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: PreferredName. # Configuration parameters: PreferredName.
...@@ -340,11 +311,6 @@ RSpec/ReturnFromStub: ...@@ -340,11 +311,6 @@ RSpec/ReturnFromStub:
RSpec/ScatteredLet: RSpec/ScatteredLet:
Enabled: false Enabled: false
# Offense count: 4
RSpec/ScatteredSetup:
Exclude:
- 'spec/requests/api/jobs_spec.rb'
# Offense count: 10 # Offense count: 10
# Configuration parameters: EnforcedStyle. # Configuration parameters: EnforcedStyle.
# SupportedStyles: symbols, strings # SupportedStyles: symbols, strings
...@@ -394,13 +360,6 @@ Rails/BelongsTo: ...@@ -394,13 +360,6 @@ Rails/BelongsTo:
- 'app/models/deployment.rb' - 'app/models/deployment.rb'
- 'app/models/environment.rb' - 'app/models/environment.rb'
# Offense count: 93
# Configuration parameters: Database, Include.
# SupportedDatabases: mysql, postgresql
# Include: db/migrate/*.rb
Rails/BulkChangeTable:
Enabled: false
# Offense count: 155 # Offense count: 155
# Cop supports --auto-correct. # Cop supports --auto-correct.
Rails/ContentTag: Rails/ContentTag:
...@@ -583,14 +542,6 @@ Style/CombinableLoops: ...@@ -583,14 +542,6 @@ Style/CombinableLoops:
- 'spec/requests/api/members_spec.rb' - 'spec/requests/api/members_spec.rb'
- 'spec/support/shared_examples/features/protected_branches_access_control_ce_shared_examples.rb' - 'spec/support/shared_examples/features/protected_branches_access_control_ce_shared_examples.rb'
# Offense count: 1
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions.
# SupportedStyles: assign_to_condition, assign_inside_condition
Style/ConditionalAssignment:
Exclude:
- 'lib/gitlab/database.rb'
# Offense count: 5 # Offense count: 5
# Cop supports --auto-correct. # Cop supports --auto-correct.
Style/EachWithObject: Style/EachWithObject:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment