Frontend review changes

app/assets/stylesheets/framework/forms.scss

@@ -68,8 +68,10 @@ label {
   }
 }
 
-.help-form {
-  .form-group {
+.help-form .form-group {
+  margin-left: 0;
+  margin-right: 0;
+
   .control-label {
     font-weight: bold;
     padding-top: 4px;
@@ -104,7 +106,6 @@ label {
       padding-left: 0;
     }
   }
-  }
 }
 
 .fieldset-form fieldset {

app/assets/stylesheets/pages/settings.scss

@@ -20,3 +20,7 @@
 .danger-title {
   color: $gl-danger;
 }
+
+.service-settings .control-label {
+  padding-top: 0;
+}

app/views/projects/services/mattermost_slash_commands/_help.html.haml

@@ -2,14 +2,14 @@
 - run_actions_text = "Perform common operations on this project: #{pretty_path_with_namespace}"
 
 .well
-  %p
   This service allows GitLab users to perform common operations on this
   project by entering slash commands in Mattermost.
-  %p
+  %br
   See list of available commands in Mattermost after setting up this service,
   by entering
   %code /<command_trigger_word> help
-  %p
+  %br
+  %br
   To setup this service:
   %ul.list-unstyled
     %li

app/views/shared/_service_settings.html.haml

@@ -7,12 +7,13 @@
     = preserve do
       = markdown @service.help
 
-.form-group
+.service-settings
+  .form-group
     = form.label :active, "Active", class: "control-label"
     .col-sm-10
       = form.check_box :active
 
-- if @service.supported_events.present?
+  - if @service.supported_events.present?
     .form-group
       = form.label :url, "Trigger", class: 'control-label'
 
@@ -34,7 +35,7 @@
           %p.light
             = service_event_description(event)
 
-- @service.global_fields.each do |field|
+  - @service.global_fields.each do |field|
     - type = field[:type]
 
     - if type == 'fieldset'