Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
33ba8d4e
Commit
33ba8d4e
authored
Jan 26, 2021
by
Furkan Ayhan
Committed by
Jose Ivan Vargas
Jan 26, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove FF new_pipeline_form_prefilled_vars
It was enabled by default
parent
779fbe05
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
14 additions
and
40 deletions
+14
-40
app/assets/javascripts/pipeline_new/components/pipeline_new_form.vue
...javascripts/pipeline_new/components/pipeline_new_form.vue
+0
-4
app/controllers/projects/pipelines_controller.rb
app/controllers/projects/pipelines_controller.rb
+0
-1
config/feature_flags/development/new_pipeline_form_prefilled_vars.yml
...re_flags/development/new_pipeline_form_prefilled_vars.yml
+0
-8
spec/frontend/pipeline_new/components/pipeline_new_form_spec.js
...rontend/pipeline_new/components/pipeline_new_form_spec.js
+14
-27
No files found.
app/assets/javascripts/pipeline_new/components/pipeline_new_form.vue
View file @
33ba8d4e
...
@@ -251,10 +251,6 @@ export default {
...
@@ -251,10 +251,6 @@ export default {
return
index
<
this
.
variables
.
length
-
1
;
return
index
<
this
.
variables
.
length
-
1
;
},
},
fetchConfigVariables
(
refValue
)
{
fetchConfigVariables
(
refValue
)
{
if
(
!
gon
?.
features
?.
newPipelineFormPrefilledVars
)
{
return
Promise
.
resolve
({
params
:
{},
descriptions
:
{}
});
}
this
.
isLoading
=
true
;
this
.
isLoading
=
true
;
return
backOff
((
next
,
stop
)
=>
{
return
backOff
((
next
,
stop
)
=>
{
...
...
app/controllers/projects/pipelines_controller.rb
View file @
33ba8d4e
...
@@ -17,7 +17,6 @@ class Projects::PipelinesController < Projects::ApplicationController
...
@@ -17,7 +17,6 @@ class Projects::PipelinesController < Projects::ApplicationController
push_frontend_feature_flag
(
:graphql_pipeline_header
,
project
,
type: :development
,
default_enabled:
false
)
push_frontend_feature_flag
(
:graphql_pipeline_header
,
project
,
type: :development
,
default_enabled:
false
)
push_frontend_feature_flag
(
:graphql_pipeline_details
,
project
,
type: :development
,
default_enabled: :yaml
)
push_frontend_feature_flag
(
:graphql_pipeline_details
,
project
,
type: :development
,
default_enabled: :yaml
)
push_frontend_feature_flag
(
:graphql_pipeline_details_users
,
current_user
,
type: :development
,
default_enabled: :yaml
)
push_frontend_feature_flag
(
:graphql_pipeline_details_users
,
current_user
,
type: :development
,
default_enabled: :yaml
)
push_frontend_feature_flag
(
:new_pipeline_form_prefilled_vars
,
project
,
type: :development
,
default_enabled:
true
)
end
end
before_action
:ensure_pipeline
,
only:
[
:show
]
before_action
:ensure_pipeline
,
only:
[
:show
]
before_action
:push_experiment_to_gon
,
only: :index
,
if: :html_request?
before_action
:push_experiment_to_gon
,
only: :index
,
if: :html_request?
...
...
config/feature_flags/development/new_pipeline_form_prefilled_vars.yml
deleted
100644 → 0
View file @
779fbe05
---
name
:
new_pipeline_form_prefilled_vars
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/44120
rollout_issue_url
:
https://gitlab.com/gitlab-org/gitlab/-/issues/263276
milestone
:
'
13.5'
type
:
development
group
:
group::continuous integration
default_enabled
:
true
spec/frontend/pipeline_new/components/pipeline_new_form_spec.js
View file @
33ba8d4e
...
@@ -225,23 +225,11 @@ describe('Pipeline New Form', () => {
...
@@ -225,23 +225,11 @@ describe('Pipeline New Form', () => {
});
});
});
});
describe
(
'
when feature flag new_pipeline_form_prefilled_vars is enabled
'
,
()
=>
{
describe
(
'
when yml defines a variable
'
,
()
=>
{
let
origGon
;
const
mockYmlKey
=
'
yml_var
'
;
const
mockYmlKey
=
'
yml_var
'
;
const
mockYmlValue
=
'
yml_var_val
'
;
const
mockYmlValue
=
'
yml_var_val
'
;
const
mockYmlDesc
=
'
A var from yml.
'
;
const
mockYmlDesc
=
'
A var from yml.
'
;
beforeAll
(()
=>
{
origGon
=
window
.
gon
;
window
.
gon
=
{
features
:
{
newPipelineFormPrefilledVars
:
true
}
};
});
afterAll
(()
=>
{
window
.
gon
=
origGon
;
});
describe
(
'
loading state
'
,
()
=>
{
it
(
'
loading icon is shown when content is requested and hidden when received
'
,
async
()
=>
{
it
(
'
loading icon is shown when content is requested and hidden when received
'
,
async
()
=>
{
createComponent
(
''
,
mockParams
,
mount
);
createComponent
(
''
,
mockParams
,
mount
);
...
@@ -258,9 +246,8 @@ describe('Pipeline New Form', () => {
...
@@ -258,9 +246,8 @@ describe('Pipeline New Form', () => {
expect
(
findLoadingIcon
().
exists
()).
toBe
(
false
);
expect
(
findLoadingIcon
().
exists
()).
toBe
(
false
);
});
});
});
describe
(
'
w
hen yml defines a variable w
ith description
'
,
()
=>
{
describe
(
'
with description
'
,
()
=>
{
beforeEach
(
async
()
=>
{
beforeEach
(
async
()
=>
{
createComponent
(
''
,
mockParams
,
mount
);
createComponent
(
''
,
mockParams
,
mount
);
...
@@ -302,7 +289,7 @@ describe('Pipeline New Form', () => {
...
@@ -302,7 +289,7 @@ describe('Pipeline New Form', () => {
});
});
});
});
describe
(
'
w
hen yml defines a variable w
ithout description
'
,
()
=>
{
describe
(
'
without description
'
,
()
=>
{
beforeEach
(
async
()
=>
{
beforeEach
(
async
()
=>
{
createComponent
(
''
,
mockParams
,
mount
);
createComponent
(
''
,
mockParams
,
mount
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment