fix misaligned projects dropdown

* dropdown position
* add empty state list overflow
* avoid double scrollbars in project dropdown
parent 4487d433
...@@ -221,7 +221,7 @@ export default { ...@@ -221,7 +221,7 @@ export default {
</script> </script>
<template> <template>
<div class="board-list-component"> <div class="board-list-component d-flex flex-column">
<div v-if="loading" class="board-list-loading text-center" aria-label="Loading issues"> <div v-if="loading" class="board-list-loading text-center" aria-label="Loading issues">
<gl-loading-icon /> <gl-loading-icon />
</div> </div>
......
...@@ -82,7 +82,7 @@ export default { ...@@ -82,7 +82,7 @@ export default {
<template> <template>
<div> <div>
<label class="label-bold prepend-top-10"> Project </label> <label class="label-bold prepend-top-10"> Project </label>
<div ref="projectsDropdown" class="dropdown"> <div ref="projectsDropdown" class="dropdown dropdown-projects">
<button <button
class="dropdown-menu-toggle wide" class="dropdown-menu-toggle wide"
type="button" type="button"
......
...@@ -27,6 +27,12 @@ ...@@ -27,6 +27,12 @@
pointer-events: none; pointer-events: none;
} }
.dropdown-projects {
.dropdown-content {
max-height: 200px;
}
}
.dropdown-menu-issues-board-new { .dropdown-menu-issues-board-new {
width: 320px; width: 320px;
...@@ -204,6 +210,7 @@ ...@@ -204,6 +210,7 @@
background: $gray-light; background: $gray-light;
border: 1px solid $border-color; border: 1px solid $border-color;
border-radius: $border-radius-default; border-radius: $border-radius-default;
flex: 1;
} }
.board-header { .board-header {
...@@ -266,9 +273,11 @@ ...@@ -266,9 +273,11 @@
.board-blank-state, .board-blank-state,
.board-promotion-state { .board-promotion-state {
height: calc(100% - 49px);
padding: $gl-padding; padding: $gl-padding;
background-color: $white-light; background-color: $white-light;
flex: 1;
overflow-y: auto;
overflow-x: hidden;
} }
.board-promotion-state { .board-promotion-state {
...@@ -297,9 +306,9 @@ ...@@ -297,9 +306,9 @@
} }
.board-list-component { .board-list-component {
height: calc(100% - 49px);
overflow: hidden;
position: relative; position: relative;
flex: 1;
min-height: 0; // firefox fix
} }
.board-list { .board-list {
......
.board{ ":class" => '{ "is-draggable": !list.preset, "is-expandable": list.isExpandable, "is-collapsed": !list.isExpanded, "board-type-assignee": list.type === "assignee" }', .board{ ":class" => '{ "is-draggable": !list.preset, "is-expandable": list.isExpandable, "is-collapsed": !list.isExpanded, "board-type-assignee": list.type === "assignee" }',
":data-id" => "list.id" } ":data-id" => "list.id" }
.board-inner .board-inner.d-flex.flex-column
%header.board-header{ ":class" => '{ "has-border": list.label && list.label.color }', ":style" => "{ borderTopColor: (list.label && list.label.color ? list.label.color : null) }", "@click" => "toggleExpanded($event)" } %header.board-header{ ":class" => '{ "has-border": list.label && list.label.color }', ":style" => "{ borderTopColor: (list.label && list.label.color ? list.label.color : null) }", "@click" => "toggleExpanded($event)" }
%h3.board-title.js-board-handle{ ":class" => '{ "user-can-drag": (!disabled && !list.preset) }' } %h3.board-title.js-board-handle{ ":class" => '{ "user-can-drag": (!disabled && !list.preset) }' }
%i.fa.fa-fw.board-title-expandable-toggle{ "v-if": "list.isExpandable", %i.fa.fa-fw.board-title-expandable-toggle{ "v-if": "list.isExpandable",
......
---
title: Proper align Projects dropdown on issue boards page
merge_request: 24277
author: Johann Hubert Sonntagbauer
type: fixed
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment