Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
35193d5c
Commit
35193d5c
authored
Dec 21, 2018
by
at.ramya
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Using find_elements instead of all_elements
parent
80ff142c
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
5 additions
and
5 deletions
+5
-5
qa/qa/page/base.rb
qa/qa/page/base.rb
+2
-2
qa/qa/page/project/issue/show.rb
qa/qa/page/project/issue/show.rb
+3
-3
No files found.
qa/qa/page/base.rb
View file @
35193d5c
...
@@ -80,8 +80,8 @@ module QA
...
@@ -80,8 +80,8 @@ module QA
page
.
evaluate_script
(
'xhr.status'
)
==
200
page
.
evaluate_script
(
'xhr.status'
)
==
200
end
end
def
find_element
(
name
,
wait:
Capybara
.
default_max_wait_time
)
def
find_element
(
name
,
text_filter
=
nil
,
wait:
Capybara
.
default_max_wait_time
)
find
(
element_selector_css
(
name
),
wait:
wait
)
find
(
element_selector_css
(
name
),
wait:
wait
,
text:
text_filter
)
end
end
def
all_elements
(
name
)
def
all_elements
(
name
)
...
...
qa/qa/page/project/issue/show.rb
View file @
35193d5c
...
@@ -37,17 +37,17 @@ module QA
...
@@ -37,17 +37,17 @@ module QA
def
select_comments_only_filter
def
select_comments_only_filter
click_element
:discussion_filter
click_element
:discussion_filter
all_elements
(
:filter_options
)[
1
]
.
click
find_element
(
:filter_options
,
"Show comments only"
)
.
click
end
end
def
select_history_only_filter
def
select_history_only_filter
click_element
:discussion_filter
click_element
:discussion_filter
all_elements
(
:filter_options
).
last
.
click
find_element
(
:filter_options
,
"Show history only"
)
.
click
end
end
def
select_all_activities_filter
def
select_all_activities_filter
click_element
:discussion_filter
click_element
:discussion_filter
all_elements
(
:filter_options
).
first
.
click
find_element
(
:filter_options
,
"Show all activity"
)
.
click
end
end
end
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment