Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
37d27b3b
Commit
37d27b3b
authored
May 29, 2019
by
Paul Gascou-Vaillancourt
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Hide action buttons in loading table rows
parent
30dc08b8
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
10 additions
and
0 deletions
+10
-0
ee/app/assets/javascripts/security_dashboard/components/security_dashboard_table_row.vue
...ity_dashboard/components/security_dashboard_table_row.vue
+1
-0
ee/changelogs/unreleased/loading-row-hide-actions.yml
ee/changelogs/unreleased/loading-row-hide-actions.yml
+5
-0
ee/spec/javascripts/security_dashboard/components/security_dashboard_table_row_spec.js
...dashboard/components/security_dashboard_table_row_spec.js
+4
-0
No files found.
ee/app/assets/javascripts/security_dashboard/components/security_dashboard_table_row.vue
View file @
37d27b3b
...
...
@@ -113,6 +113,7 @@ export default {
<div
class=
"table-mobile-header"
role=
"rowheader"
>
{{ s__('Reports|Actions') }}
</div>
<div
class=
"table-mobile-content action-buttons d-flex justify-content-end"
>
<vulnerability-action-buttons
v-if=
"!isLoading"
:vulnerability=
"vulnerability"
:can-create-issue=
"canCreateIssue"
:can-dismiss-vulnerability=
"canDismissVulnerability"
...
...
ee/changelogs/unreleased/loading-row-hide-actions.yml
0 → 100644
View file @
37d27b3b
---
title
:
Hide action buttons while security dashboard is loading
merge_request
:
13576
author
:
type
:
fixed
ee/spec/javascripts/security_dashboard/components/security_dashboard_table_row_spec.js
View file @
37d27b3b
...
...
@@ -33,6 +33,10 @@ describe('Security Dashboard Table Row', () => {
expect
(
vm
.
confidence
).
toEqual
(
'
–
'
);
expect
(
vm
.
$el
.
querySelectorAll
(
'
.table-mobile-content
'
)[
2
].
textContent
).
toContain
(
'
–
'
);
});
it
(
'
should not render action buttons
'
,
()
=>
{
expect
(
vm
.
$el
.
querySelectorAll
(
'
.action-buttons button
'
).
length
).
toBe
(
0
);
});
});
describe
(
'
when loaded
'
,
()
=>
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment