Skip to content

G
gitlab-ce
Commit 3ca2b825 authored by Grzegorz Bizon's avatar Grzegorz Bizon
Browse files
Options

Fix Rubocop configuration files

parent 127e299f
Hide whitespace changes
Inline Side-by-side
Showing with 108 additions and 420 deletions
.rubocop.yml
View file @ 3ca2b825
......@@ -343,10 +343,6 @@ Style/ParenthesesAroundCondition:
Style/RedundantParentheses:
Enabled: true
# Don't use return where it's not required.
Style/RedundantReturn:
Enabled: true
# Don't use semicolons to terminate expressions.
Style/Semicolon:
Enabled: true
......
.rubocop_todo.yml
View file @ 3ca2b825
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2017-01-06 20:23:01 -0800 using RuboCop version 0.46.0.
# `rubocop --auto-gen-config --exclude-limit 0`
# on 2017-01-11 09:34:02 +0000 using RuboCop version 0.46.0.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
......@@ -10,98 +10,69 @@
# Configuration parameters: Include.
# Include: **/Gemfile, **/gems.rb
Bundler/OrderedGems:
Exclude:
- 'Gemfile'
Enabled: false
# Offense count: 181
Lint/AmbiguousRegexpLiteral:
Enabled: false
# Offense count: 59
# Offense count: 60
# Configuration parameters: AllowSafeAssignment.
Lint/AssignmentInCondition:
Enabled: false
# Offense count: 1
Lint/EmptyWhen:
Exclude:
- 'lib/gitlab/diff/parser.rb'
Enabled: false
# Offense count: 21
# Offense count: 22
Lint/HandleExceptions:
Enabled: false
# Offense count: 2
Lint/Loop:
Exclude:
- 'app/mailers/notify.rb'
- 'lib/gitlab/path_locks_finder.rb'
Enabled: false
# Offense count: 25
# Offense count: 27
Lint/ShadowingOuterLocalVariable:
Enabled: false
# Offense count: 10
# Cop supports --auto-correct.
Lint/UnifiedInteger:
Exclude:
- 'spec/lib/gitlab/metrics/method_call_spec.rb'
- 'spec/lib/gitlab/metrics/metric_spec.rb'
- 'spec/lib/gitlab/metrics/system_spec.rb'
- 'spec/lib/gitlab/metrics/transaction_spec.rb'
- 'spec/models/repository_spec.rb'
Enabled: false
# Offense count: 16
# Offense count: 22
# Cop supports --auto-correct.
Lint/UnneededSplatExpansion:
Exclude:
- 'app/services/projects/update_pages_service.rb'
- 'config/application.rb'
- 'lib/banzai/filter/gollum_tags_filter.rb'
- 'lib/bitbucket/page.rb'
- 'lib/gitlab/markup_helper.rb'
- 'spec/helpers/auth_helper_spec.rb'
- 'spec/models/project_wiki_spec.rb'
- 'spec/requests/api/projects_spec.rb'
- 'spec/requests/api/tags_spec.rb'
- 'spec/support/test_env.rb'
# Offense count: 93
Enabled: false
# Offense count: 95
# Cop supports --auto-correct.
# Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
Lint/UnusedBlockArgument:
Enabled: false
# Offense count: 181
# Offense count: 186
# Cop supports --auto-correct.
# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
Lint/UnusedMethodArgument:
Enabled: false
# Offense count: 114
# Offense count: 112
# Configuration parameters: CountComments.
Metrics/BlockLength:
Max: 300
Max: 303
# Offense count: 4
# Cop supports --auto-correct.
Performance/RedundantBlockCall:
Exclude:
- 'app/controllers/application_controller.rb'
- 'app/services/projects/update_mirror_service.rb'
- 'lib/gitlab/backend/shell.rb'
- 'lib/gitlab/optimistic_locking.rb'
Enabled: false
# Offense count: 6
# Cop supports --auto-correct.
Performance/RedundantMatch:
Exclude:
- 'app/helpers/audit_events_helper.rb'
- 'app/models/external_issue.rb'
- 'lib/ci/api/helpers.rb'
- 'lib/extracts_path.rb'
- 'lib/gitlab/diff/highlight.rb'
- 'lib/gitlab/diff/parser.rb'
Enabled: false
# Offense count: 36
# Cop supports --auto-correct.
......@@ -111,30 +82,18 @@ Performance/RedundantMerge:
# Offense count: 10
RSpec/BeEql:
Exclude:
- 'spec/lib/gitlab/ldap/user_spec.rb'
- 'spec/lib/gitlab/o_auth/user_spec.rb'
- 'spec/lib/gitlab/saml/user_spec.rb'
- 'spec/workers/admin_emails_worker_spec.rb'
Enabled: false
# Offense count: 26
# Configuration parameters: CustomIncludeMethods.
RSpec/EmptyExampleGroup:
Exclude:
- 'spec/features/issues_spec.rb'
- 'spec/features/notes_on_merge_requests_spec.rb'
- 'spec/lib/gitlab/git_access_spec.rb'
- 'spec/models/project_snippet_spec.rb'
- 'spec/models/project_spec.rb'
- 'spec/models/protected_branch_spec.rb'
- 'spec/routing/routing_spec.rb'
Enabled: false
# Offense count: 24
RSpec/ExpectActual:
Exclude:
- 'spec/lib/gitlab/regex_spec.rb'
Enabled: false
# Offense count: 70
# Offense count: 83
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: implicit, each, example
RSpec/HookArgument:
......@@ -144,85 +103,46 @@ RSpec/HookArgument:
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: is_expected, should
RSpec/ImplicitExpect:
Exclude:
- 'spec/lib/banzai/renderer_spec.rb'
- 'spec/mailers/notify_spec.rb'
- 'spec/models/approval_spec.rb'
- 'spec/models/approver_group_spec.rb'
- 'spec/models/group_spec.rb'
- 'spec/models/project_group_link_spec.rb'
- 'spec/models/project_services/external_wiki_service_spec.rb'
- 'spec/models/project_spec.rb'
- 'spec/models/push_rule_spec.rb'
- 'spec/models/user_spec.rb'
# Offense count: 255
Enabled: false
# Offense count: 265
RSpec/LeadingSubject:
Enabled: false
# Offense count: 255
# Offense count: 261
RSpec/LetSetup:
Enabled: false
# Offense count: 19
RSpec/MessageChain:
Exclude:
- 'spec/finders/move_to_project_finder_spec.rb'
- 'spec/helpers/groups_helper_spec.rb'
- 'spec/helpers/issues_helper_spec.rb'
- 'spec/initializers/secret_token_spec.rb'
- 'spec/lib/banzai/filter/upload_link_filter_spec.rb'
- 'spec/models/build_spec.rb'
- 'spec/models/group_spec.rb'
- 'spec/models/project_spec.rb'
- 'spec/models/user_spec.rb'
- 'spec/requests/api/internal_spec.rb'
- 'spec/services/geo/enqueue_wiki_update_service_spec.rb'
- 'spec/services/merge_requests/build_service_spec.rb'
- 'spec/services/notes/create_service_spec.rb'
- 'spec/workers/emails_on_push_worker_spec.rb'
# Offense count: 513
Enabled: false
# Offense count: 518
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: have_received, receive
RSpec/MessageSpies:
Enabled: false
# Offense count: 3220
# Offense count: 3278
RSpec/MultipleExpectations:
Max: 37
# Offense count: 2214
# Offense count: 2287
RSpec/NamedSubject:
Enabled: false
# Offense count: 2001
# Offense count: 2111
# Configuration parameters: MaxNesting.
RSpec/NestedGroups:
Enabled: false
# Offense count: 36
RSpec/RepeatedDescription:
Exclude:
- 'spec/controllers/projects/todo_controller_spec.rb'
- 'spec/features/boards/boards_spec.rb'
- 'spec/helpers/issuables_helper_spec.rb'
- 'spec/lib/banzai/filter/emoji_filter_spec.rb'
- 'spec/models/commit_range_spec.rb'
- 'spec/models/global_milestone_spec.rb'
- 'spec/models/hooks/system_hook_spec.rb'
- 'spec/models/path_lock_spec.rb'
- 'spec/requests/api/commits_spec.rb'
- 'spec/requests/api/merge_requests_spec.rb'
- 'spec/requests/api/users_spec.rb'
- 'spec/requests/lfs_http_spec.rb'
- 'spec/routing/admin_routing_spec.rb'
- 'spec/services/notification_service_spec.rb'
Enabled: false
# Offense count: 1
RSpec/SingleArgumentMessageChain:
Exclude:
- 'spec/requests/api/internal_spec.rb'
Enabled: false
# Offense count: 137
RSpec/SubjectStub:
......@@ -235,7 +155,7 @@ RSpec/SubjectStub:
Rails/DynamicFindBy:
Enabled: false
# Offense count: 1003
# Offense count: 1010
# Cop supports --auto-correct.
# Configuration parameters: Include.
# Include: spec/**/*, test/**/*
......@@ -246,43 +166,26 @@ Rails/HttpPositionalArguments:
Rails/OutputSafety:
Enabled: false
# Offense count: 191
# Offense count: 203
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: strict, flexible
Rails/TimeZone:
Enabled: false
# Offense count: 15
# Offense count: 16
# Cop supports --auto-correct.
# Configuration parameters: Include.
# Include: app/models/**/*.rb
Rails/Validation:
Exclude:
- 'app/models/ci/build.rb'
- 'app/models/ci/pipeline.rb'
- 'app/models/ci/runner_project.rb'
- 'app/models/ci/trigger.rb'
- 'app/models/commit_status.rb'
- 'app/models/members/group_member.rb'
- 'app/models/members/project_member.rb'
- 'app/models/pages_domain.rb'
- 'app/models/project.rb'
- 'app/models/protected_branch.rb'
Enabled: false
# Offense count: 9
# Cop supports --auto-correct.
# Configuration parameters: AutoCorrect.
Security/JSONLoad:
Exclude:
- 'db/migrate/20161019190736_migrate_sidekiq_queues_from_default.rb'
- 'db/migrate/20161021185735_migrate_ee_sidekiq_queues_from_default.rb'
- 'db/migrate/20161024042317_migrate_mailroom_queue_from_default.rb'
- 'db/migrate/20161124141322_migrate_process_commit_worker_jobs.rb'
- 'spec/migrations/migrate_process_commit_worker_jobs_spec.rb'
- 'spec/models/project_services/irker_service_spec.rb'
- 'spec/support/stub_gitlab_calls.rb'
Enabled: false
# Offense count: 363
# Offense count: 365
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
# SupportedStyles: with_first_parameter, with_fixed_indentation
......@@ -303,7 +206,7 @@ Style/AndOr:
Style/BarePercentLiterals:
Enabled: false
# Offense count: 368
# Offense count: 387
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: braces, no_braces, context_dependent
......@@ -312,15 +215,9 @@ Style/BracesAroundHashParameters:
# Offense count: 6
Style/CaseEquality:
Exclude:
- 'app/helpers/auth_helper.rb'
- 'app/models/commit.rb'
- 'app/models/protected_branch.rb'
- 'app/services/projects/download_service.rb'
- 'config/initializers/trusted_proxies.rb'
- 'spec/features/calendar_spec.rb'
Enabled: false
# Offense count: 40
# Offense count: 41
# Cop supports --auto-correct.
Style/ColonMethodCall:
Enabled: false
......@@ -330,11 +227,7 @@ Style/ColonMethodCall:
# Configuration parameters: Keywords.
# Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW
Style/CommentAnnotation:
Exclude:
- 'config/routes/user.rb'
- 'lib/api/commits.rb'
- 'lib/api/entities.rb'
- 'spec/requests/api/project_snippets_spec.rb'
Enabled: false
# Offense count: 33
# Cop supports --auto-correct.
......@@ -343,67 +236,42 @@ Style/CommentAnnotation:
Style/ConditionalAssignment:
Enabled: false
# Offense count: 1258
# Offense count: 1279
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: leading, trailing
Style/DotPosition:
Enabled: false
# Offense count: 13
# Offense count: 19
Style/DoubleNegation:
Exclude:
- 'app/controllers/users_controller.rb'
- 'app/models/commit.rb'
- 'app/models/merge_request.rb'
- 'app/models/project.rb'
- 'app/models/project_services/buildkite_service.rb'
- 'app/models/project_services/drone_ci_service.rb'
- 'app/models/project_wiki.rb'
- 'app/models/push_rule.rb'
- 'app/models/user.rb'
- 'config/initializers/6_validations.rb'
- 'lib/banzai/filter/relative_link_filter.rb'
- 'lib/gitlab/sherlock.rb'
- 'lib/gitlab/sherlock/middleware.rb'
Enabled: false
# Offense count: 10
# Cop supports --auto-correct.
Style/EachWithObject:
Exclude:
- 'app/controllers/projects/cycle_analytics_controller.rb'
- 'app/models/concerns/elastic/application_search.rb'
- 'app/models/protected_branch.rb'
- 'app/services/merge_requests/get_urls_service.rb'
- 'lib/ci/ansi2html.rb'
- 'lib/expand_variables.rb'
- 'lib/gitlab/ee_compat_check.rb'
- 'lib/gitlab/import_export/members_mapper.rb'
- 'lib/gitlab/import_export/relation_factory.rb'
Enabled: false
# Offense count: 24
# Offense count: 25
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: empty, nil, both
Style/EmptyElse:
Enabled: false
# Offense count: 3
# Offense count: 4
# Cop supports --auto-correct.
Style/EmptyLiteral:
Exclude:
- 'features/steps/project/commits/commits.rb'
- 'lib/gitlab/fogbugz_import/importer.rb'
- 'spec/lib/gitlab/workhorse_spec.rb'
Enabled: false
# Offense count: 65
# Offense count: 64
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: compact, expanded
Style/EmptyMethod:
Enabled: false
# Offense count: 155
# Offense count: 159
# Cop supports --auto-correct.
# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
Style/ExtraSpacing:
......@@ -413,50 +281,31 @@ Style/ExtraSpacing:
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: format, sprintf, percent
Style/FormatString:
Exclude:
- 'app/models/ci/pipeline.rb'
- 'app/services/gravatar_service.rb'
- 'config/initializers/rack_lineprof.rb'
- 'lib/gitlab/version_info.rb'
- 'spec/factories/lfs_objects.rb'
- 'spec/services/issues/move_service_spec.rb'
# Offense count: 283
Enabled: false
# Offense count: 287
# Configuration parameters: MinBodyLength.
Style/GuardClause:
Enabled: false
# Offense count: 14
Style/IfInsideElse:
Exclude:
- 'app/controllers/projects/forks_controller.rb'
- 'app/controllers/projects/imports_controller.rb'
- 'app/helpers/milestones_helper.rb'
- 'app/helpers/projects_helper.rb'
- 'app/helpers/tree_helper.rb'
- 'app/services/system_note_service.rb'
- 'config/initializers/1_settings.rb'
- 'lib/gitlab/auth.rb'
- 'lib/gitlab/checks/change_access.rb'
- 'lib/gitlab/database.rb'
- 'lib/gitlab/elastic/project_search_results.rb'
- 'spec/controllers/projects/merge_requests_controller_spec.rb'
- 'spec/support/import_export/export_file_helper.rb'
# Offense count: 190
Enabled: false
# Offense count: 186
# Cop supports --auto-correct.
# Configuration parameters: MaxLineLength.
Style/IfUnlessModifier:
Enabled: false
# Offense count: 57
# Offense count: 61
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
# SupportedStyles: special_inside_parentheses, consistent, align_brackets
Style/IndentArray:
Enabled: false
# Offense count: 122
# Offense count: 128
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
# SupportedStyles: special_inside_parentheses, consistent, align_braces
......@@ -473,48 +322,23 @@ Style/Lambda:
# Offense count: 5
# Cop supports --auto-correct.
Style/LineEndConcatenation:
Exclude:
- 'app/helpers/preferences_helper.rb'
- 'app/helpers/tree_helper.rb'
- 'app/models/merge_request.rb'
- 'spec/lib/gitlab/gfm/reference_rewriter_spec.rb'
Enabled: false
# Offense count: 18
# Offense count: 19
# Cop supports --auto-correct.
Style/MethodCallParentheses:
Exclude:
- 'lib/ci/ansi2html.rb'
- 'spec/controllers/dashboard/todos_controller_spec.rb'
- 'spec/controllers/projects/issues_controller_spec.rb'
- 'spec/controllers/projects/merge_requests_controller_spec.rb'
- 'spec/controllers/projects/snippets_controller_spec.rb'
- 'spec/features/calendar_spec.rb'
- 'spec/features/dashboard/datetime_on_tooltips_spec.rb'
- 'spec/helpers/submodule_helper_spec.rb'
- 'spec/requests/api/internal_spec.rb'
Enabled: false
# Offense count: 9
Style/MethodMissing:
Exclude:
- 'app/controllers/projects/application_controller.rb'
- 'app/models/commit.rb'
- 'app/models/network/commit.rb'
- 'app/models/repository.rb'
- 'config/initializers/gollum.rb'
- 'lib/bitbucket/collection.rb'
- 'lib/gitlab/github_import/client.rb'
- 'lib/gitlab/lazy.rb'
- 'lib/uploaded_file.rb'
Enabled: false
# Offense count: 3
# Cop supports --auto-correct.
Style/MultilineIfModifier:
Exclude:
- 'app/helpers/snippets_helper.rb'
- 'app/models/merge_request.rb'
- 'app/models/project_wiki.rb'
Enabled: false
# Offense count: 161
# Offense count: 200
# Cop supports --auto-correct.
Style/MutableConstant:
Enabled: false
......@@ -522,51 +346,21 @@ Style/MutableConstant:
# Offense count: 9
# Cop supports --auto-correct.
Style/NestedParenthesizedCalls:
Exclude:
- 'app/helpers/commits_helper.rb'
- 'app/workers/irker_worker.rb'
- 'spec/factories/groups.rb'
- 'spec/lib/gitlab/ci/build/artifacts/metadata/entry_spec.rb'
- 'spec/lib/gitlab/email/message/repository_push_spec.rb'
Enabled: false
# Offense count: 16
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles.
# SupportedStyles: skip_modifier_ifs, always
Style/Next:
Exclude:
- 'app/models/namespace.rb'
- 'app/models/user.rb'
- 'app/services/merge_requests/refresh_service.rb'
- 'config/initializers/secret_token.rb'
- 'db/migrate/20161220141214_remove_dot_git_from_group_names.rb'
- 'db/migrate/20161226122833_remove_dot_git_from_usernames.rb'
- 'lib/banzai/filter/math_filter.rb'
- 'lib/banzai/filter/table_of_contents_filter.rb'
- 'lib/ee/gitlab/ldap/sync/group.rb'
- 'lib/gitlab/fogbugz_import/importer.rb'
- 'lib/gitlab/metrics/instrumentation.rb'
- 'lib/gitlab/metrics/sampler.rb'
- 'lib/gitlab/project_search_results.rb'
- 'lib/gitlab/sidekiq_cluster/cli.rb'
# Offense count: 15
Enabled: false
# Offense count: 19
# Cop supports --auto-correct.
# Configuration parameters: EnforcedOctalStyle, SupportedOctalStyles.
# SupportedOctalStyles: zero_with_o, zero_only
Style/NumericLiteralPrefix:
Exclude:
- 'config/initializers/1_settings.rb'
- 'config/initializers/secret_token.rb'
- 'lib/gitlab/backend/shell.rb'
- 'lib/gitlab/import_export/command_line_util.rb'
- 'lib/gitlab/workhorse.rb'
- 'spec/features/projects/import_export/export_file_spec.rb'
- 'spec/lib/gitlab/git/hook_spec.rb'
- 'spec/lib/gitlab/workhorse_spec.rb'
- 'spec/support/import_export/export_file_helper.rb'
- 'spec/support/test_env.rb'
- 'spec/tasks/gitlab/backup_rake_spec.rb'
Enabled: false
# Offense count: 24
# Cop supports --auto-correct.
......@@ -575,12 +369,12 @@ Style/NumericLiteralPrefix:
Style/NumericPredicate:
Enabled: false
# Offense count: 31
# Offense count: 35
# Cop supports --auto-correct.
Style/ParallelAssignment:
Enabled: false
# Offense count: 423
# Offense count: 427
# Cop supports --auto-correct.
# Configuration parameters: PreferredDelimiters.
Style/PercentLiteralDelimiters:
......@@ -591,31 +385,14 @@ Style/PercentLiteralDelimiters:
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: lower_case_q, upper_case_q
Style/PercentQLiterals:
Exclude:
- 'spec/lib/gitlab/diff/highlight_spec.rb'
- 'spec/models/project_services/bamboo_service_spec.rb'
- 'spec/models/project_services/teamcity_service_spec.rb'
- 'spec/workers/repository_import_worker_spec.rb'
Enabled: false
# Offense count: 17
# Cop supports --auto-correct.
Style/PerlBackrefs:
Exclude:
- 'app/controllers/projects/application_controller.rb'
- 'app/helpers/submodule_helper.rb'
- 'app/models/concerns/elastic/issues_search.rb'
- 'app/models/concerns/elastic/merge_requests_search.rb'
- 'app/workers/admin_emails_worker.rb'
- 'lib/banzai/filter/abstract_reference_filter.rb'
- 'lib/banzai/filter/autolink_filter.rb'
- 'lib/banzai/filter/emoji_filter.rb'
- 'lib/banzai/filter/gollum_tags_filter.rb'
- 'lib/expand_variables.rb'
- 'lib/gitlab/diff/highlight.rb'
- 'lib/gitlab/search_results.rb'
- 'lib/gitlab/sherlock/query.rb'
# Offense count: 66
Enabled: false
# Offense count: 69
# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
# NamePrefix: is_, has_, have_
# NamePrefixBlacklist: is_, has_, have_
......@@ -633,73 +410,42 @@ Style/PreferredHashMethods:
# Offense count: 8
# Cop supports --auto-correct.
Style/Proc:
Exclude:
- 'app/mailers/base_mailer.rb'
- 'app/models/milestone.rb'
- 'app/models/service.rb'
- 'lib/api/api_guard.rb'
- 'lib/gitlab/ldap/config.rb'
- 'spec/initializers/trusted_proxies_spec.rb'
Enabled: false
# Offense count: 39
# Offense count: 52
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: compact, exploded
Style/RaiseArgs:
Enabled: false
# Offense count: 5
# Offense count: 6
# Cop supports --auto-correct.
Style/RedundantBegin:
Exclude:
- 'app/models/ci/build.rb'
- 'app/models/merge_request.rb'
- 'app/services/projects/import_service.rb'
- 'app/workers/repository_update_mirror_worker.rb'
- 'app/workers/repository_update_remote_mirror_worker.rb'
Enabled: false
# Offense count: 1
# Cop supports --auto-correct.
Style/RedundantException:
Exclude:
- 'app/helpers/preferences_helper.rb'
Enabled: false
# Offense count: 29
# Cop supports --auto-correct.
Style/RedundantFreeze:
Exclude:
- 'app/models/merge_request.rb'
- 'app/validators/color_validator.rb'
- 'app/validators/line_code_validator.rb'
- 'lib/api/templates.rb'
- 'lib/banzai/filter/blockquote_fence_filter.rb'
- 'lib/banzai/filter/gollum_tags_filter.rb'
- 'lib/banzai/filter/yaml_front_matter_filter.rb'
- 'lib/gitlab/diff/inline_diff.rb'
- 'lib/gitlab/ee_compat_check.rb'
- 'lib/gitlab/import_export/relation_factory.rb'
- 'lib/gitlab/incoming_email.rb'
- 'lib/gitlab/middleware/static.rb'
- 'lib/gitlab/regex.rb'
Enabled: false
# Offense count: 11
# Cop supports --auto-correct.
# Configuration parameters: AllowMultipleReturnValues.
Style/RedundantReturn:
Exclude:
- 'app/controllers/concerns/issuable_actions.rb'
- 'app/controllers/groups/application_controller.rb'
- 'app/controllers/groups_controller.rb'
- 'app/controllers/projects/labels_controller.rb'
- 'app/controllers/projects/milestones_controller.rb'
- 'app/services/access_token_validation_service.rb'
Enabled: false
# Offense count: 458
# Offense count: 462
# Cop supports --auto-correct.
Style/RedundantSelf:
Enabled: false
# Offense count: 103
# Offense count: 109
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes.
# SupportedStyles: slashes, percent_r, mixed
......@@ -714,30 +460,21 @@ Style/RescueModifier:
# Offense count: 8
# Cop supports --auto-correct.
Style/SelfAssignment:
Exclude:
- 'app/models/project_team.rb'
- 'app/services/notification_service.rb'
- 'app/workers/concerns/geo_dynamic_backoff.rb'
- 'lib/api/runners.rb'
- 'spec/features/merge_requests/diff_notes_resolve_spec.rb'
- 'spec/support/import_export/configuration_helper.rb'
Enabled: false
# Offense count: 2
# Configuration parameters: Methods.
# Methods: {"reduce"=>["acc", "elem"]}, {"inject"=>["acc", "elem"]}
Style/SingleLineBlockParams:
Exclude:
- 'app/models/commit.rb'
- 'spec/support/services_shared_context.rb'
Enabled: false
# Offense count: 50
# Cop supports --auto-correct.
# Configuration parameters: AllowIfMethodIsEmpty.
Style/SingleLineMethods:
Exclude:
- 'lib/ci/ansi2html.rb'
Enabled: false
# Offense count: 158
# Offense count: 166
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: space, no_space
......@@ -748,13 +485,7 @@ Style/SpaceBeforeBlockBraces:
# Cop supports --auto-correct.
# Configuration parameters: AllowForAlignment.
Style/SpaceBeforeFirstArg:
Exclude:
- 'config/routes/project.rb'
- 'features/steps/project/source/browse_files.rb'
- 'features/steps/project/source/markdown_render.rb'
- 'spec/models/service_spec.rb'
- 'spec/routing/project_routing_spec.rb'
- 'spec/services/system_note_service_spec.rb'
Enabled: false
# Offense count: 44
# Cop supports --auto-correct.
......@@ -763,19 +494,19 @@ Style/SpaceBeforeFirstArg:
Style/SpaceInLambdaLiteral:
Enabled: false
# Offense count: 168
# Offense count: 180
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
# SupportedStyles: space, no_space
Style/SpaceInsideBlockBraces:
Enabled: false
# Offense count: 116
# Offense count: 118
# Cop supports --auto-correct.
Style/SpaceInsideBrackets:
Enabled: false
# Offense count: 87
# Offense count: 86
# Cop supports --auto-correct.
Style/SpaceInsideParens:
Enabled: false
......@@ -783,10 +514,9 @@ Style/SpaceInsideParens:
# Offense count: 6
# Cop supports --auto-correct.
Style/SpaceInsidePercentLiteralDelimiters:
Exclude:
- 'lib/gitlab/git_access.rb'
Enabled: false
# Offense count: 51
# Offense count: 53
# Cop supports --auto-correct.
# Configuration parameters: SupportedStyles.
# SupportedStyles: use_perl_names, use_english_names
......@@ -800,7 +530,7 @@ Style/SpecialGlobalVars:
Style/StringLiteralsInInterpolation:
Enabled: false
# Offense count: 40
# Offense count: 56
# Cop supports --auto-correct.
# Configuration parameters: IgnoredMethods.
# IgnoredMethods: respond_to, define_method
......@@ -812,40 +542,29 @@ Style/SymbolProc:
# Configuration parameters: EnforcedStyle, SupportedStyles, AllowSafeAssignment.
# SupportedStyles: require_parentheses, require_no_parentheses, require_parentheses_when_complex
Style/TernaryParentheses:
Exclude:
- 'app/models/project_services/hipchat_service.rb'
- 'features/support/capybara.rb'
- 'lib/api/projects.rb'
- 'lib/banzai/filter/table_of_contents_filter.rb'
- 'lib/gitlab/ci/build/artifacts/metadata/entry.rb'
- 'spec/support/capybara.rb'
Enabled: false
# Offense count: 34
# Offense count: 36
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
# SupportedStyles: comma, consistent_comma, no_comma
Style/TrailingCommaInArguments:
Enabled: false
# Offense count: 153
# Offense count: 166
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
# SupportedStyles: comma, consistent_comma, no_comma
Style/TrailingCommaInLiteral:
Enabled: false
# Offense count: 6
# Offense count: 7
# Cop supports --auto-correct.
# Configuration parameters: AllowNamedUnderscoreVariables.
Style/TrailingUnderscoreVariable:
Exclude:
- 'app/controllers/admin/background_jobs_controller.rb'
- 'app/controllers/invites_controller.rb'
- 'app/controllers/projects/git_http_client_controller.rb'
- 'app/helpers/tab_helper.rb'
- 'lib/gitlab/logger.rb'
Enabled: false
# Offense count: 87
# Offense count: 86
# Cop supports --auto-correct.
Style/TrailingWhitespace:
Enabled: false
......@@ -855,46 +574,19 @@ Style/TrailingWhitespace:
# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
# Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
Style/TrivialAccessors:
Exclude:
- 'app/models/external_issue.rb'
- 'app/serializers/base_serializer.rb'
- 'lib/ee/gitlab/ldap/group.rb'
- 'lib/gitlab/ldap/person.rb'
Enabled: false
# Offense count: 2
# Cop supports --auto-correct.
Style/UnlessElse:
Exclude:
- 'lib/gitlab/project_search_results.rb'
- 'spec/features/issues/award_emoji_spec.rb'
Enabled: false
# Offense count: 17
# Cop supports --auto-correct.
Style/UnneededInterpolation:
Exclude:
- 'app/helpers/boards_helper.rb'
- 'app/helpers/projects_helper.rb'
- 'app/helpers/search_helper.rb'
- 'app/helpers/time_helper.rb'
- 'app/models/merge_request.rb'
- 'app/models/project_services/pushover_service.rb'
- 'features/steps/project/forked_merge_requests.rb'
- 'spec/features/admin/admin_projects_spec.rb'
- 'spec/features/issues_spec.rb'
- 'spec/features/projects/branches_spec.rb'
- 'spec/features/projects/issuable_templates_spec.rb'
- 'spec/lib/banzai/filter/issue_reference_filter_spec.rb'
- 'spec/views/projects/commit/_commit_box.html.haml_spec.rb'
Enabled: false
# Offense count: 9
# Cop supports --auto-correct.
Style/ZeroLengthPredicate:
Exclude:
- 'app/models/deploy_key.rb'
- 'app/models/geo_node_key.rb'
- 'app/models/merge_request.rb'
- 'app/models/network/commit.rb'
- 'app/models/network/graph.rb'
- 'app/models/project_services/asana_service.rb'
- 'app/models/repository.rb'
- 'lib/extracts_path.rb'
Enabled: false
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7