Commit 3d59c8a7 authored by Mike Greiling's avatar Mike Greiling

Merge branch 'ps-mr-checkboxes-reduce-style-coupling' into 'master'

Refactor MR widget merge checkboxes to more flex

See merge request gitlab-org/gitlab!55951
parents bacc60c6 b1ce7c40
...@@ -455,8 +455,8 @@ export default { ...@@ -455,8 +455,8 @@ export default {
<div class="mr-widget-body media" :class="{ 'gl-pb-3': shouldRenderMergeTrainHelperText }"> <div class="mr-widget-body media" :class="{ 'gl-pb-3': shouldRenderMergeTrainHelperText }">
<status-icon :status="iconClass" /> <status-icon :status="iconClass" />
<div class="media-body"> <div class="media-body">
<div class="mr-widget-body-controls media space-children"> <div class="mr-widget-body-controls gl-display-flex gl-align-items-center">
<gl-button-group> <gl-button-group class="gl-align-self-start">
<gl-button <gl-button
size="medium" size="medium"
category="primary" category="primary"
...@@ -495,14 +495,16 @@ export default { ...@@ -495,14 +495,16 @@ export default {
/> />
</gl-dropdown> </gl-dropdown>
</gl-button-group> </gl-button-group>
<div class="media-body-wrap space-children"> <div
<template v-if="shouldShowMergeControls"> v-if="shouldShowMergeControls"
class="gl-display-flex gl-align-items-center gl-flex-wrap"
>
<gl-form-checkbox <gl-form-checkbox
v-if="canRemoveSourceBranch" v-if="canRemoveSourceBranch"
id="remove-source-branch-input" id="remove-source-branch-input"
v-model="removeSourceBranch" v-model="removeSourceBranch"
:disabled="isRemoveSourceBranchButtonDisabled" :disabled="isRemoveSourceBranchButtonDisabled"
class="js-remove-source-branch-checkbox gl-min-h-7 gl-display-flex gl-align-items-center gl-mr-2" class="js-remove-source-branch-checkbox gl-mx-3 gl-display-flex gl-align-items-center"
> >
{{ __('Delete source branch') }} {{ __('Delete source branch') }}
</gl-form-checkbox> </gl-form-checkbox>
...@@ -513,10 +515,11 @@ export default { ...@@ -513,10 +515,11 @@ export default {
v-model="squashBeforeMerge" v-model="squashBeforeMerge"
:help-path="mr.squashBeforeMergeHelpPath" :help-path="mr.squashBeforeMergeHelpPath"
:is-disabled="isSquashReadOnly" :is-disabled="isSquashReadOnly"
class="gl-mx-3"
/> />
</template> </div>
<template v-else> <template v-else>
<div class="bold js-resolve-mr-widget-items-message"> <div class="bold js-resolve-mr-widget-items-message gl-ml-3">
<div <div
v-if="hasPipelineMustSucceedConflict" v-if="hasPipelineMustSucceedConflict"
class="gl-display-flex gl-align-items-center" class="gl-display-flex gl-align-items-center"
...@@ -535,7 +538,6 @@ export default { ...@@ -535,7 +538,6 @@ export default {
</div> </div>
</template> </template>
</div> </div>
</div>
<div v-if="isSHAMismatch" class="d-flex align-items-center mt-2 js-sha-mismatch"> <div v-if="isSHAMismatch" class="d-flex align-items-center mt-2 js-sha-mismatch">
<gl-icon name="warning-solid" class="text-warning mr-1" /> <gl-icon name="warning-solid" class="text-warning mr-1" />
<span class="text-warning"> <span class="text-warning">
......
...@@ -44,7 +44,7 @@ export default { ...@@ -44,7 +44,7 @@ export default {
:checked="value" :checked="value"
:disabled="isDisabled" :disabled="isDisabled"
name="squash" name="squash"
class="qa-squash-checkbox js-squash-checkbox gl-min-h-7 gl-display-flex gl-align-items-center gl-mr-2" class="qa-squash-checkbox js-squash-checkbox gl-mr-2 gl-display-flex gl-align-items-center"
:title="tooltipTitle" :title="tooltipTitle"
@change="(checked) => $emit('input', checked)" @change="(checked) => $emit('input', checked)"
> >
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment