Merge branch 'add-breaking-change-vals-to-removals' into 'master'

Add breaking change values to removals

See merge request gitlab-org/gitlab!78943

data/deprecations/templates/example.yml

@@ -16,6 +16,7 @@
   removal_milestone: "XX.YY" # The milestone when this feature is planned to be removed
   removal_date: # The date of the milestone release when this feature was first announced as deprecated. This should almost always be the 22nd of a month (YYYY-MM-22), unless you did an out of band blog post.
   breaking_change: false # If this deprecation is a breaking change, set this value to true
+  reporter: exampleuser # GitLab username of the person reporting the deprecation
   body: | # Do not modify this line, instead modify the lines below.
     <!-- START OF BODY COMMENT
 

data/removals/14_0/14_0-ds-deprecations.yml

@@ -2,6 +2,7 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: nicoleschwartz
+  breaking_change: true
   body: |
     As mentioned in [13.9](https://about.gitlab.com/releases/2021/02/22/gitlab-13-9-released/#deprecations-for-dependency-scanning) and [this blog post](https://about.gitlab.com/blog/2021/02/08/composition-analysis-14-deprecations-and-removals/) several removals for Dependency Scanning take effect.
 

data/removals/14_0/14_0-lc-deprecations.yml

@@ -2,5 +2,6 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: nicoleschwartz
+  breaking_change: true
   body: |
     In 13.0, we deprecated the License-Management CI template and renamed it License-Scanning. We have been providing backward compatibility by warning users of the old template to switch. Now in 14.0, we are completely removing the License-Management CI template. Read about it in [issue #216261](https://gitlab.com/gitlab-org/gitlab/-/issues/216261) or [this blog post](https://about.gitlab.com/blog/2021/02/08/composition-analysis-14-deprecations-and-removals/).

data/removals/14_0/change_default_branch_name_to_main.yml

@@ -2,6 +2,7 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: sarahwaldner
+  breaking_change: true
   body: |
     Every Git repository has an initial branch, which is named `master` by default. It's the first branch to be created automatically when you create a new repository. Future [Git versions](https://lore.kernel.org/git/pull.656.v4.git.1593009996.gitgitgadget@gmail.com/) will change the default branch name in Git from `master` to `main`. In coordination with the Git project and the broader community, [GitLab has changed the default branch name](https://gitlab.com/gitlab-org/gitlab/-/issues/223789) for new projects on both our SaaS (GitLab.com) and self-managed offerings starting with GitLab 14.0. This will not affect existing projects.
 

data/removals/14_0/create-code-review-draft-wip.yml

@@ -2,5 +2,6 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: phikai
+  breaking_change: true
   body: |
     The WIP (work in progress) status for merge requests signaled to reviewers that the merge request in question wasn't ready to merge. We've renamed the WIP feature to **Draft**, a more inclusive and self-explanatory term. **Draft** clearly communicates the merge request in question isn't ready for review, and makes no assumptions about the progress being made toward it. **Draft** also reduces the cognitive load for new users, non-English speakers, and anyone unfamiliar with the WIP acronym.

data/removals/14_0/create-code-review-w-parameter-removal.yml

@@ -2,5 +2,6 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: phikai
+  breaking_change: true
   body: |
     To create a consistent experience for users based on their preferences, support for toggling whitespace changes via URL parameter has been removed in GitLab 14.0.

data/removals/14_0/deprecate_ci_project_config_path_variable.yml

@@ -2,5 +2,6 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: stkerr
+  breaking_change: true
   body: |
     GitLab 14.0 removes the `CI_PROJECT_CONFIG_PATH` pre-defined project variable in favor of `CI_CONFIG_PATH`, which is functionally the same. If you are using `CI_PROJECT_CONFIG_PATH` in your pipeline configurations, update them to use `CI_CONFIG_PATH` instead.

data/removals/14_0/deprecation_bump_terraform_template_version.yml

@@ -3,6 +3,7 @@
   removal_milestone: "14.0" # example
   issue_url: ""
   reporter: nagyv-gitlab
+  breaking_change: true
   body: |
     As we continuously [develop GitLab's Terraform integrations](https://gitlab.com/gitlab-org/gitlab/-/issues/325312), to minimize customer disruption, we maintain two GitLab CI/CD templates for Terraform:
 

data/removals/14_0/deprecation_manage_access_14_0.yml

@@ -3,6 +3,7 @@
   removal_milestone: "14.0"
   reporter: ogolowisnki
   issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/257829
+  breaking_change: true
   body: |
     To improve performance, we are limiting the number of projects returned from the `GET /groups/:id/` API call to 100. A complete list of projects can still be retrieved with the `GET /groups/:id/projects` API call.
 
@@ -11,6 +12,7 @@
   removal_milestone: "14.0"
   reporter: ogolowinski
   issue_url: 'https://gitlab.com/gitlab-org/gitlab/-/issues/288516'
+  breaking_change: true
   body: |
     GitLab is deprecating the [OAuth 2 implicit grant flow](https://docs.gitlab.com/ee/api/oauth2.html#implicit-grant-flow) as it has been removed for [OAuth 2.1](https://oauth.net/2.1/).
 

data/removals/14_0/deprecation_update_cicd_templates_to_stop_using_hardcode_master.yml

@@ -2,5 +2,6 @@
   reporter: dhershkovitch
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
+  breaking_change: true
   body: |
     Our CI/CD templates have been updated to no longer use hard-coded references to a `master` branch. In 14.0, they all use a variable that points to your project's configured default branch instead. If your CI/CD pipeline relies on our built-in templates, verify that this change works with your current configuration. For example, if you have a `master` branch and a different default branch, the updates to the templates may cause changes to your pipeline behavior. For more information, [read the issue](https://gitlab.com/gitlab-org/gitlab/-/issues/324131).

data/removals/14_0/deuley_servicetemplates_removal.yml

@@ -2,6 +2,7 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: deuley
+  breaking_change: true
   body: |
     Service Templates are [removed in GitLab 14.0](https://gitlab.com/groups/gitlab-org/-/epics/5672). They were used to apply identical settings to a large number of projects, but they only did so at the time of project creation.
 

data/removals/14_0/release_announce_deprecation_of_release_notes_api.yml

@@ -3,5 +3,6 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   issue_url: 'https://gitlab.com/gitlab-org/gitlab/-/issues/300887'
+  breaking_change: true
   body: |
     GitLab 14.0 removes support for the release description in the Tags API. You can no longer add a release description when [creating a new tag](https://docs.gitlab.com/ee/api/tags.html#create-a-new-tag). You also can no longer [create](https://docs.gitlab.com/ee/api/tags.html#create-a-new-release) or [update](https://docs.gitlab.com/ee/api/tags.html#update-a-release) a release through the Tags API. Please migrate to use the [Releases API](https://docs.gitlab.com/ee/api/releases/#create-a-release) instead.

data/removals/14_0/release_deprecation_auto-deploy-image.yml

@@ -3,6 +3,7 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   issue_url: 'https://gitlab.com/gitlab-org/gitlab/-/issues/300862'
+  breaking_change: true
   body: |
     In GitLab 14.0, we will update the [Auto Deploy](https://docs.gitlab.com/ee/topics/autodevops/stages.html#auto-deploy) CI template to the latest version. This includes new features, bug fixes, and performance improvements with a dependency on the v2 [auto-deploy-image](https://gitlab.com/gitlab-org/cluster-integration/auto-deploy-image). Auto Deploy CI tempalte v1 will is deprecated going forward.
 

data/removals/14_0/release_domainsource_configuration_for_gitlab_pages_deprecation.yml

@@ -3,5 +3,6 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   issue_url: 'https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/5993'
+  breaking_change: true
   body: |
     GitLab Pages [API-based configuration](https://docs.gitlab.com/ee/administration/pages/#gitlab-api-based-configuration) has been available since GitLab 13.0. It replaces the unsupported `disk` source configuration removed in GitLab 14.0, which can no longer be chosen. You should stop using `disk` source configuration, and move to `gitlab` for an API-based configuration. To migrate away from the 'disk' source configuration, set `gitlab_pages['domain_config_source'] = "gitlab"` in your `/etc/gitlab/gitlab.rb` file. We recommend you migrate before updating to GitLab 14.0, to identify and troubleshoot any potential problems before upgrading.

data/removals/14_0/release_legacy_feature_flags_deprecation.yml

@@ -3,5 +3,6 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   issue_url: 'https://gitlab.com/gitlab-org/gitlab/-/issues/254324'
+  breaking_change: true
   body: |
     Legacy feature flags became read-only in GitLab 13.4. GitLab 14.0 removes support for legacy feature flags, so you must migrate them to the [new version](https://docs.gitlab.com/ee/operations/feature_flags.html). You can do this by first taking a note (screenshot) of the legacy flag, then deleting the flag through the API or UI (you don't need to alter the code), and finally create a new Feature Flag with the same name as the legacy flag you deleted. Also, make sure the strategies and environments match the deleted flag. We created a [video tutorial](https://www.youtube.com/watch?v=CAJY2IGep7Y) to help with this migration.

data/removals/14_0/release_remove_redundant_keyvalue_pair_from_the_payload_of_dora.yml

@@ -3,5 +3,6 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   issue_url: 'https://gitlab.com/gitlab-org/gitlab/-/issues/325931'
+  breaking_change: true
   body: |
     The [deployment frequency project-level API](https://docs.gitlab.com/ee/api/dora4_project_analytics.html#list-project-deployment-frequencies) endpoint has been deprecated in favor of the [DORA 4 API](https://docs.gitlab.com/ee/api/dora/metrics.html), which consolidates all the metrics under one API with the specific metric as a required field. As a result, the timestamp field, which doesn't allow adding future extensions and causes performance issues, will be removed. With the old API, an example response would be `{ "2021-03-01": 3, "date": "2021-03-01", "value": 3 }`. The first key/value (`"2021-03-01": 3`) will be removed and replaced by the last two (`"date": "2021-03-01", "value": 3`).

data/removals/14_0/removal-geo-fdw-settings.yml

@@ -2,6 +2,7 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: fzimmer
+  breaking_change: true
   body: |
     As [announced in GitLab 13.3](https://about.gitlab.com/releases/2020/08/22/gitlab-13-3-released/#geo-foreign-data-wrapper-settings-deprecated), the following configuration settings in `/etc/gitlab/gitlab.rb` have been removed in 14.0:
 

data/removals/14_0/removal-graphql-fields.yml

@@ -2,6 +2,7 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: gweaver
+  breaking_change: true
   body: |
     In accordance with our [GraphQL deprecation and removal process](https://docs.gitlab.com/ee/api/graphql/#deprecation-process), the following fields that were deprecated prior to 13.7 are [fully removed in 14.0](https://gitlab.com/gitlab-org/gitlab/-/issues/267966):
 

data/removals/14_0/removal-legacy-storage.yml

@@ -2,5 +2,6 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: fzimmer
+  breaking_change: true
   body: |
     As [announced in GitLab 13.0](https://about.gitlab.com/releases/2020/05/22/gitlab-13-0-released/#planned-removal-of-legacy-storage-in-14.0), [legacy storage](https://docs.gitlab.com/ee/administration/repository_storage_types.html#legacy-storage) has been removed in GitLab 14.0.

data/removals/14_0/removal-protect-features.yml

@@ -2,6 +2,7 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: sam.white
+  breaking_change: true
   body: |
     Clair, the default container scanning engine, was deprecated in GitLab 13.9 and is removed from GitLab 14.0 and replaced by Trivy. We advise customers who are customizing variables for their container scanning job to [follow these instructions](https://docs.gitlab.com/ee/user/application_security/container_scanning/#change-scanners) to ensure that their container scanning jobs continue to work.
 
@@ -9,5 +10,6 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: sam.white
+  breaking_change: true
   body: |
     The Web Application Firewall (WAF) was deprecated in GitLab 13.6 and is removed from GitLab 14.0. The WAF had limitations inherent in the architectural design that made it difficult to meet the requirements traditionally expected of a WAF. By removing the WAF, GitLab is able to focus on improving other areas in the product where more value can be provided to users. Users who currently rely on the WAF can continue to use the free and open source [ModSecurity](https://github.com/SpiderLabs/ModSecurity) project, which is independent from GitLab. Additional details are available in the [deprecation issue](https://gitlab.com/gitlab-org/gitlab/-/issues/271276).

data/removals/14_0/removal-sidekiq_experimental_queue_selector.yml

@@ -2,6 +2,7 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: smcgivern
+  breaking_change: true
   body: |
     GitLab supports a [queue selector](https://docs.gitlab.com/ee/administration/operations/extra_sidekiq_processes.html#queue-selector) to run only a subset of background jobs for a given process. When it was introduced, this option had an 'experimental' prefix (`experimental_queue_selector` in Omnibus, `experimentalQueueSelector` in Helm charts).
 

data/removals/14_0/removal-unicorn.yml

@@ -2,5 +2,6 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: fzimmer
+  breaking_change: true
   body: |
     [Support for Unicorn](https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/6078) has been removed in GitLab 14.0 in favor of Puma. [Puma has a multi-threaded architecture](https://docs.gitlab.com/ee/administration/operations/puma.html) which uses less memory than a multi-process application server like Unicorn. On GitLab.com, we saw a 40% reduction in memory consumption by using Puma.

data/removals/14_0/removal_ci_project_config_path.yml

@@ -2,6 +2,7 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: stkerr
+  breaking_change: true
   body: |
     The `CI_PROJECT_CONFIG_PATH` [predefined project variable](https://docs.gitlab.com/ee/ci/variables/predefined_variables.html)
     has been removed in favor of `CI_CONFIG_PATH`, which is functionally the same.

data/removals/14_0/removal_enablement_helm2.yml

@@ -2,6 +2,7 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: joshlambert
+  breaking_change: true
   body: |
     Helm v2 was [officially deprecated](https://helm.sh/blog/helm-v2-deprecation-timeline/) in November of 2020, with the `stable` repository being [de-listed from the Helm Hub](https://about.gitlab.com/blog/2020/11/09/ensure-auto-devops-work-after-helm-stable-repo/) shortly thereafter. With the release of GitLab 14.0, which will include the 5.0 release of the [GitLab Helm chart](https://docs.gitlab.com/charts/), Helm v2 will no longer be supported.
 

data/removals/14_0/removal_enablement_opensuse_15_1.yml

@@ -2,5 +2,6 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: dorrino
+  breaking_change: true
   body: |
     Support for [OpenSUSE Leap 15.1 is being deprecated](https://gitlab.com/gitlab-org/omnibus-gitlab/-/merge_requests/5135). Support for 15.1 will be dropped in 14.0. We are now providing support for openSUSE Leap 15.2 packages.

data/removals/14_0/removal_enablement_pg11.yml

@@ -2,6 +2,7 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: joshlambert
+  breaking_change: true
   body: |
     PostgreSQL 12 will be the minimum required version in GitLab 14.0. It offers [significant improvements](https://www.postgresql.org/about/news/postgresql-12-released-1976/) to indexing, partitioning, and general performance benefits.
 

data/removals/14_0/removal_enablement_ubuntu_16.yml

@@ -2,6 +2,7 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: joshlambert
+  breaking_change: true
   body: |
     Ubuntu 16.04 [reached end-of-life in April 2021](https://ubuntu.com/about/release-cycle), and no longer receives maintenance updates. We strongly recommend users to upgrade to a newer release, such as 20.04.
 

data/removals/14_0/removal_repost_static_analysis_notices.yml

@@ -3,6 +3,7 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   issue_url: 'https://gitlab.com/gitlab-org/gitlab/-/issues/229974'
+  breaking_change: true
   body: |
     Until GitLab 13.9, if you wanted to avoid running one particular GitLab SAST analyzer, you needed to remove it from the [long string of analyzers in the `SAST.gitlab-ci.yml` file](https://gitlab.com/gitlab-org/gitlab/-/blob/390afc431e7ce1ac253b35beb39f19e49c746bff/lib/gitlab/ci/templates/Security/SAST.gitlab-ci.yml#L12) and use that to set the [`SAST_DEFAULT_ANALYZERS`](https://docs.gitlab.com/ee/user/application_security/sast/#docker-images) variable in your project's CI file. If you did this, it would exclude you from future new analyzers because this string hard codes the list of analyzers to execute. We avoid this problem by inverting this variable's logic to exclude, rather than choose default analyzers.
     Beginning with 13.9, [we migrated](https://gitlab.com/gitlab-org/gitlab/-/blob/14fed7a33bfdbd4663d8928e46002a5ef3e3282c/lib/gitlab/ci/templates/Security/SAST.gitlab-ci.yml#L13) to `SAST_EXCLUDED_ANALYZERS` in our `SAST.gitlab-ci.yml` file. We encourage anyone who uses a [customized SAST configuration](https://docs.gitlab.com/ee/user/application_security/sast/#customizing-the-sast-settings) in their project CI file to migrate to this new variable. If you have not overridden `SAST_DEFAULT_ANALYZERS`, no action is needed. The CI/CD variable `SAST_DEFAULT_ANALYZERS` has been removed in GitLab 14.0, which released on June 22, 2021.
@@ -12,6 +13,7 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   issue_url: 'https://gitlab.com/gitlab-org/gitlab/-/issues/297269'
+  breaking_change: true
   body: |
     To ensure Secret Detection was scanning both default branches and feature branches, we introduced two separate secret detection CI jobs (`secret_detection_default_branch` and `secret_detection`) in our managed [`Secret-Detection.gitlab-ci.yml`](https://gitlab.com/gitlab-org/gitlab/-/blob/master/lib/gitlab/ci/templates/Security/Secret-Detection.gitlab-ci.yml) template. These two CI jobs created confusion and complexity in the CI rules logic. This deprecation moves the `rule` logic into the `script` section, which then determines how the `secret_detection` job is run (historic, on a branch, commits, etc).
     If you override or maintain custom versions of `SAST.gitlab-ci.yml` or `Secret-Detection.gitlab-ci.yml`, you must update your CI templates. We strongly encourage [inheriting and overriding our managed CI templates](https://docs.gitlab.com/ee/user/application_security/secret_detection/#custom-settings-example) to future-proof your CI templates. GitLab 14.0 no longer supports the old `secret_detection_default_branch` job.
@@ -22,6 +24,7 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   issue_url: 'https://gitlab.com/gitlab-org/gitlab/-/issues/301215'
+  breaking_change: true
   body: |
     With the release of [SAST Custom Rulesets](https://docs.gitlab.com/ee/user/application_security/sast/#customize-rulesets) in GitLab 13.5 we allow greater flexibility in configuration options for our Go analyzer (GoSec). As a result we no longer plan to support our less flexible [`SAST_GOSEC_CONFIG`](https://docs.gitlab.com/ee/user/application_security/sast/#analyzer-settings) analyzer setting. This variable was deprecated in GitLab 13.10.
     GitLab 14.0 removes the old `SAST_GOSEC_CONFIG variable`. If you use or override `SAST_GOSEC_CONFIG` in your CI file, update your SAST CI configuration or pin to an older version of the GoSec analyzer. We strongly encourage [inheriting and overriding our managed CI templates](https://docs.gitlab.com/ee/user/application_security/sast/#overriding-sast-jobs) to future-proof your CI templates.
@@ -31,6 +34,7 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   issue_url: 'https://gitlab.com/gitlab-org/gitlab/-/issues/301216'
+  breaking_change: true
   body: |
     With the maturity of GitLab Secure scanning tools, we've needed to add more granularity to our release process. Previously, GitLab shared a major version number for [all analyzers and tools](https://docs.gitlab.com/ee/user/application_security/sast/#supported-languages-and-frameworks). This requires all tools to share a major version, and prevents the use of [semantic version numbering](https://semver.org/). In GitLab 14.0, SAST removes the `SAST_ANALYZER_IMAGE_TAG` global variable in our [managed `SAST.gitlab-ci.yml`](https://gitlab.com/gitlab-org/gitlab/-/blob/master/lib/gitlab/ci/templates/Jobs/SAST.gitlab-ci.yml) CI template, in favor of the analyzer job variable setting the `major.minor` tag in the SAST vendored template.
 

data/removals/14_0/removal_runner_25555.yml

@@ -2,6 +2,7 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: deastman
+  breaking_change: true
   body: |
     In GitLab Runner 13.0, [issue #5069](https://gitlab.com/gitlab-org/gitlab-runner/-/issues/5069), we introduced new timing options for the GitLab Docker Machine executor. In GitLab Runner 14.0, we have removed the old configuration option, [off peak time mode](https://docs.gitlab.com/runner/configuration/autoscale.html#off-peak-time-mode-configuration-deprecated).
 

data/removals/14_0/removal_runner_26036.yml

@@ -2,5 +2,6 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: deastman
+  breaking_change: true
   body: |
     Ubuntu 19.10 (Eoan Ermine) reached end of life on Friday, July 17, 2020. In GitLab Runner 14.0, Ubuntu 19.10 (Eoan Ermine) is no longer available from our package distribution. Refer to [issue #26036](https://gitlab.com/gitlab-org/gitlab-runner/-/issues/26036) for details.

data/removals/14_0/removal_runner_26419.yml

@@ -2,5 +2,6 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: deastman
+  breaking_change: true
   body: |
     In GitLab Runner 13.2, PowerShell Core support was added to the Shell executor. In 14.0, PowerShell Core, `pwsh` is now the default shell for newly-registered Windows runners. Windows `CMD` will still be available as a shell option for Windows runners. Refer to [issue #26419](https://gitlab.com/gitlab-org/gitlab-runner/-/issues/26419) for details.

data/removals/14_0/removal_runner_4845.yml

@@ -2,5 +2,6 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: deastman
+  breaking_change: true
   body: |
     In GitLab Runner 14.0, the installation process will ignore the `skel` directory by default when creating the user home directory. Refer to [issue #4845](https://gitlab.com/gitlab-org/gitlab-runner/-/issues/4845) for details.

data/removals/14_0/removal_runner_6413.yml

@@ -2,5 +2,6 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: deastman
+  breaking_change: true
   body: |
     In [GitLab Runner 13.1](https://docs.gitlab.com/runner/executors/shell.html#gitlab-131-and-later), [issue #3376](https://gitlab.com/gitlab-org/gitlab-runner/-/issues/3376), we introduced `sigterm` and then `sigkill` to a process in the Shell executor. We also introduced a new feature flag, `FF_SHELL_EXECUTOR_USE_LEGACY_PROCESS_KILL`, so you can use the previous process termination sequence. In GitLab Runner 14.0, [issue #6413](https://gitlab.com/gitlab-org/gitlab-runner/-/issues/6413), the feature flag has been removed.

data/removals/14_0/removals-14-testing-team.yml

@@ -2,6 +2,7 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: jheimbuck_gl
+  breaking_change: true
   body: |
     Browser Performance Testing has run in a job named `performance` by default. With the introduction of [Load Performance Testing](https://docs.gitlab.com/ee/user/project/merge_requests/load_performance_testing.html) in GitLab 13.2, this naming could be confusing. To make it clear which job is running [Browser Performance Testing](https://docs.gitlab.com/ee/user/project/merge_requests/browser_performance_testing.html), the default job name is changed from `performance` to `browser_performance` in the template in GitLab 14.0.
 
@@ -10,6 +11,7 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: jheimbuck_gl
+  breaking_change: true
   body: |
     By default, the Code Quality feature has not provided support for Ruby 2.6+ if you're using the Code Quality template. To better support the latest versions of Ruby, the default RuboCop version is updated to add support for Ruby 2.4 through 3.0. As a result, support for Ruby 2.1, 2.2, and 2.3 is removed. You can re-enable support for older versions by [customizing your configuration](https://docs.gitlab.com/ee/user/project/merge_requests/code_quality.html#rubocop-errors).
 
@@ -18,6 +20,7 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: jheimbuck_gl
+  breaking_change: true
   body: |
     By default, the `Ruby.gitlab-ci.yml` file has included Ruby 2.5.
 

data/removals/14_0/removals_runner_26651.yml

@@ -2,5 +2,6 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: deastman
+  breaking_change: true
   body: |
     In GitLab Runner 13.3, a symlink was added from `/user/lib/gitlab-runner/gitlab-runner` to `/usr/bin/gitlab-runner`. In 14.0, the symlink has been removed and the runner is now installed in `/usr/bin/gitlab-runner`. Refer to [issue #26651](https://gitlab.com/gitlab-org/gitlab-runner/-/issues/26651) for details.

data/removals/14_0/removals_runner_26679.yml

@@ -2,5 +2,6 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: deastman
+  breaking_change: true
   body: |
     In 14.0, we have deactivated the `FF_RESET_HELPER_IMAGE_ENTRYPOINT` feature flag. Refer to issue [#26679](https://gitlab.com/gitlab-org/gitlab-runner/-/issues/26679) for details.

data/removals/14_0/removals_runner_26900.yml

@@ -2,5 +2,6 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: deastman
+  breaking_change: true
   body: |
     In GitLab Runner 13.5, we introduced `failed` and `success` states for a job. To support Prometheus rules, we chose to convert `success/failure` to `finished` for the metric. In 14.0, the conversion has now been removed. Refer to [issue #26900](https://gitlab.com/gitlab-org/gitlab-runner/-/issues/26900) for details.

data/removals/14_0/removals_runner_27175.yml

@@ -2,5 +2,6 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: deastman
+  breaking_change: true
   body: |
     GitLab Runner 14.0 removes the `FF_USE_GO_CLOUD_WITH_CACHE_ARCHIVER` feature flag. Refer to [issue #27175](https://gitlab.com/gitlab-org/gitlab-runner/-/issues/27175) for details.

data/removals/14_0/removals_runner_27218.yml

@@ -2,5 +2,6 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: deastman
+  breaking_change: true
   body: |
     In 14.0, we are now pulling the GitLab Runner [helper image](https://docs.gitlab.com/runner/configuration/advanced-configuration.html#helper-image) from the GitLab Container Registry instead of Docker Hub. Refer to [issue #27218](https://gitlab.com/gitlab-org/gitlab-runner/-/issues/27218) for details.

data/removals/14_0/removals_runner_27551.yml

@@ -2,5 +2,6 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: deastman
+  breaking_change: true
   body: |
     In 14.0, we have removed Windows Server 1903. Microsoft ended support for this version on 2020-08-12. Refer to [issue #27551](https://gitlab.com/gitlab-org/gitlab-runner/-/issues/27551) for details.

data/removals/14_0/removals_runner_27899.yml

@@ -2,5 +2,6 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: deastman
+  breaking_change: true
   body: |
     In 14.0, we have removed Windows Server 1909. Microsoft ended support for this version on 2021-05-11. Refer to [issue #27899](https://gitlab.com/gitlab-org/gitlab-runner/-/issues/27899) for details.

data/removals/14_0/remove-sql-elector.yml

@@ -2,6 +2,7 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: mjwood
+  breaking_change: true
   body: |
     Now that Praefect supports a [primary election strategy](https://docs.gitlab.com/ee/administration/gitaly/praefect.html#repository-specific-primary-nodes) for each repository, we have removed the `sql` election strategy.
     The `per_repository` election strategy is the new default, which is automatically used if no election strategy was specified.

data/removals/14_0/remove_dast_env_variables.yml

@@ -2,6 +2,7 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: derekferguson
+  breaking_change: true
   body: |
     GitLab 13.8 renamed multiple environment variables to support their broader usage in different workflows. In GitLab 14.0, the old variables have been permanently removed and will no longer work. Any configurations using these variables must be updated to the new variable names. Any scans using these variables in GitLab 14.0 and later will fail to be configured correctly. These variables are:
 

data/removals/14_0/remove_dast_legacy_domain_validation.yml

@@ -2,6 +2,7 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: derekferguson
+  breaking_change: true
   body: |
     The legacy method of DAST Domain Validation for CI/CD scans was deprecated in GitLab 13.8, and is removed in GitLab 14.0. This method of domain validation only disallows scans if the `DAST_FULL_SCAN_DOMAIN_VALIDATION_REQUIRED` environment variable is set to `true` in the `gitlab-ci.yml` file, and a `Gitlab-DAST-Permission` header on the site is not set to `allow`. This two-step method required users to opt in to using the variable before they could opt out from using the header.
 

data/removals/14_0/remove_dast_legacy_report_fields.yml

@@ -2,6 +2,7 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: derekferguson
+  breaking_change: true
   body: |
     As a part of the migration to a common report format for all of the Secure scanners in GitLab, DAST is making changes to the DAST JSON report. Certain legacy fields were deprecated in 13.8 and have been completely removed in 14.0. These fields are `@generated`, `@version`, `site`, and `spider`. This should not affect any normal DAST operation, but does affect users who consume the JSON report in an automated way and use these fields. Anyone affected by these changes, and needs these fields for business reasons, is encouraged to open a new GitLab issue and explain the need.
 

data/removals/14_0/remove_dast_spider_host_reset.yml

@@ -2,5 +2,6 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: derekferguson
+  breaking_change: true
   body: |
     In GitLab 14.0, DAST has removed the current method of resetting the scan to the hostname when starting to spider. Prior to GitLab 14.0, the spider would not begin at the specified target path for the URL but would instead reset the URL to begin crawling at the host root. GitLab 14.0 changes the default for the new variable `DAST_SPIDER_START_AT_HOST` to `false` to better support users' intention of beginning spidering and scanning at the specified target URL, rather than the host root URL. This change has an added benefit: scans can take less time, if the specified path does not contain links to the entire site. This enables easier scanning of smaller sections of an application, rather than crawling the entire app during every scan.

data/removals/14_0/remove_dast_template_stages.yml

@@ -2,5 +2,6 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: derekferguson
+  breaking_change: true
   body: |
     In GitLab 14.0, we've removed the stages defined in the current `DAST.gitlab-ci.yml` template to avoid the situation where the template overrides manual changes made by DAST users. We're making this change in response to customer issues where the stages in the template cause problems when used with customized DAST configurations. Because of this removal, `gitlab-ci.yml` configurations that do not specify a `dast` stage must be updated to include this stage.

data/removals/14_0/remove_optimize_api.yml

@@ -2,5 +2,6 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: ljlane
+  breaking_change: true
   body: |
     The first release of the DevOps Adoption report had a concept of **Segments**. Segments were [quickly removed from the report](https://gitlab.com/groups/gitlab-org/-/epics/5251) because they introduced an additional layer of complexity on top of **Groups** and **Projects**. Subsequent iterations of the DevOps Adoption report focus on comparing adoption across groups rather than segments. GitLab 14.0 removes all references to **Segments** [from the GraphQL API](https://gitlab.com/gitlab-org/gitlab/-/issues/324414) and replaces them with **Enabled groups**.

data/removals/14_0/remove_terraform_template.yml

@@ -3,6 +3,7 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   issue_url: 'https://gitlab.com/gitlab-org/gitlab/-/issues/328500'
+  breaking_change: true
   body: |
     GitLab 14.0 renews the Terraform CI template to the latest version. The new template is set up for the GitLab Managed Terraform state, with a dependency on the GitLab `terraform-images` image, to provide a good user experience around GitLab's Infrastructure-as-Code features.
 

data/removals/14_0/verify-ci-removal-parametertrace.yml

@@ -2,6 +2,7 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: jreporter
+  breaking_change: true
   body: |
    GitLab Runner was updated in GitLab 13.4 to internally stop passing the `trace` parameter to the `/api/jobs/:id` endpoint. GitLab 14.0 deprecates the `trace` parameter entirely for all other requests of this endpoint. Make sure your [GitLab Runner version matches your GitLab version](https://docs.gitlab.com/runner/#gitlab-runner-versions) to ensure consistent behavior.
 

data/removals/14_0/verify-ci-removalpipelineservice.yml

@@ -2,5 +2,6 @@
   removal_date: "2021-06-22"
   removal_milestone: "14.0"
   reporter: jreporter
+  breaking_change: true
   body: |
     For self-managed instances using the experimental [external pipeline validation service](https://docs.gitlab.com/ee/administration/external_pipeline_validation.html), the range of error codes GitLab accepts will be reduced. Currently, pipelines are invalidated when the validation service returns a response code from `400` to `499`. In GitLab 14.0 and later, pipelines will be invalidated for the `406: Not Accepted` response code only.

data/removals/14_1/removal-memory-prometheus-options-source.yml

@@ -2,6 +2,7 @@
   removal_date: July 22, 2021
   removal_milestone: "14.1"
   reporter: fzimmer
+  breaking_change: false
   body: |
     The support for `prometheus.listen_address` and `prometheus.enable` has been removed from `gitlab.yml`. Use `prometheus.enabled` and `prometheus.server_address` to set up Prometheus server that GitLab instance connects to. Refer to [our documentation](https://docs.gitlab.com/ee/install/installation.html#prometheus-server-setup) for details.
 

data/removals/14_1/removal-outdated-browser-support.yml

@@ -2,6 +2,7 @@
   removal_date: July 22, 2021
   removal_milestone: "14.1"
   reporter: leipert
+  breaking_change: false
   body: |
     In GitLab 14.1, we are cleaning up and [removing old code](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/63994) that was specific for browsers that we no longer support. This has no impact on users when one of our [supported web browsers](https://docs.gitlab.com/ee/install/requirements.html#supported-web-browsers) is used.
 

data/removals/14_2/removal-verify-build-log.yml

@@ -2,6 +2,7 @@
   removal_date: August 22, 2021 # day the removal was released
   removal_milestone: "14.2"
   reporter: jreporter # GitLab username of the person reporting the removal
+  breaking_change: false
   body: |
     GitLab values efficiency for all users in our wider community of contributors, so we're always working hard to make sure the application performs at a high level with a lovable UX.
       In GitLab 14.2, we have introduced a [job log file size limit](https://docs.gitlab.com/ee/administration/instance_limits.html#maximum-file-size-for-job-logs), set to 100 megabytes by default. Administrators of self-managed GitLab instances can customize this to any value. All jobs that exceed this limit are dropped and marked as failed, helping prevent performance impacts or over-use of resources. This ensures that everyone using GitLab has the best possible experience.

data/removals/14_3/removal-limit-tags-to-50.yml

@@ -2,5 +2,6 @@
   removal_date: September 22nd, 2021 
   removal_milestone: "14.3"
   reporter: jreporter
+  breaking_change: false
   body: |
     GitLab values efficiency and is prioritizing reliability for [GitLab.com in FY22](https://about.gitlab.com/direction/#gitlab-hosted-first). In 14.3, GitLab CI/CD jobs must have less than 50 [tags](https://docs.gitlab.com/ee/ci/yaml/index.html#tags). If a pipeline contains a job with 50 or more tags, you will receive an error and the pipeline will not be created.

data/removals/14_3/removal-verify-pe-pipelinefindername.yml

@@ -2,5 +2,6 @@
   removal_date: September 22, 2021 # day the removal was released
   removal_milestone: "14.3"
   reporter: jreporter # GitLab username of the person reporting the removal
+  breaking_change: false
   body: |
     In GitLab 14.3, we will remove the ability to filter by `name` in the [list project pipelines API endpoint](https://docs.gitlab.com/ee/api/pipelines.html#list-project-pipelines) to improve performance. If you currently use this parameter with this endpoint, you must switch to `username`.

data/removals/14_3/removal_legacy_storage_setting.yml

@@ -2,6 +2,7 @@
   removal_date: September 22nd, 2021 # day the removal was released
   removal_milestone: "14.3"
   reporter: dorrino # GitLab username of the person reporting the removal
+  breaking_change: false
   body: |  # example (supports markdown)
     The support for [`gitlab_pages['use_legacy_storage']` setting](https://docs.gitlab.com/ee/administration/pages/index.html#domain-source-configuration-before-140) in Omnibus installations has been removed.
     

data/removals/templates/_removal_template.md.erb

@@ -33,6 +33,7 @@ For removal reviewers (Technical Writers only):
     <%- entries.select{|entry| entry["removal_milestone"] == milestone}.each do |removal| %>
 ### <%= removal["name"]%>
 <% if removal["breaking_change"] -%>
+
 WARNING:
 This feature was changed or removed in <%= removal["removal_milestone"]%>
 as a [breaking change](https://docs.gitlab.com/ee/development/contributing/#breaking-changes).

data/removals/templates/example.yml

@@ -15,6 +15,7 @@
   removal_milestone: "XX.YY" # The milestone when this feature is being removed.
   removal_date: "YYYY-MM-DD" # This should almost always be the 22nd of a month (YYYY-MM-DD), the date of the milestone release when this feature will be removed.
   breaking_change: false # Change to true if this removal is a breaking change.
+  reporter: exampleuser # GitLab username of the person reporting the removal
   body: | # Do not modify this line, instead modify the lines below.
     <!-- START OF BODY COMMENT