Merge branch 'move-query-analyzers-to-before' into 'master'

Register `QueryAnalayzers` in `config.before` to fix `let_it_be`

See merge request gitlab-org/gitlab!76567

lib/gitlab/database/query_analyzer.rb

@@ -67,8 +67,6 @@ module Gitlab
         end
       end
 
-      private
-
       # Enable query analyzers
       def begin!
         analyzers = all_analyzers.select do |analyzer|
@@ -97,6 +95,8 @@ module Gitlab
         Thread.current[:query_analyzer_enabled_analyzers] = nil
       end
 
+      private
+
       def enabled_analyzers
         Thread.current[:query_analyzer_enabled_analyzers]
       end

spec/support/database/query_analyzer.rb

@@ -4,11 +4,15 @@
 # can be disabled selectively
 
 RSpec.configure do |config|
-  config.around do |example|
+  config.before do |example|
     if example.metadata.fetch(:query_analyzers, true)
-      ::Gitlab::Database::QueryAnalyzer.instance.within { example.run }
-    else
-      example.run
+      ::Gitlab::Database::QueryAnalyzer.instance.begin!
+    end
+  end
+
+  config.after do |example|
+    if example.metadata.fetch(:query_analyzers, true)
+      ::Gitlab::Database::QueryAnalyzer.instance.end!
     end
   end
 end