Merge branch '44353-improve-snippet-search-performance' into 'master'

Remove redundant counts in snippets search

Closes #44353

See merge request gitlab-org/gitlab-ce!23952

app/helpers/search_helper.rb

@@ -24,10 +24,10 @@ module SearchHelper
   end
 
   def search_entries_info(collection, scope, term)
-    return unless collection.count > 0
+    return if collection.to_a.empty?
 
     from = collection.offset_value + 1
-    to = collection.offset_value + collection.count
+    to = collection.offset_value + collection.to_a.size
     count = collection.total_count
 
     "Showing #{from} - #{to} of #{count} #{scope.humanize(capitalize: false)} for \"#{term}\""

app/views/search/_results.html.haml

-- if @search_objects.empty?
+- if @search_objects.to_a.empty?
   = render partial: "search/results/empty"
 - else
   .row-content-block

changelogs/unreleased/44353-improve-snippet-search-performance.yml

+---
+title: Improve snippet search performance by removing duplicate counts
+merge_request: 23952
+author:
+type: performance