Merge branch 'sh-remove-code-quality-usage-feature-flag' into 'master'

Remove code quality usage feature flag

See merge request gitlab-org/gitlab!67792

config/feature_flags/development/usage_data_i_testing_full_code_quality_report_total.yml

----
-name: usage_data_i_testing_full_code_quality_report_total
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/49079
-rollout_issue_url:
-milestone: '13.8'
-type: development
-group: group::testing
-default_enabled: true

ee/app/assets/javascripts/codequality_report/store/actions.js

@@ -4,7 +4,7 @@ import axios from '~/lib/utils/axios_utils';
 import { s__ } from '~/locale';
 
 import { parseCodeclimateMetrics } from '~/reports/codequality_report/store/utils/codequality_parser';
-import { VIEW_EVENT_FEATURE_FLAG, VIEW_EVENT_NAME } from './constants';
+import { VIEW_EVENT_NAME } from './constants';
 import * as types from './mutation_types';
 
 export const setPage = ({ commit }, page) => commit(types.SET_PAGE, page);
@@ -12,9 +12,7 @@ export const setPage = ({ commit }, page) => commit(types.SET_PAGE, page);
 export const requestReport = ({ commit }) => {
   commit(types.REQUEST_REPORT);
 
-  if (gon.features[VIEW_EVENT_FEATURE_FLAG]) {
   Api.trackRedisHllUserEvent(VIEW_EVENT_NAME);
-  }
 };
 export const receiveReportSuccess = ({ state, commit }, data) => {
   const parsedIssues = parseCodeclimateMetrics(data, state.blobPath);

ee/app/assets/javascripts/codequality_report/store/constants.js

-export const VIEW_EVENT_FEATURE_FLAG = 'usageDataITestingFullCodeQualityReportTotal';
 export const VIEW_EVENT_NAME = 'i_testing_full_code_quality_report_total';
 
 export const SEVERITY_SORT_ORDER = {

ee/app/controllers/ee/projects/pipelines_controller.rb

@@ -9,7 +9,6 @@ module EE
       prepended do
         before_action :authorize_read_licenses!, only: [:licenses]
         before_action do
-          push_frontend_feature_flag(:usage_data_i_testing_full_code_quality_report_total, project, default_enabled: true)
           push_frontend_feature_flag(:pipeline_security_dashboard_graphql, project, type: :development, default_enabled: :yaml)
         end
 

ee/spec/frontend/codequality_report/store/actions_spec.js

 import MockAdapter from 'axios-mock-adapter';
 import * as actions from 'ee/codequality_report/store/actions';
-import { VIEW_EVENT_NAME, VIEW_EVENT_FEATURE_FLAG } from 'ee/codequality_report/store/constants';
+import { VIEW_EVENT_NAME } from 'ee/codequality_report/store/constants';
 import * as types from 'ee/codequality_report/store/mutation_types';
 import { TEST_HOST } from 'helpers/test_constants';
 import testAction from 'helpers/vuex_action_helper';
@@ -38,26 +38,14 @@ describe('Codequality report actions', () => {
 
   describe('requestReport', () => {
     it('sets the loading flag', (done) => {
-      window.gon = { features: { [VIEW_EVENT_FEATURE_FLAG]: true } };
-
       testAction(actions.requestReport, null, state, [{ type: types.REQUEST_REPORT }], [], done);
     });
 
-    it('tracks a service ping event when the feature flag is enabled', () => {
-      window.gon = { features: { [VIEW_EVENT_FEATURE_FLAG]: true } };
-
+    it('tracks a service ping event', () => {
       actions.requestReport({ commit: jest.fn() });
 
       expect(Api.trackRedisHllUserEvent).toHaveBeenCalledWith(VIEW_EVENT_NAME);
     });
-
-    it('does not track a service ping event when the feature flag is disabled', () => {
-      window.gon = { features: { [VIEW_EVENT_FEATURE_FLAG]: false } };
-
-      actions.requestReport({ commit: jest.fn() });
-
-      expect(Api.trackRedisHllUserEvent).not.toHaveBeenCalled();
-    });
   });
 
   describe('receiveReportSuccess', () => {

lib/gitlab/usage_data_counters/known_events/common.yml

@@ -170,7 +170,6 @@
   category: testing
   redis_slot: testing
   aggregation: weekly
-  feature_flag: usage_data_i_testing_full_code_quality_report_total
 - name: i_testing_web_performance_widget_total
   category: testing
   redis_slot: testing