Merge branch 'pb-feature-category-code-review-update' into 'master'

Update feature_category of workers to code_review

See merge request gitlab-org/gitlab!47888

app/workers/all_queues.yml

@@ -396,7 +396,7 @@
   :idempotent:
   :tags: []
 - :name: cronjob:schedule_merge_request_cleanup_refs
-  :feature_category: :source_code_management
+  :feature_category: :code_review
   :has_external_dependencies:
   :urgency: :low
   :resource_boundary: :unknown
@@ -404,7 +404,7 @@
   :idempotent: true
   :tags: []
 - :name: cronjob:schedule_migrate_external_diffs
-  :feature_category: :source_code_management
+  :feature_category: :code_review
   :has_external_dependencies:
   :urgency: :low
   :resource_boundary: :unknown
@@ -428,7 +428,7 @@
   :idempotent:
   :tags: []
 - :name: cronjob:stuck_merge_jobs
-  :feature_category: :source_code_management
+  :feature_category: :code_review
   :has_external_dependencies:
   :urgency: :low
   :resource_boundary: :unknown
@@ -1426,7 +1426,7 @@
   :idempotent: true
   :tags: []
 - :name: create_note_diff_file
-  :feature_category: :source_code_management
+  :feature_category: :code_review
   :has_external_dependencies:
   :urgency: :low
   :resource_boundary: :unknown
@@ -1442,7 +1442,7 @@
   :idempotent:
   :tags: []
 - :name: delete_diff_files
-  :feature_category: :source_code_management
+  :feature_category: :code_review
   :has_external_dependencies:
   :urgency: :low
   :resource_boundary: :unknown
@@ -1700,7 +1700,7 @@
   :idempotent:
   :tags: []
 - :name: merge_request_cleanup_refs
-  :feature_category: :source_code_management
+  :feature_category: :code_review
   :has_external_dependencies:
   :urgency: :low
   :resource_boundary: :unknown
@@ -1708,7 +1708,7 @@
   :idempotent: true
   :tags: []
 - :name: merge_request_mergeability_check
-  :feature_category: :source_code_management
+  :feature_category: :code_review
   :has_external_dependencies:
   :urgency: :low
   :resource_boundary: :unknown
@@ -1732,7 +1732,7 @@
   :idempotent: true
   :tags: []
 - :name: migrate_external_diffs
-  :feature_category: :source_code_management
+  :feature_category: :code_review
   :has_external_dependencies:
   :urgency: :low
   :resource_boundary: :unknown
@@ -1756,7 +1756,7 @@
   :idempotent:
   :tags: []
 - :name: new_merge_request
-  :feature_category: :source_code_management
+  :feature_category: :code_review
   :has_external_dependencies:
   :urgency: :high
   :resource_boundary: :cpu
@@ -2072,7 +2072,7 @@
   :idempotent: true
   :tags: []
 - :name: update_merge_requests
-  :feature_category: :source_code_management
+  :feature_category: :code_review
   :has_external_dependencies:
   :urgency: :high
   :resource_boundary: :cpu

app/workers/create_note_diff_file_worker.rb

@@ -3,7 +3,7 @@
 class CreateNoteDiffFileWorker # rubocop:disable Scalability/IdempotentWorker
   include ApplicationWorker
 
-  feature_category :source_code_management
+  feature_category :code_review
 
   def perform(diff_note_id)
     diff_note = DiffNote.find(diff_note_id)

app/workers/delete_diff_files_worker.rb

@@ -3,7 +3,7 @@
 class DeleteDiffFilesWorker # rubocop:disable Scalability/IdempotentWorker
   include ApplicationWorker
 
-  feature_category :source_code_management
+  feature_category :code_review
 
   # rubocop: disable CodeReuse/ActiveRecord
   def perform(merge_request_diff_id)

app/workers/merge_request_cleanup_refs_worker.rb

@@ -3,7 +3,7 @@
 class MergeRequestCleanupRefsWorker
   include ApplicationWorker
 
-  feature_category :source_code_management
+  feature_category :code_review
   idempotent!
 
   def perform(merge_request_id)

app/workers/merge_request_mergeability_check_worker.rb

@@ -3,7 +3,7 @@
 class MergeRequestMergeabilityCheckWorker
   include ApplicationWorker
 
-  feature_category :source_code_management
+  feature_category :code_review
   idempotent!
 
   def perform(merge_request_id)

app/workers/migrate_external_diffs_worker.rb

@@ -3,7 +3,7 @@
 class MigrateExternalDiffsWorker # rubocop:disable Scalability/IdempotentWorker
   include ApplicationWorker
 
-  feature_category :source_code_management
+  feature_category :code_review
 
   def perform(merge_request_diff_id)
     diff = MergeRequestDiff.find_by_id(merge_request_diff_id)

app/workers/new_merge_request_worker.rb

@@ -4,7 +4,7 @@ class NewMergeRequestWorker # rubocop:disable Scalability/IdempotentWorker
   include ApplicationWorker
   include NewIssuable
 
-  feature_category :source_code_management
+  feature_category :code_review
   urgency :high
   worker_resource_boundary :cpu
   weight 2

app/workers/schedule_merge_request_cleanup_refs_worker.rb

@@ -4,7 +4,7 @@ class ScheduleMergeRequestCleanupRefsWorker
   include ApplicationWorker
   include CronjobQueue # rubocop:disable Scalability/CronWorkerContext
 
-  feature_category :source_code_management
+  feature_category :code_review
   idempotent!
 
   # Based on existing data, MergeRequestCleanupRefsWorker can run 3 jobs per

app/workers/schedule_migrate_external_diffs_worker.rb

@@ -10,7 +10,7 @@ class ScheduleMigrateExternalDiffsWorker # rubocop:disable Scalability/Idempoten
 
   include Gitlab::ExclusiveLeaseHelpers
 
-  feature_category :source_code_management
+  feature_category :code_review
 
   def perform
     in_lock(self.class.name.underscore, ttl: 2.hours, retries: 0) do

app/workers/stuck_merge_jobs_worker.rb

@@ -4,7 +4,7 @@ class StuckMergeJobsWorker # rubocop:disable Scalability/IdempotentWorker
   include ApplicationWorker
   include CronjobQueue # rubocop:disable Scalability/CronWorkerContext
 
-  feature_category :source_code_management
+  feature_category :code_review
 
   def self.logger
     Gitlab::AppLogger

app/workers/update_merge_requests_worker.rb

@@ -3,7 +3,7 @@
 class UpdateMergeRequestsWorker # rubocop:disable Scalability/IdempotentWorker
   include ApplicationWorker
 
-  feature_category :source_code_management
+  feature_category :code_review
   urgency :high
   worker_resource_boundary :cpu
   weight 3

ee/app/controllers/projects/approver_groups_controller.rb

@@ -3,7 +3,7 @@
 class Projects::ApproverGroupsController < Projects::ApplicationController
   before_action :authorize_for_subject!
 
-  feature_category :code_review
+  feature_category :source_code_management
 
   def destroy
     subject.approver_groups.find(params[:id]).destroy

ee/app/controllers/projects/approvers_controller.rb

@@ -3,7 +3,7 @@
 class Projects::ApproversController < Projects::ApplicationController
   before_action :authorize_for_subject!
 
-  feature_category :code_review
+  feature_category :source_code_management
 
   # @deprecated
   def destroy

ee/lib/api/merge_request_approval_rules.rb

@@ -4,7 +4,7 @@ module API
   class MergeRequestApprovalRules < ::API::Base
     before { authenticate_non_get! }
 
-    feature_category :code_review
+    feature_category :source_code_management
 
     helpers do
       def find_merge_request_approval_rule(merge_request, id)

ee/lib/api/project_approval_rules.rb

@@ -6,7 +6,7 @@ module API
 
     helpers ::API::Helpers::ProjectApprovalRulesHelpers
 
-    feature_category :code_review
+    feature_category :source_code_management
 
     params do
       requires :id, type: String, desc: 'The ID of a project'

ee/lib/api/project_approval_settings.rb

@@ -6,7 +6,7 @@ module API
 
     helpers ::API::Helpers::ProjectApprovalRulesHelpers
 
-    feature_category :code_review
+    feature_category :source_code_management
 
     params do
       requires :id, type: String, desc: 'The ID of a project'

ee/lib/api/project_approvals.rb

@@ -2,7 +2,7 @@
 
 module API
   class ProjectApprovals < ::API::Base
-    feature_category :code_review
+    feature_category :source_code_management
 
     before { authenticate! }
     before { authorize! :update_approvers, user_project }

lib/api/merge_request_approvals.rb

@@ -4,7 +4,7 @@ module API
   class MergeRequestApprovals < ::API::Base
     before { authenticate_non_get! }
 
-    feature_category :code_review
+    feature_category :source_code_management
 
     helpers do
       params :ee_approval_params do