Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
4914f003
Commit
4914f003
authored
Apr 09, 2019
by
Phil Hughes
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixed EE differences in noteable_note.vue
Closes
https://gitlab.com/gitlab-org/gitlab-ee/issues/9972
parent
f4c80603
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
25 additions
and
8 deletions
+25
-8
app/assets/javascripts/notes/components/noteable_note.vue
app/assets/javascripts/notes/components/noteable_note.vue
+4
-8
app/assets/javascripts/notes/mixins/draft.js
app/assets/javascripts/notes/mixins/draft.js
+8
-0
ee/app/assets/javascripts/notes/mixins/draft.js
ee/app/assets/javascripts/notes/mixins/draft.js
+13
-0
No files found.
app/assets/javascripts/notes/components/noteable_note.vue
View file @
4914f003
...
...
@@ -4,6 +4,7 @@ import { mapGetters, mapActions } from 'vuex';
import
{
escape
}
from
'
underscore
'
;
import
{
truncateSha
}
from
'
~/lib/utils/text_utility
'
;
import
TimelineEntryItem
from
'
~/vue_shared/components/notes/timeline_entry_item.vue
'
;
import
draftMixin
from
'
ee_else_ce/notes/mixins/draft
'
;
import
{
s__
,
sprintf
}
from
'
../../locale
'
;
import
Flash
from
'
../../flash
'
;
import
userAvatarLink
from
'
../../vue_shared/components/user_avatar/user_avatar_link.vue
'
;
...
...
@@ -23,7 +24,7 @@ export default {
noteBody
,
TimelineEntryItem
,
},
mixins
:
[
noteable
,
resolvable
],
mixins
:
[
noteable
,
resolvable
,
draftMixin
],
props
:
{
note
:
{
type
:
Object
,
...
...
@@ -73,9 +74,6 @@ export default {
'
is-editable
'
:
this
.
note
.
current_user
.
can_edit
,
};
},
canResolve
()
{
return
this
.
note
.
resolvable
&&
!!
this
.
getUserData
.
id
;
},
canReportAsAbuse
()
{
return
!!
this
.
note
.
report_abuse_path
&&
this
.
author
.
id
!==
this
.
getUserData
.
id
;
},
...
...
@@ -164,7 +162,7 @@ export default {
callback
:
()
=>
this
.
updateSuccess
(),
});
if
(
this
.
note
.
isDraft
)
return
;
if
(
this
.
isDraft
)
return
;
const
data
=
{
endpoint
:
this
.
note
.
path
,
...
...
@@ -252,9 +250,7 @@ export default {
:can-award-emoji=
"note.current_user.can_award_emoji"
:can-delete=
"note.current_user.can_edit"
:can-report-as-abuse=
"canReportAsAbuse"
:can-resolve=
"
note.current_user.can_resolve || (note.isDraft && note.discussion_id !== null)
"
:can-resolve=
"canResolve"
:report-abuse-path=
"note.report_abuse_path"
:resolvable=
"note.resolvable || note.isDraft"
:is-resolved=
"note.resolved || note.resolve_discussion"
...
...
app/assets/javascripts/notes/mixins/draft.js
0 → 100644
View file @
4914f003
export
default
{
computed
:
{
isDraft
:
()
=>
false
,
canResolve
()
{
return
this
.
note
.
current_user
.
can_resolve
;
},
},
};
ee/app/assets/javascripts/notes/mixins/draft.js
0 → 100644
View file @
4914f003
export
default
{
computed
:
{
isDraft
()
{
return
this
.
note
.
isDraft
;
},
canResolve
()
{
return
(
this
.
note
.
current_user
.
can_resolve
||
(
this
.
note
.
isDraft
&&
this
.
note
.
discussion_id
!==
null
)
);
},
},
};
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment