Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
4b3ec11e
Commit
4b3ec11e
authored
Sep 02, 2020
by
Rajendra Kadam
Committed by
Rémy Coutable
Sep 02, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
FIx Lint/RaiseException cop
parent
e50df6b6
Changes
5
Show whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
8 additions
and
12 deletions
+8
-12
.rubocop_todo.yml
.rubocop_todo.yml
+0
-9
changelogs/unreleased/raise-exceptio-cop.yml
changelogs/unreleased/raise-exceptio-cop.yml
+5
-0
db/migrate/20190402150158_backport_enterprise_schema.rb
db/migrate/20190402150158_backport_enterprise_schema.rb
+1
-1
ee/spec/requests/api/helpers_spec.rb
ee/spec/requests/api/helpers_spec.rb
+1
-1
spec/requests/api/helpers_spec.rb
spec/requests/api/helpers_spec.rb
+1
-1
No files found.
.rubocop_todo.yml
View file @
4b3ec11e
...
@@ -153,15 +153,6 @@ Lint/NonDeterministicRequireOrder:
...
@@ -153,15 +153,6 @@ Lint/NonDeterministicRequireOrder:
-
'
qa/spec/spec_helper.rb'
-
'
qa/spec/spec_helper.rb'
-
'
spec/spec_helper.rb'
-
'
spec/spec_helper.rb'
# Offense count: 3
# Configuration parameters: AllowedImplicitNamespaces.
# AllowedImplicitNamespaces: Gem
Lint/RaiseException
:
Exclude
:
-
'
db/migrate/20190402150158_backport_enterprise_schema.rb'
-
'
ee/spec/requests/api/helpers_spec.rb'
-
'
spec/requests/api/helpers_spec.rb'
# Offense count: 27
# Offense count: 27
# Cop supports --auto-correct.
# Cop supports --auto-correct.
Lint/RedundantCopDisableDirective
:
Lint/RedundantCopDisableDirective
:
...
...
changelogs/unreleased/raise-exceptio-cop.yml
0 → 100644
View file @
4b3ec11e
---
title
:
Fix Lint/RaiseException cop
merge_request
:
41099
author
:
Rajendra Kadam
type
:
fixed
db/migrate/20190402150158_backport_enterprise_schema.rb
View file @
4b3ec11e
...
@@ -914,7 +914,7 @@ class BackportEnterpriseSchema < ActiveRecord::Migration[5.0]
...
@@ -914,7 +914,7 @@ class BackportEnterpriseSchema < ActiveRecord::Migration[5.0]
MSG
MSG
end
end
raise
Exception
.
new
(
message
)
raise
StandardError
.
new
(
message
)
end
end
def
create_missing_tables
def
create_missing_tables
...
...
ee/spec/requests/api/helpers_spec.rb
View file @
4b3ec11e
...
@@ -25,7 +25,7 @@ RSpec.describe API::Helpers do
...
@@ -25,7 +25,7 @@ RSpec.describe API::Helpers do
let
(
:params
)
{
request
.
params
}
let
(
:params
)
{
request
.
params
}
def
error!
(
message
,
status
,
header
)
def
error!
(
message
,
status
,
header
)
raise
Exception
.
new
(
"
#{
status
}
-
#{
message
}
"
)
raise
StandardError
.
new
(
"
#{
status
}
-
#{
message
}
"
)
end
end
before
do
before
do
...
...
spec/requests/api/helpers_spec.rb
View file @
4b3ec11e
...
@@ -39,7 +39,7 @@ RSpec.describe API::Helpers do
...
@@ -39,7 +39,7 @@ RSpec.describe API::Helpers do
end
end
def
error!
(
message
,
status
,
header
)
def
error!
(
message
,
status
,
header
)
raise
Exception
.
new
(
"
#{
status
}
-
#{
message
}
"
)
raise
StandardError
.
new
(
"
#{
status
}
-
#{
message
}
"
)
end
end
def
set_param
(
key
,
value
)
def
set_param
(
key
,
value
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment