Commit 4b4b1db6 authored by Kyle Wiebers's avatar Kyle Wiebers

Revert "Merge branch '326106-correlation-id-to-validation-service' into 'master'"

This reverts merge request !58486
parent 251a396f
---
title: Add correlation id in X-Request-ID for external pipeline validation
merge_request: 58486
author:
type: other
......@@ -69,10 +69,8 @@ module Gitlab
end
def validate_service_request
headers = {
'X-Request-ID' => Labkit::Correlation::CorrelationId.current_id,
'X-Gitlab-Token' => validation_service_token
}.compact
headers = {}
headers['X-Gitlab-Token'] = validation_service_token if validation_service_token
Gitlab::HTTP.post(
validation_service_url, timeout: validation_service_timeout,
......
......@@ -127,23 +127,13 @@ RSpec.describe Gitlab::Ci::Pipeline::Chain::Validate::External do
it 'passes token in X-Gitlab-Token header' do
expect(::Gitlab::HTTP).to receive(:post) do |_url, params|
expect(params[:headers]).to include({ 'X-Gitlab-Token' => '123' })
expect(params[:headers]).to eq({ 'X-Gitlab-Token' => '123' })
end
perform!
end
end
it 'passes the correlation id in X-Request-ID header' do
allow(Labkit::Correlation::CorrelationId).to receive(:current_id).and_return('correlation-id')
expect(::Gitlab::HTTP).to receive(:post) do |_url, params|
expect(params[:headers]).to include({ 'X-Request-ID' => 'correlation-id' })
end
perform!
end
context 'when validation returns 200 OK' do
before do
stub_request(:post, validation_service_url).to_return(status: 200, body: "{}")
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment