Use git add . for checking skip_validation

lib/gitlab/usage/metric_definition.rb

@@ -82,9 +82,7 @@ module Gitlab
       end
 
       def skip_validation?
-        return false if attributes[:skip_validation].blank?
-
-        attributes[:skip_validation]
+        !!attributes[:skip_validation]
       end
     end
   end

spec/lib/gitlab/usage/metric_definition_spec.rb

@@ -66,6 +66,13 @@ RSpec.describe Gitlab::Usage::MetricDefinition do
         described_class.new(path, attributes).validate!
       end
 
+      context 'with skip_validation' do
+        it 'raise exception if skip_validation: false' do
+          expect(Gitlab::ErrorTracking).to receive(:track_and_raise_for_dev_exception).at_least(:once).with(instance_of(Gitlab::Usage::Metric::InvalidMetricError))
+
+          described_class.new(path, attributes.merge( { skip_validation: false } )).validate!
+        end
+
         it 'does not raise exception if has skip_validation: true' do
           expect(Gitlab::ErrorTracking).not_to receive(:track_and_raise_for_dev_exception)
 
@@ -73,6 +80,7 @@ RSpec.describe Gitlab::Usage::MetricDefinition do
         end
       end
     end
+  end
 
   describe '.load_all!' do
     let(:metric1) { Dir.mktmpdir('metric1') }