Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
4d2fbe65
Commit
4d2fbe65
authored
Jan 02, 2017
by
Mike Greiling
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
remove unnecessary fixtures and tests
parent
637dafde
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
2 additions
and
90 deletions
+2
-90
app/assets/javascripts/due_date_select.js.es6
app/assets/javascripts/due_date_select.js.es6
+2
-4
spec/javascripts/datetime_utility_spec.js.es6
spec/javascripts/datetime_utility_spec.js.es6
+0
-32
spec/javascripts/due_date_select_spec.js.es6
spec/javascripts/due_date_select_spec.js.es6
+0
-25
spec/javascripts/fixtures/due_date_select.html.haml
spec/javascripts/fixtures/due_date_select.html.haml
+0
-29
No files found.
app/assets/javascripts/due_date_select.js.es6
View file @
4d2fbe65
...
@@ -2,10 +2,9 @@
...
@@ -2,10 +2,9 @@
(function(global) {
(function(global) {
class DueDateSelect {
class DueDateSelect {
constructor({ $dropdown, $loading
, $context
} = {}) {
constructor({ $dropdown, $loading } = {}) {
const $dropdownParent = $dropdown.closest('.dropdown');
const $dropdownParent = $dropdown.closest('.dropdown');
const $block = $dropdown.closest('.block');
const $block = $dropdown.closest('.block');
this.$context = $context || $('body');
this.$loading = $loading;
this.$loading = $loading;
this.$dropdown = $dropdown;
this.$dropdown = $dropdown;
this.$dropdownParent = $dropdownParent;
this.$dropdownParent = $dropdownParent;
...
@@ -81,7 +80,7 @@
...
@@ -81,7 +80,7 @@
}
}
parseSelectedDate() {
parseSelectedDate() {
this.rawSelectedDate =
this.$context.find
(`input[name='${this.fieldName}']`).val();
this.rawSelectedDate =
$
(`input[name='${this.fieldName}']`).val();
if (this.rawSelectedDate.length) {
if (this.rawSelectedDate.length) {
// Avoid time zone inconsistency using the utils.createDateObject
// Avoid time zone inconsistency using the utils.createDateObject
...
@@ -180,6 +179,5 @@
...
@@ -180,6 +179,5 @@
}
}
global.DueDateSelectors = DueDateSelectors;
global.DueDateSelectors = DueDateSelectors;
global.DueDateSelect = DueDateSelect;
})(window.gl || (window.gl = {}));
})(window.gl || (window.gl = {}));
spec/javascripts/datetime_utility_spec.js.es6
View file @
4d2fbe65
...
@@ -2,38 +2,6 @@
...
@@ -2,38 +2,6 @@
(() => {
(() => {
describe('Date time utils', () => {
describe('Date time utils', () => {
describe('create date object', () => {
describe('using dashes', () => {
it('should instantiate the date object using integer params', () => {
spyOn(window, 'Date');
gl.utils.createDateObject('2016-11-12');
expect(window.Date).toHaveBeenCalledWith(2016, 10, 12);
});
it('should return the right date object ', () => {
const date = gl.utils.createDateObject('2016-11-12');
expect(date.getDate()).toBe(12);
expect(date.getMonth()).toBe(10);
expect(date.getFullYear()).toBe(2016);
});
});
describe('using slashes', () => {
it('should also instantiate the date object using integer params', () => {
spyOn(window, 'Date');
gl.utils.createDateObject('2016/08/02');
expect(window.Date).toHaveBeenCalledWith(2016, 7, 2);
});
it('should return the right date object', () => {
const date = gl.utils.createDateObject('2016/08/02');
expect(date.getDate()).toBe(2);
expect(date.getMonth()).toBe(7);
expect(date.getFullYear()).toBe(2016);
});
});
});
describe('get day name', () => {
describe('get day name', () => {
it('should return Sunday', () => {
it('should return Sunday', () => {
const day = gl.utils.getDayName(new Date('07/17/2016'));
const day = gl.utils.getDayName(new Date('07/17/2016'));
...
...
spec/javascripts/due_date_select_spec.js.es6
deleted
100644 → 0
View file @
637dafde
//= require lib/utils/datetime_utility
//= require jquery
//= require jquery-ui/datepicker
//= require gl_dropdown
//= require due_date_select
(() => {
describe('Due Date Select', () => {
describe('parseSelectedDate()', () => {
it('call create date object', () => {
const $dom = $(fixture.preload('due_date_select.html')[0]);
const dueDateSelect = new gl.DueDateSelect({
$context: $dom,
$dropdown: $dom.find('.js-due-date-select'),
$loading: $dom.find('.block-loading'),
});
spyOn(gl.utils, 'createDateObject');
dueDateSelect.parseSelectedDate();
expect(gl.utils.createDateObject).toHaveBeenCalledWith('2016-11-20');
});
});
});
})();
spec/javascripts/fixtures/due_date_select.html.haml
deleted
100644 → 0
View file @
637dafde
.block.due_date
.sidebar-collapsed-icon
%i
.fa.fa-calendar
%span
.js-due-date-sidebar-value
Nov 20, 2016
.title.hide-collapsed
Due date
%i
.fa.fa-spinner.fa-spin.block-loading
%a
.edit-link.pull-right
{
href:
"#"
}
Edit
.value.hide-collapsed
%span
.value-content
%span
.bold
Nov 20, 2016
%span
.no-value.js-remove-due-date-holder
%a
.js-remove-due-date
{
href:
"#"
,
role:
"button"
}
remove due date
.selectbox.hide-collapsed
%input
{
type:
"hidden"
,
name:
"issue[due_date]"
,
id:
"issue[due_date]"
,
value:
"2016-11-20"
}
.dropdown
%button
.dropdown-menu-toggle.js-due-date-select
{
type:
'button'
,
data:
{
toggle:
'dropdown'
,
field_name:
"issue[due_date]"
,
ability_name:
"issue"
,
issue_update:
"/h5bp/html5-boilerplate/issues/10.json"
}
}
%span
.dropdown-toggle-text
Due date
%i
.fa.fa-chevron-down
.dropdown-menu.dropdown-menu-due-date
.dropdown-title
%span
Due Date
%button
.dropdown-title-button.dropdown-menu-close
{
type:
"button"
}
%i
.fa.fa-times.dropdown-menu-close-icon
.dropdown-content
.js-due-date-calendar
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment