Merge branch '329664-remove-feature-flag' into 'master'

Remove :find_remote_root_refs_inmemory feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS]

See merge request gitlab-org/gitlab!62501

config/feature_flags/development/find_remote_root_refs_inmemory.yml

----
-name: find_remote_root_refs_inmemory
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/60583
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/329664
-milestone: '13.12'
-type: development
-group: group::gitaly
-default_enabled: true

ee/app/services/geo/repository_sync_service.rb

@@ -50,17 +50,11 @@ module Geo
     end
 
     def update_root_ref
-      if Feature.enabled?(:find_remote_root_refs_inmemory, default_enabled: :yaml)
       authorization = ::Gitlab::Geo::RepoSyncRequest.new(
         scope: repository.full_path
       ).authorization
 
       project.update_root_ref(GEO_REMOTE_NAME, remote_url, authorization)
-      else
-        repository.with_config(jwt_authentication_header) do
-          project.update_root_ref(GEO_REMOTE_NAME, remote_url, nil)
-        end
-      end
     end
 
     def execute_housekeeping

ee/spec/services/geo/repository_sync_service_spec.rb

@@ -233,69 +233,6 @@ RSpec.describe Geo::RepositorySyncService, :geo do
         context 'with non empty repositories' do
           let(:project) { create(:project, :repository) }
 
-          context 'with inmemory feature disabled' do
-            before do
-              stub_feature_flags(find_remote_root_refs_inmemory: false)
-            end
-
-            context 'when HEAD change' do
-              before do
-                allow(project.repository)
-                  .to receive(:find_remote_root_ref)
-                  .with('geo', url_to_repo, nil)
-                  .and_return('feature')
-              end
-
-              it 'syncs gitattributes to info/attributes' do
-                expect(repository).to receive(:copy_gitattributes)
-
-                subject.execute
-              end
-
-              it 'updates the default branch with JWT credentials' do
-                expect(repository).to receive(:with_config)
-                  .with("http.#{url_to_repo}.extraHeader" => anything)
-                  .and_call_original
-                  .twice
-
-                expect(project).to receive(:change_head).with('feature').once
-
-                subject.execute
-              end
-            end
-
-            context 'when HEAD does not change' do
-              before do
-                allow(project.repository)
-                  .to receive(:find_remote_root_ref)
-                  .with('geo', url_to_repo, nil)
-                  .and_return(project.default_branch)
-              end
-
-              it 'syncs gitattributes to info/attributes' do
-                expect(repository).to receive(:copy_gitattributes)
-
-                subject.execute
-              end
-
-              it 'updates the default branch with JWT credentials' do
-                expect(repository).to receive(:with_config)
-                  .with("http.#{url_to_repo}.extraHeader" => anything)
-                  .and_call_original
-                  .twice
-
-                expect(project).to receive(:change_head).with('master').once
-
-                subject.execute
-              end
-            end
-          end
-
-          context 'with inmemory feature enabled' do
-            before do
-              stub_feature_flags(find_remote_root_refs_inmemory: true)
-            end
-
           context 'when HEAD change' do
             before do
               allow(project.repository)
@@ -320,7 +257,6 @@ RSpec.describe Geo::RepositorySyncService, :geo do
 
               subject.execute
             end
-            end
 
             context 'when HEAD does not change' do
               before do

lib/gitlab/gitaly_client/remote_service.rb

@@ -45,18 +45,9 @@ module Gitlab
 
       # The remote_name parameter is deprecated and will be removed soon.
       def find_remote_root_ref(remote_name, remote_url, authorization)
-        request = if Feature.enabled?(:find_remote_root_refs_inmemory, default_enabled: :yaml)
-                    Gitaly::FindRemoteRootRefRequest.new(
-                      repository: @gitaly_repo,
+        request = Gitaly::FindRemoteRootRefRequest.new(repository: @gitaly_repo,
                                                        remote_url: remote_url,
-                      http_authorization_header: authorization
-                    )
-                  else
-                    Gitaly::FindRemoteRootRefRequest.new(
-                      repository: @gitaly_repo,
-                      remote: remote_name
-                    )
-                  end
+                                                       http_authorization_header: authorization)
 
         response = GitalyClient.call(@storage, :remote_service,
                                      :find_remote_root_ref, request, timeout: GitalyClient.medium_timeout)

spec/lib/gitlab/gitaly_client/remote_service_spec.rb

@@ -38,8 +38,8 @@ RSpec.describe Gitlab::GitalyClient::RemoteService do
     let(:remote) { 'origin' }
     let(:url) { 'http://git.example.com/my-repo.git' }
     let(:auth) { 'Basic secret' }
+    let(:expected_params) { { remote_url: url, http_authorization_header: auth } }
 
-    shared_examples 'a find_remote_root_ref call' do
     it 'sends an find_remote_root_ref message and returns the root ref' do
       expect_any_instance_of(Gitaly::RemoteService::Stub)
         .to receive(:find_remote_root_ref)
@@ -61,27 +61,6 @@ RSpec.describe Gitlab::GitalyClient::RemoteService do
     end
   end
 
-    context 'with inmemory feature enabled' do
-      before do
-        stub_feature_flags(find_remote_root_refs_inmemory: true)
-      end
-
-      it_behaves_like 'a find_remote_root_ref call' do
-        let(:expected_params) { { remote_url: url, http_authorization_header: auth } }
-      end
-    end
-
-    context 'with inmemory feature disabled' do
-      before do
-        stub_feature_flags(find_remote_root_refs_inmemory: false)
-      end
-
-      it_behaves_like 'a find_remote_root_ref call' do
-        let(:expected_params) { { remote: remote } }
-      end
-    end
-  end
-
   describe '#update_remote_mirror' do
     let(:ref_name) { 'remote_mirror_1' }
     let(:only_branches_matching) { %w[my-branch master] }