Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
53dfeeb6
Commit
53dfeeb6
authored
Aug 31, 2020
by
Maxime Orefice
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix false positive spec on PipelineArtifact
parent
7f6fc1bc
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
2 deletions
+2
-2
spec/factories/ci/pipeline_artifacts.rb
spec/factories/ci/pipeline_artifacts.rb
+1
-1
spec/models/ci/pipeline_artifact_spec.rb
spec/models/ci/pipeline_artifact_spec.rb
+1
-1
No files found.
spec/factories/ci/pipeline_artifacts.rb
View file @
53dfeeb6
...
...
@@ -15,7 +15,7 @@ FactoryBot.define do
end
trait
:with_multibyte_characters
do
size
{
{
"utf8"
=>
"✓"
}.
to_json
.
size
}
size
{
{
"utf8"
=>
"✓"
}.
to_json
.
byte
size
}
after
(
:build
)
do
|
artifact
,
_evaluator
|
artifact
.
file
=
CarrierWaveStringFile
.
new_file
(
file_content:
{
"utf8"
=>
"✓"
}.
to_json
,
...
...
spec/models/ci/pipeline_artifact_spec.rb
View file @
53dfeeb6
...
...
@@ -69,7 +69,7 @@ RSpec.describe Ci::PipelineArtifact, type: :model do
let
(
:coverage_report_multibyte
)
{
create
(
:ci_pipeline_artifact
,
:with_multibyte_characters
)
}
it
'sets the size in bytesize'
do
expect
(
coverage_report_multibyte
.
size
).
to
eq
(
1
2
)
expect
(
coverage_report_multibyte
.
size
).
to
eq
(
1
4
)
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment